From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21D42A0535; Tue, 4 Feb 2020 16:59:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 736C11C204; Tue, 4 Feb 2020 16:59:38 +0100 (CET) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id 64E381C199 for ; Tue, 4 Feb 2020 16:59:37 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id E1AE86AB1; Tue, 4 Feb 2020 10:59:35 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 04 Feb 2020 10:59:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=rGgWXP1znPX80LX+rxuXoCBHlc1YUOxEHwWYoaHzmcs=; b=Aup46lAT1IxL U/6D3tFS3UNaSHiF5hK7Ha3oKgaN0+zd3kgH20yGjr/Y6GTWuwFuPp8XJIkq9B5N oj3QCF38HQzLcbTxlSnHU2HPf1piDkVl6I23NUH9h8Ar0af893jdkGXRJ3avr/Ez ZKJ4QQIYRM/alaL9gP1mAaY9S1D6eUQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=rGgWXP1znPX80LX+rxuXoCBHlc1YUOxEHwWYoaHzm cs=; b=bXfq6SbLz1dGTl5i0/vaiqHiH06mMmOJOWNcIK4vKs8F/uve1AeYSaU// W89igaEfyjTDme129/OPhvyY/vSRuP8uja2nLzlLNJWhimpeB4TvKCE6zn6pu55c 5rzjLs1gRvZ4Q//w4vIE5uR967sqfVJgFa1tG8G3yNkVSwyatVxeHe3lnbP3A8kZ HoFe0Cet6ytCf1zHiLcK7bvKrmsFlPlT4qmPkHNeBRihhaCDOQk3XF3ozigejvu2 PWC8l6RjqbtnGy7HvrimoNA+G/r+tLESPn3Fy/K2dCERPTc273JMloNhqGG9tPK3 g7idgXqMrcLoWlW+McQ1+9qrhgedQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrgeelgdejkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7C2373280060; Tue, 4 Feb 2020 10:59:32 -0500 (EST) From: Thomas Monjalon To: "Trahe, Fiona" Cc: David Marchand , "nhorman@tuxdriver.com" , "bluca@debian.org" , "ktraynor@redhat.com" , Ray Kinsella , "dev@dpdk.org" , Akhil Goyal , "Yigit, Ferruh" , "Ananyev, Konstantin" , "dev@dpdk.org" , Anoob Joseph , "Kusztal, ArkadiuszX" , "Richardson, Bruce" , "Mcnamara, John" , "dodji@seketeli.net" , Andrew Rybchenko , "aconole@redhat.com" Date: Tue, 04 Feb 2020 16:59:30 +0100 Message-ID: <7712335.T7Z3S40VBb@xps> In-Reply-To: References: <20191220152058.10739-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/02/2020 16:52, Trahe, Fiona: > > > We are working on a patch, when it is ready we will send it. > > If it's not ready by end of your today, of course, go ahead with (b) and > > we will work towards 20.05. > > We will not be sending a patch today. > The patch we're working on will provide two versions of rte_cryptodev_info_get(), > both call the same PMD function from the dev_ops info_get fn ptr. > The default version operates s as normal, the 19.11 version searches > through the list returned by the PMD, looking for sym.aead.algo = ChaChaPoly, it needs to strip it from the list. > As PMDs just pass a ptr to their capabilities list ( it isn't a linked list, but an array > with an end marker = RTE_CRYPTODEV_END_OF_CAPABILITIES_LIST) if the API > layer detects Chacha it must allocate some space and store a local copy of the > trimmed list. This must be stored only once per device. I don't understand what you have to store. Can't you just set the algo to 0 if it is ChaCha? > This versioning will apply to any PMD which wants to take advantage of the new API between now and 20.11. > > Note, I expect the ABI checker tools will still complain of ABI breakage as the LIST_END value will still change. Right, you need to update the ignore list for the tool. > We are also reviewing all other cryptodev APIs in case there is any other API which needs versioning. > > Anyone see any problem with this approach? The other issue is with all other functions accepting this enum as input. We should continue returning an error if getting Chacha as input with 19.11 version of these functions. But I would tend to consider this small ABI breakage can be ignored as it is in the error path.