From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 905DAA0A0A; Thu, 20 May 2021 11:47:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C89241102; Thu, 20 May 2021 11:47:28 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id C701A41100 for ; Thu, 20 May 2021 11:47:26 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 182C05C01A3; Thu, 20 May 2021 05:47:26 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 20 May 2021 05:47:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= vXOn0aQUVp05VFPUEBJVS1f8UkImX/zJHZrBom4v0FU=; b=o6fRqQ+yG4d3FQyg Gl5P+kczoP2rTZY3BGiBOh6zOS4Row3VF5jyyPlT7IaavqC9gi994zIc1KjvZblT 4dvl9UwjenwqQC4NV1KUM2/p33/4EvWtXq6zIFcHWI7JGTbZ6+3gFBcBLz+6nEKL 4a2xOfkjObSkZQR9ABAYKlQMdAWB3G5gBJTDWLLj5MDc0Mctc/9RKCfIvlttCFno iwq055VZ/6VhBsdh0b0EPDuehVs1L85RULVv1L+d/UyJOXJRmK4MSyes/VtRJMsh m30BmU3nKcnMdN9HfTLfmHzh8/Y84tCgnghRa95HVF58zBS8BiHLRCveMmngADyu W2h6fw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=vXOn0aQUVp05VFPUEBJVS1f8UkImX/zJHZrBom4v0 FU=; b=Lprqv8ZobUJxTp/szkBWQibfnwjaINH35/L/lzg8jplzuBuC7CCOvESls dEgBokSZhfAofbM1lCX0S2ogC5M8sMpzEEbEns+p/HpPc6XFfpmvawUdCVK56VBl hMiyqaERYcOkaQLXyjIMnC3pwbaL1HN+CCEq9BTu0BIK3unN0jmp5fQVQ5NWF2rE rBsBvcxvb7ayJU4s5dcRENwCDx5qJaXUR1P55fPOOYu+Haw09TBr7GxEfJJ8zRtq A7HuLpBx+8yUygiS6CbWJKMTDoSs5IMYA6Yw4NWeULkr7av9wh4P867GWdCgn1Fi vB84CW2GWwsgaWVCRL0sX1LDDPeOg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejuddgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 20 May 2021 05:47:25 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, ferruh.yigit@intel.com Date: Thu, 20 May 2021 11:47:23 +0200 Message-ID: <7723733.VEPnZyPds5@thomas> In-Reply-To: <20210520075837.30954-1-david.marchand@redhat.com> References: <20210520075837.30954-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devtools: warn about release notes updates X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/05/2021 09:58, David Marchand: > Touching release notes should only be for the current version. > > Signed-off-by: David Marchand > --- > -VALIDATE_NEW_API=$(dirname $(readlink -f $0))/check-symbol-change.sh > +ROOTDIR=$(readlink -f $(dirname $(readlink -f $0))/..) > +VALIDATE_NEW_API=$ROOTDIR/devtools/check-symbol-change.sh > +FORBIDDEN_TOKENS_SCRIPT=$ROOTDIR/devtools/check-forbidden-tokens.awk This change is an unrelated cleanup. Do we keep it in this patch? I'm fine with it, just asking for clarification. > # Enable codespell by default. This can be overwritten from a config file. > # Codespell can also be enabled by setting DPDK_CHECKPATCH_CODESPELL to a valid path > @@ -58,7 +60,7 @@ check_forbidden_additions() { # > -v EXPRESSIONS="rte_panic\\\( rte_exit\\\(" \ > -v RET_ON_FAIL=1 \ > -v MESSAGE='Using rte_panic/rte_exit' \ > - -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ > + -f $FORBIDDEN_TOKENS_SCRIPT \ [...] > +check_release_notes() { # > + rel_notes_prefix=doc/guides/rel_notes/release_ > + current_version=$(cat $ROOTDIR/VERSION) > + major_version=${current_version%%.*} > + current_version=${current_version##${major_version}.} > + minor_version=${current_version%%.*} A simpler version: cat VERSION | IFS=. read major minor release > + current_rn=${rel_notes_prefix}${major_version}_${minor_version}.rst > + > + ! grep -e '^--- a/'$rel_notes_prefix -e '^+++ b/'$rel_notes_prefix $1 | Only the +++ part should matters. > + grep -v $current_rn > +} [...] > + ! $verbose || printf '\nChecking release notes updates:\n' > + report=$(check_release_notes "$tmpinput") > + if [ $? -ne 0 ] ; then > + $headline_printed || print_headline "$3" > + printf '%s\n' "$report" > + ret=1 > + fi Thanks for adding a new check. More is better :)