DPDK patches and discussions
 help / color / mirror / Atom feed
From: 钟 <gdsgsx2002@163.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: why DPDK reassembles IP fragment packets with AF_PACKET
Date: Tue, 9 Jan 2024 09:00:02 +0800 (CST)	[thread overview]
Message-ID: <77274de7.895.18cebbbcdb6.Coremail.gdsgsx2002@163.com> (raw)
In-Reply-To: <20240108084232.09500487@hermes.local>

[-- Attachment #1: Type: text/plain, Size: 1302 bytes --]

Hi Stephen,


Thank you for immediate response.


When PACKET_FANOUT_FLAG_DEFRAG flag is removed in AF_PACKET mode, IP fragment packets cannot be reassembled. That is what we expected or OVS expected.


The file drivers/net/af_packet/rte_net_af_packet.c +770
#if defined(PACKET_FANOUT) fanout_arg = (getpid() ^ (*internals)->if_index) & 0xffff; fanout_arg |= (PACKET_FANOUT_HASH | PACKET_FANOUT_FLAG_DEFRAG) << 16; ==> fanout_arg |= (PACKET_FANOUT_HASH) << 16; #if defined(PACKET_FANOUT_FLAG_ROLLOVER) fanout_arg |= PACKET_FANOUT_FLAG_ROLLOVER << 16; #endif #endif


Best regards,


Matthew














At 2024-01-09 00:42:32, "Stephen Hemminger" <stephen@networkplumber.org> wrote:
>On Mon, 8 Jan 2024 19:07:20 +0800 (CST)
>钟 <gdsgsx2002@163.com> wrote:
>
>> Hi All,
>> 
>> 
>> Recently I debug ovs-dpdk with AF_PACKET mode.  When IP fragment packets are received via DPDK, the IP fragment packets are reassembled by DPDK. After reassembly, the packet length is over 1518. They are discarded by OVS because of oversize packets.
>> 
>> 
>> I don't understandy why  PACKET_FLAG_DEFRAG is set for AF_PACKET mode.
>> 
>> 
>
>Not sure, but it looks like the af_packet wants to hash packets for fanout.
>Hashin of fragments won't work correctly, and packet will arrive on different queues if fragmented.

[-- Attachment #2: Type: text/html, Size: 2652 bytes --]

      reply	other threads:[~2024-01-09  7:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-08 11:07 
2024-01-08 16:42 ` Stephen Hemminger
2024-01-09  1:00   ` 钟 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77274de7.895.18cebbbcdb6.Coremail.gdsgsx2002@163.com \
    --to=gdsgsx2002@163.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).