DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Di, ChenxuX" <chenxux.di@intel.com>
To: "Guo, Jia" <jia.guo@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Xing, Beilei" <beilei.xing@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix out of bounds read issue
Date: Thu, 14 May 2020 06:41:12 +0000	[thread overview]
Message-ID: <7727d7be670b4820a8d1400ebeff8fe8@intel.com> (raw)
In-Reply-To: <479b7e59-053c-1675-3b0d-b1990a42eca3@intel.com>

Hi 

> -----Original Message-----
> From: Guo, Jia
> Sent: Thursday, May 14, 2020 2:17 PM
> To: Di, ChenxuX <chenxux.di@intel.com>; dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>
> Subject: Re: [PATCH v3] net/i40e: fix out of bounds read issue
> 
> 
> On 5/14/2020 9:16 AM, Di, ChenxuX wrote:
> > Hi,
> >
> >
> >
> >> -----Original Message-----
> >> From: Guo, Jia
> >> Sent: Wednesday, May 13, 2020 2:51 PM
> >> To: Di, ChenxuX <chenxux.di@intel.com>; dev@dpdk.org
> >> Cc: Xing, Beilei <beilei.xing@intel.com>
> >> Subject: Re: [PATCH v3] net/i40e: fix out of bounds read issue
> >>
> >> hi, chenxu
> >>
> >> On 5/13/2020 10:26 AM, Chenxu Di wrote:
> >>> This patch fixes (out-of-bounds read) coverity issue.
> >>>
> >>> Coverity issue: 357699
> >>> Coverity issue: 357694
> >>> Fixes: feaae285b342 ("net/i40e: support hash configuration in RSS
> >>> flow")
> >>>
> >>> Signed-off-by: Chenxu Di <chenxux.di@intel.com>
> >>> ---
> >>>    drivers/net/i40e/i40e_ethdev.c | 6 ++++++
> >>>    1 file changed, 6 insertions(+)
> >>>
> >>> diff --git a/drivers/net/i40e/i40e_ethdev.c
> >>> b/drivers/net/i40e/i40e_ethdev.c index 749d85f54..c2d5c6835 100644
> >>> --- a/drivers/net/i40e/i40e_ethdev.c
> >>> +++ b/drivers/net/i40e/i40e_ethdev.c
> >>> @@ -13179,6 +13179,9 @@ i40e_rss_config_hash_function(struct i40e_pf
> *pf,
> >>>    				break;
> >>>    		}
> >>>
> >>> +		if (i == UINT64_BIT)
> >>> +			return 0;
> >>> +
> >>
> >> Should this function need to return none zero value and show error
> >> info out, or said should considerate "out of bound" as a configure failed.
> >>
> > It will just find the flow type and do the things. If not find the flow type, it just
> do nothing and return.
> 
> 
> i40e_rss_config_hash_function is return int value right, should it always return 0?
> Should the case of not finding be considerate as none-success config?
> 

The original code has too many tabs (for->if->for->if ), it is over 90 words per line.
So just break and move it out .

After break the loop,
if the first loop go to the end without break, the value i will be 64 while the length of pf->adapter->pctypes_tbl is 64.
That is the reason of the out of bound which the original code will not cause.
 
Actually it will not happen the case of not finding. It is just the code fix the  out of bound caused by breaking the loop .


> 
> >>>    		for (j = I40E_FILTER_PCTYPE_INVALID + 1;
> >>>    		     j < I40E_FILTER_PCTYPE_MAX; j++) {
> >>>    			if (pf->adapter->pctypes_tbl[i] & (1ULL << j)) @@ -
> 13311,6
> >>> +13314,9 @@ i40e_rss_clear_hash_function(struct i40e_pf *pf,
> >>>    				break;
> >>>    		}
> >>>
> >>> +		if (i == UINT64_BIT)
> >>> +			return 0;
> >>> +
> >>>    		for (j = I40E_FILTER_PCTYPE_INVALID + 1;
> >>>    		     j < I40E_FILTER_PCTYPE_MAX; j++) {
> >>>    			if (pf->adapter->pctypes_tbl[i] & (1ULL << j))

  reply	other threads:[~2020-05-14  6:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-07  3:09 [dpdk-dev] [PATCH] " Chenxu Di
2020-05-07  5:15 ` Ye Xiaolong
2020-05-07  5:55   ` Di, ChenxuX
2020-05-07  6:30     ` Ye Xiaolong
2020-05-07  9:49 ` [dpdk-dev] [PATCH v2] " Chenxu Di
2020-05-08  2:26   ` Yang, Qiming
2020-05-08  2:36     ` Ye Xiaolong
2020-05-08  2:54       ` Yang, Qiming
2020-05-13  2:26 ` [dpdk-dev] [PATCH v3] " Chenxu Di
2020-05-13  6:51   ` Jeff Guo
2020-05-14  1:16     ` Di, ChenxuX
2020-05-14  6:17       ` Jeff Guo
2020-05-14  6:41         ` Di, ChenxuX [this message]
2020-05-14  7:07 ` [dpdk-dev] [PATCH v4] " Chenxu Di
2020-05-14  9:07   ` Jeff Guo
2020-05-15  3:22   ` Ye Xiaolong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7727d7be670b4820a8d1400ebeff8fe8@intel.com \
    --to=chenxux.di@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jia.guo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).