From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49])
 by dpdk.org (Postfix) with ESMTP id 770492BDB
 for <dev@dpdk.org>; Fri, 11 Mar 2016 10:29:53 +0100 (CET)
Received: by mail-wm0-f49.google.com with SMTP id p65so9537366wmp.0
 for <dev@dpdk.org>; Fri, 11 Mar 2016 01:29:53 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:organization:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=6rZKJermYzuWBbK7JZfyJ5Mh0cavOHGASuLUFd1TX3Y=;
 b=C3Iwa6isMz2lhlzcDzuQHHoHv+5eTuIfaji9vqgF6sJj19IgudTONwU2R24DgAS2LE
 92Q5gvHLZzPXpiaLXXJR2e/ay1AbDQnBXcCFn7KVSXIHuY97h0bRPd9PDakeXAY6D6rA
 uOPVhZ17Dj+cl5lwpuHYp6CpuxNB9hMIW/l460z2Lawz/f8hkjEoYMQaybChFDd1HYRv
 7UcNCD2zA/YGEvu661LeQFivdex7suhXR681PXkpDFpzsURr68JntJWRg+sWu+N8Hp8i
 XecD6VwxUGjmWJRPWzRC8rvTqHNdrQycNiThbuT8owGzZD4BsSKm486NAnAWtX8erepF
 TJ8w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=6rZKJermYzuWBbK7JZfyJ5Mh0cavOHGASuLUFd1TX3Y=;
 b=VtuUpbck7aUjJj9No2ZlWpFhr+rleTbdlOrM9aDa9f0fQlMFdegEmQ9K8/8funL5c+
 l1Iu1+qETDKQLUeHyT8CiZtBk+c9KmOoN+WMTP/vHmO+j1t2Xw9IRt5AjuKiGtigVe5t
 nCTcV9Ed9JGAUfU11ocbmSNH1kJ764ihSeudmlnpZAlMBYU7OOotUX21bRrPRK+5xWT4
 qpc5hKmKkKsU0guhhpxm/mS+B4IB/1ODLs+9yOoMrxfW+lZgbcyP1ikk6IfomYi7nqbn
 4SPCL4w7IfwLPTB/vOX8weY1XDlheFVH+T7x2WjGwNgZDaDJknWTUp3JJ0WFK8aVy+a6
 hoxA==
X-Gm-Message-State: AD7BkJL8R7I+5jTfmHwc5KFPwkhPuxV2cW5VyRkYh9WEFC7NJBwb3nbeYZ4z5igDQcQue6O7
X-Received: by 10.28.173.71 with SMTP id w68mr1787786wme.88.1457688593378;
 Fri, 11 Mar 2016 01:29:53 -0800 (PST)
Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91])
 by smtp.gmail.com with ESMTPSA id x203sm1331385wmg.23.2016.03.11.01.29.52
 (version=TLSv1/SSLv3 cipher=OTHER);
 Fri, 11 Mar 2016 01:29:52 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Panu Matilainen <pmatilai@redhat.com>
Date: Fri, 11 Mar 2016 10:28:10 +0100
Message-ID: <7728480.8SZanX4UKp@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <9127451bf67ce08532a327cb66aefbcf7ed5b39f.1457687628.git.pmatilai@redhat.com>
References: <9127451bf67ce08532a327cb66aefbcf7ed5b39f.1457687628.git.pmatilai@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: crypto pmds can only be built if
	librte_cryptodev is enabled
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Mar 2016 09:29:53 -0000

2016-03-11 11:13, Panu Matilainen:
> If the experimental CONFIG_RTE_LIBRTE_CRYPTODEV is disabled,
> build of any crypto pmds will fail because of the missing dependency.
> This has been present for a while now but hidden until the addition
> of null_crypto since all the other crypto pmds have been disabled
> by default.

Good catch, thanks.

> +ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y)
>  DIRS-y += crypto
> +endif

Why not 
DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto ?