* [dpdk-dev] [PATCH] mk: crypto pmds can only be built if librte_cryptodev is enabled
@ 2016-03-11 9:13 Panu Matilainen
2016-03-11 9:28 ` Thomas Monjalon
2016-03-11 9:40 ` Thomas Monjalon
0 siblings, 2 replies; 4+ messages in thread
From: Panu Matilainen @ 2016-03-11 9:13 UTC (permalink / raw)
To: dev
If the experimental CONFIG_RTE_LIBRTE_CRYPTODEV is disabled,
build of any crypto pmds will fail because of the missing dependency.
This has been present for a while now but hidden until the addition
of null_crypto since all the other crypto pmds have been disabled
by default.
Conditionalize the entire drivers/crypto directory on
CONFIG_RTE_LIBRTE_CRYPTODEV to fix.
Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices")
Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
---
drivers/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/Makefile b/drivers/Makefile
index 6ec67f6..c6758a1 100644
--- a/drivers/Makefile
+++ b/drivers/Makefile
@@ -32,6 +32,8 @@
include $(RTE_SDK)/mk/rte.vars.mk
DIRS-y += net
+ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y)
DIRS-y += crypto
+endif
include $(RTE_SDK)/mk/rte.subdir.mk
--
2.5.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] mk: crypto pmds can only be built if librte_cryptodev is enabled
2016-03-11 9:13 [dpdk-dev] [PATCH] mk: crypto pmds can only be built if librte_cryptodev is enabled Panu Matilainen
@ 2016-03-11 9:28 ` Thomas Monjalon
2016-03-11 9:38 ` Panu Matilainen
2016-03-11 9:40 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2016-03-11 9:28 UTC (permalink / raw)
To: Panu Matilainen; +Cc: dev
2016-03-11 11:13, Panu Matilainen:
> If the experimental CONFIG_RTE_LIBRTE_CRYPTODEV is disabled,
> build of any crypto pmds will fail because of the missing dependency.
> This has been present for a while now but hidden until the addition
> of null_crypto since all the other crypto pmds have been disabled
> by default.
Good catch, thanks.
> +ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y)
> DIRS-y += crypto
> +endif
Why not
DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto ?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] mk: crypto pmds can only be built if librte_cryptodev is enabled
2016-03-11 9:28 ` Thomas Monjalon
@ 2016-03-11 9:38 ` Panu Matilainen
0 siblings, 0 replies; 4+ messages in thread
From: Panu Matilainen @ 2016-03-11 9:38 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev
On 03/11/2016 11:28 AM, Thomas Monjalon wrote:
> 2016-03-11 11:13, Panu Matilainen:
>> If the experimental CONFIG_RTE_LIBRTE_CRYPTODEV is disabled,
>> build of any crypto pmds will fail because of the missing dependency.
>> This has been present for a while now but hidden until the addition
>> of null_crypto since all the other crypto pmds have been disabled
>> by default.
>
> Good catch, thanks.
>
>> +ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y)
>> DIRS-y += crypto
>> +endif
>
> Why not
> DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto ?
Just because old habits ... and ... you know :)
Should I send a new version or can you fix that up when committing?
- Panu -
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] mk: crypto pmds can only be built if librte_cryptodev is enabled
2016-03-11 9:13 [dpdk-dev] [PATCH] mk: crypto pmds can only be built if librte_cryptodev is enabled Panu Matilainen
2016-03-11 9:28 ` Thomas Monjalon
@ 2016-03-11 9:40 ` Thomas Monjalon
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2016-03-11 9:40 UTC (permalink / raw)
To: Panu Matilainen; +Cc: dev
2016-03-11 11:13, Panu Matilainen:
> If the experimental CONFIG_RTE_LIBRTE_CRYPTODEV is disabled,
> build of any crypto pmds will fail because of the missing dependency.
> This has been present for a while now but hidden until the addition
> of null_crypto since all the other crypto pmds have been disabled
> by default.
>
> Conditionalize the entire drivers/crypto directory on
> CONFIG_RTE_LIBRTE_CRYPTODEV to fix.
>
> Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices")
>
> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
Applied with small rework, thanks.
> +ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y)
> DIRS-y += crypto
> +endif
DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-11 9:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-11 9:13 [dpdk-dev] [PATCH] mk: crypto pmds can only be built if librte_cryptodev is enabled Panu Matilainen
2016-03-11 9:28 ` Thomas Monjalon
2016-03-11 9:38 ` Panu Matilainen
2016-03-11 9:40 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).