From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91708A0561; Sun, 19 Apr 2020 16:40:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 564221D5C3; Sun, 19 Apr 2020 16:40:48 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id E4CA91D5B6 for ; Sun, 19 Apr 2020 16:40:46 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id C2E7D658; Sun, 19 Apr 2020 10:40:45 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sun, 19 Apr 2020 10:40:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= ZGibkq5JC+gnxKbzYUjJCcmC+VCBwWsoH2l908Pkjk8=; b=Po3ncFMXBOGbmqNa Yl/YjR9fTpcFEiOjSzIm5Yj0umbLvhpMMPeR4sNaCgSwUbHj/alXAdQ12MNr/Y1B ZEyaQLw7ngBkaW9QBI6t5x2UBt5JwETIvFs0e1SCfdn5LaY8H9Z4/3zi/TvzIQ9K KRwWs+8OMm6wGKLSOxT1slCLVhQrnWATwgd/lqosRDraoWEbbOMh/iIJZsQUuFUO raAN7emABx18yWKLyqT5NZ29QMivCxineE5F/leuINIi9TRV6AbIZMFJGjIGI52P YgzdEgaJLBZxQWTdseb6iVnQK2ntNAFl5ukGb7VEfsGqfBAeoTnt7yxqP/F31lcK CjprYw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ZGibkq5JC+gnxKbzYUjJCcmC+VCBwWsoH2l908Pkj k8=; b=h4aEpvKA8t2ss2X+1iRYFGJ5jOHiE2Nbkgk5rlaHUpA5AnYWL5D77TkKQ ZlAR3D6ihclZ4uQsQ6KrqU+NSduUAv3Db7rh+W10ny/VWQ+uxvgd1LR4zgU1gzmp 2ZXIrYaxDeo+S9sBGrav3+Hx4DaVSWjpQgWoZjvvk2YmDI6yjAKlNNveOfhwIAUl eiit1Eg30XW+8oWR76+MLrqQ0GQvg0OpHgQOr6BC3VRpMQanlg4xtl3ZVQQmutnH zmwvNxWIP30c7asIp7UOwqcjKU6P8cCgJkfi7h9ya8JJmIrlOXq2/GkrY6mB9Dox ZWCGaxHc/rqQmU4pgf1k5a50ws0Sw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrgedugdektdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepmhgvshhonhgsuhhilhgurdgtohhmnecukfhppeejjedrudefgedrvddtfedr udekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 87E5E306226E; Sun, 19 Apr 2020 10:40:44 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev , Bruce Richardson Date: Sun, 19 Apr 2020 16:40:43 +0200 Message-ID: <7731702.hy9JHpt1j4@thomas> In-Reply-To: <3210362.Bm8zEkEi59@thomas> References: <20200418131942.1388633-1-thomas@monjalon.net> <3210362.Bm8zEkEi59@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devtools: reduce examples in static builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/04/2020 16:29, Thomas Monjalon: > 19/04/2020 09:08, David Marchand: > > On Sat, Apr 18, 2020 at 3:20 PM Thomas Monjalon wrote: > > > --- a/devtools/test-meson-builds.sh > > > +++ b/devtools/test-meson-builds.sh > > > - options="$options --werror -Dexamples=all" > > > + options="$options --werror" > > > + if echo $* | grep -qw -- '--default-library=static' ; then > > > + options="$options -Dexamples=l3fwd" > > > + else > > > + options="$options -Dexamples=all" > > > + fi > > > > Ok, this is hypothetical, but this would not work when no > > default-library option is passed (static is the default value). > > No, with meson, shared is the default: > https://mesonbuild.com/Builtin-options.html#core-options Thanks to an offline explanation, it appears I'm wrong. The default value is changed in our root meson.build file: default_options: ['buildtype=release', 'default_library=static'], > > How about inverting the check and look for default-library=shared ? Yes I will invert the check in v2. > > Besides, you won't catch already configured directories. > > While for make environments, this change will have an effect right away. > > Yes, I think it is OK to keep old configuration in meson builds > until the build directories are trashed.