From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA1254334B; Fri, 17 Nov 2023 02:35:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 291264067B; Fri, 17 Nov 2023 02:35:41 +0100 (CET) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id 9FE3A4014F for ; Fri, 17 Nov 2023 02:35:39 +0100 (CET) Received: from kwepemm000004.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4SWfXH5t37z1P8GY; Fri, 17 Nov 2023 09:32:15 +0800 (CST) Received: from [10.67.121.59] (10.67.121.59) by kwepemm000004.china.huawei.com (7.193.23.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Fri, 17 Nov 2023 09:35:37 +0800 Message-ID: <7733f1a7-1c70-1724-7d3d-13e798d30932@huawei.com> Date: Fri, 17 Nov 2023 09:35:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] net/gve: add support for max_rx_bufsize To: Joshua Washington , Junfeng Guo , Jeroen de Borst , Rushil Gupta CC: , Ferruh Yigit References: <20231116221605.2240305-1-joshwash@google.com> From: "lihuisong (C)" In-Reply-To: <20231116221605.2240305-1-joshwash@google.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.59] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm000004.china.huawei.com (7.193.23.18) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 在 2023/11/17 6:16, Joshua Washington 写道: > The new max_rx_bufsize field in dev_info can be used to guide mbuf sizes > chosen by DPDK programs by ensuring that DPDK programs do not waste > memory by using an mbuf size too large for the maximum RX buffer size. > This patch adds support for this field in the GVE PMD. > > Signed-off-by: Joshua Washington > Reviewed-by: Rushil Gupta > --- > drivers/net/gve/gve_ethdev.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c > index 43b4ab523d..001cae2b98 100644 > --- a/drivers/net/gve/gve_ethdev.c > +++ b/drivers/net/gve/gve_ethdev.c > @@ -296,10 +296,14 @@ gve_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) > dev_info->max_mac_addrs = 1; > dev_info->max_rx_queues = priv->max_nb_rxq; > dev_info->max_tx_queues = priv->max_nb_txq; > - if (gve_is_gqi(priv)) > + if (gve_is_gqi(priv)) { > dev_info->min_rx_bufsize = GVE_RX_MIN_BUF_SIZE_GQI; > - else > + dev_info->max_rx_bufsize = GVE_RX_MAX_BUF_SIZE_GQI; > + } else { > dev_info->min_rx_bufsize = GVE_RX_MIN_BUF_SIZE_DQO; > + dev_info->max_rx_bufsize = GVE_RX_MAX_BUF_SIZE_DQO; > + } nice Reviewed-by: Huisong Li > + > dev_info->max_rx_pktlen = priv->max_mtu + RTE_ETHER_HDR_LEN; > dev_info->max_mtu = priv->max_mtu; > dev_info->min_mtu = RTE_ETHER_MIN_MTU;