From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 0D7A49ABF for ; Tue, 14 Jun 2016 21:10:54 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id k204so4525301wmk.0 for ; Tue, 14 Jun 2016 12:10:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=sUN6xwoTKMgLKvyUbSok3O27d57OmFWhSx//unMoAnQ=; b=OPmUZHe/PCJ2daMKa3A1W1TI8S84qkLwTMGyzau2s+QEUqB79X8Vb9wyhu2POIBFk9 5tzdat75Q0DeSbjHPItk+L6I1eaVMhl3dekWxJi9HyqQautKfukOB8A5EuRVVx0fuqa0 ppzZCNBDiNH5+SHzZM55UWWVPBnTLapjVFSsQ1werwSBYzQhxk0XNe8HhiXpNenv3jMV Iy6tnX4bX2pynG4o0+HmcuHeK/edVmR3SI/IHLGU0QiJgrPjt215art1IhAwO7vKdv7c QHP8y4Ye2PehoYlLACo3aOIIhDjUpzRv+X8ZskvhSK8cUjgutA7KZeFbWkazCavqr4zx bvAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=sUN6xwoTKMgLKvyUbSok3O27d57OmFWhSx//unMoAnQ=; b=U1OWrJ8P6bSCHd+Polx1pMK3rfq4EwlDxKUnhZmaA2rbi+lDildkqCenysnJVA/efq Q5NnvhW1etjSNPGs/+vvuvK8Ygh15Cye6PFoClX7fHX4VLhGlFGNylnQRQjV++JgEgdE VBIQdUNIC941COF2I72BiB3Be3FWcMkWoFicpxcGhwXWSIKLjIU1rDUrv36Y487Af9vy uNgizdUAO6eWOojx+Q0WgwLgrJTD8CUYLinqNtA8MLKOsDy6CbYP59UjjKgU3bD0flJJ oow+jmY97xh6CAg1qQru90RLWvNFWh8gNQpmGBbBgJBJwFTdalgHSh8ilVBS6gLeyYbU pMQA== X-Gm-Message-State: ALyK8tI9VG5Ay4Hr/b/O/mYEfJOvy0j2LAKGUIwrr+6nHYlE84mZF9Iq26tLtPbg5VmXQSkB X-Received: by 10.28.132.144 with SMTP id g138mr6155665wmd.47.1465931453829; Tue, 14 Jun 2016 12:10:53 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id s67sm4826512wmf.3.2016.06.14.12.10.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Jun 2016 12:10:53 -0700 (PDT) From: Thomas Monjalon To: "Kerlin, MarcinX" Cc: dev@dpdk.org, "Dumitrescu, Cristian" , "Azarewicz, PiotrX T" Date: Tue, 14 Jun 2016 21:10:52 +0200 Message-ID: <7742479.vO64Iz13lh@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D8912647A0255F@IRSMSX108.ger.corp.intel.com> References: <1465810549-19097-1-git-send-email-marcinx.kerlin@intel.com> <3EB4FA525960D640B5BDFFD6A3D8912647A0255F@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/1] ip_pipeline: fix null pointer dereference X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jun 2016 19:10:54 -0000 > > Return value of function app_pipeline_type_find is not checking before > > dereference. Fix this problem by adding checking condition. > > > > Coverity issue: 127196 > > Fixes: b4aee0fb9c6d ("examples/ip_pipeline: reconfigure thread binding > > dynamically") > > > > Signed-off-by: Marcin Kerlin > Hi Marcin, > > Checking p_type at this point is not required, as we already validated the pipeline settings (including the pipeline type) as part of the init code. > > But since this code is harmless I am acking this patch just to avoid having the same discussion about this Coverity false positive issue again. > > Regards, > Cristian > > Acked-by: Cristian Dumitrescu Applied, thanks