Re: [dpdk-dev] [PATCH v2] net/mlx5: do not allow copy to mark via modify field

[Thomas Monjalon <thomas@monjalon.net>]

16/07/2021 12:47, Slava Ovsiienko:
> > -----Original Message-----
> > From: Alexander Kozyrev <akozyrev@nvidia.com>
> > Sent: Friday, July 16, 2021 11:43
> > To: dev@dpdk.org
> > Cc: Raslan Darawsheh <rasland@nvidia.com>; Matan Azrad
> > <matan@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
> > Subject: [PATCH v2] net/mlx5: do not allow copy to mark via modify field
> > 
> > The Mark action is a two-stage process in the Mellanox driver.
> > First, a hardware register is filled with the required value, then this value is
> > registered in the software resource table.
> > 
> > The MODIFY_FIELD action can instruct a Mellanox NIC to copy some value
> > from an arbitrary packet header field into the hardware register, associated
> > with the Mark item. But there is no way NIC can modify the software
> > resource table as well.
> > 
> > Due to these driver limitations the copying of arbitrary value to the MARK can
> > not be supported and should be rejected in the MODIFY_FIELD action.
> > 
> Thank you, Alexander
> 
> > Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

Applied, thanks.