From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 579BAA0547; Thu, 22 Jul 2021 16:28:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D5DD44014D; Thu, 22 Jul 2021 16:28:34 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 507E540040 for ; Thu, 22 Jul 2021 16:28:33 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id D41DF5C0140; Thu, 22 Jul 2021 10:28:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 22 Jul 2021 10:28:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= dIfSFl85qC2BcoZfuu8y2A8qZrSWa85NA00gUWLvREw=; b=if+lxf5ED3tv22nP HXCq6i/IjWvDzsLZYtOctQaFol9rlhipOZfcMnrQhSgrjWW7wZmCFXWWkTY42sWB mrYZuvO8kCBRBdulHsBlx+Ejr+cBf9h5FR0v+Uuan+tuj9AClxPNgFNE13O2Ksxy bXSblnC8WEGSOyR2cP1pfK7mgqRapNPbgP9FWKbICWDrxsPhlaPrE6kGlFYuTUk0 eZexMNw44q/TY/0pr7ioSDcDndU2v0Cjfl2rZqLfLFUX23g2mMmSw8YBN3uSOj5V CErFpy2LhIcY7yLBQ9lky7HkoZgGI6LCJBegqnvWP/41o6Y8bLEQoPl4tfGygw7U MS2n7A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=dIfSFl85qC2BcoZfuu8y2A8qZrSWa85NA00gUWLvR Ew=; b=WEEJU5Ex5iT7r7SMlcHMPt+t0ATGOcrrQp+LgCVmu4164QkE2vsu4JeqB u8OvuqZtVRpB9jU9up826DYZIMh1VL5nj74wPD6l6b3Y/eP5TCpwZKJW4ceew8UW sxxP7ArXerjMmriQ4ASOxVtSroKVKvh4TOtfg9hqlfxF9As46iKtCYwQV6uzb+tR ZuaXDRxMTRFmJRq5KHKZc1EYLrBafEo0ddqHA34pipE+G3ubRjrrbJwdJL5EgHGM Bo73akO/VWu7WYoZj/dPCWbRHP+1+lgLGyMgLVZ0Qlj68zJRUe+593XNvuCkOXVR cjN24lSjn6ljQark6ffYM8Cs+adKw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrfeeigdejgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Jul 2021 10:28:31 -0400 (EDT) From: Thomas Monjalon To: Alexander Kozyrev Cc: "dev@dpdk.org" , Raslan Darawsheh , Matan Azrad , Slava Ovsiienko Date: Thu, 22 Jul 2021 16:28:49 +0200 Message-ID: <77476477.DtaZy5j6p8@thomas> In-Reply-To: References: <20210616183444.2815030-1-akozyrev@nvidia.com> <20210716084305.646731-1-akozyrev@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: do not allow copy to mark via modify field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/07/2021 12:47, Slava Ovsiienko: > > -----Original Message----- > > From: Alexander Kozyrev > > Sent: Friday, July 16, 2021 11:43 > > To: dev@dpdk.org > > Cc: Raslan Darawsheh ; Matan Azrad > > ; Slava Ovsiienko > > Subject: [PATCH v2] net/mlx5: do not allow copy to mark via modify field > > > > The Mark action is a two-stage process in the Mellanox driver. > > First, a hardware register is filled with the required value, then this value is > > registered in the software resource table. > > > > The MODIFY_FIELD action can instruct a Mellanox NIC to copy some value > > from an arbitrary packet header field into the hardware register, associated > > with the Mark item. But there is no way NIC can modify the software > > resource table as well. > > > > Due to these driver limitations the copying of arbitrary value to the MARK can > > not be supported and should be rejected in the MODIFY_FIELD action. > > > Thank you, Alexander > > > Signed-off-by: Alexander Kozyrev > Acked-by: Viacheslav Ovsiienko Applied, thanks.