* [dpdk-dev] [PATCH] crypto/dpaa2_sec: fix build with GCC 6 or prior
@ 2018-01-30 9:23 Hemant Agrawal
2018-01-30 14:01 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Hemant Agrawal @ 2018-01-30 9:23 UTC (permalink / raw)
To: dev, thomas
This patch fixes the compilation with compiler GCC < 7
dpaa2_sec/hw/rta/operation_cmd.h:12:32: error: unknown option after
‘#pragma GCC diagnostic’ kind [-Werror=pragmas]
#pragma GCC diagnostic ignored "-Wimplicit-fallthrough"
Fixes: 2ab9a9483196 ("crypto/dpaa2_sec: fix build with GCC 7")
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
drivers/crypto/dpaa2_sec/hw/rta/operation_cmd.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/crypto/dpaa2_sec/hw/rta/operation_cmd.h b/drivers/crypto/dpaa2_sec/hw/rta/operation_cmd.h
index c4febcb..90ce39f 100644
--- a/drivers/crypto/dpaa2_sec/hw/rta/operation_cmd.h
+++ b/drivers/crypto/dpaa2_sec/hw/rta/operation_cmd.h
@@ -8,7 +8,9 @@
#ifndef __RTA_OPERATION_CMD_H__
#define __RTA_OPERATION_CMD_H__
+#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION > 70000)
#pragma GCC diagnostic ignored "-Wimplicit-fallthrough"
+#endif
extern enum rta_sec_era rta_sec_era;
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: fix build with GCC 6 or prior
2018-01-30 9:23 [dpdk-dev] [PATCH] crypto/dpaa2_sec: fix build with GCC 6 or prior Hemant Agrawal
@ 2018-01-30 14:01 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2018-01-30 14:01 UTC (permalink / raw)
To: Hemant Agrawal; +Cc: dev
30/01/2018 10:23, Hemant Agrawal:
> This patch fixes the compilation with compiler GCC < 7
>
> dpaa2_sec/hw/rta/operation_cmd.h:12:32: error: unknown option after
> ‘#pragma GCC diagnostic’ kind [-Werror=pragmas]
> #pragma GCC diagnostic ignored "-Wimplicit-fallthrough"
>
> Fixes: 2ab9a9483196 ("crypto/dpaa2_sec: fix build with GCC 7")
Sorry for having broken it with a quick fix yesterday.
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
[...]
> +#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION > 70000)
> #pragma GCC diagnostic ignored "-Wimplicit-fallthrough"
> +#endif
I think it must be GCC_VERSION >= 70000
Applied with this change, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-30 14:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-30 9:23 [dpdk-dev] [PATCH] crypto/dpaa2_sec: fix build with GCC 6 or prior Hemant Agrawal
2018-01-30 14:01 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).