From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 43E121B3E0
 for <dev@dpdk.org>; Tue, 30 Jan 2018 15:01:54 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id C3F6E20F01;
 Tue, 30 Jan 2018 09:01:53 -0500 (EST)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Tue, 30 Jan 2018 09:01:53 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=YjUFCBWnnfXRL05lycRjqQSjtV
 05ER0R65vKSHzktGQ=; b=Y7iKL0glFDzye1tmqJnPyocuAN/nGCVLhyrVhTFL+L
 d933DL0ZCSt3E9cTQ6zW21vUF+J3zqpFQqTMpkTT6OV4aOGlt679eaqwOMDSqOAx
 QizjGWTVOlZzb4w3nHyJCeOGlcyiY5smhK0xpOcPnFx2uSChFq+YSwmiy15pSyWl
 8=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=YjUFCB
 WnnfXRL05lycRjqQSjtV05ER0R65vKSHzktGQ=; b=kpCKyGX+mOL9G8C6hMqBkB
 M9Um2e3iaB8uuvW+oneXJqBrhpAN30szjAOvZpN6n+XMn5ZWmnBW84F8nVBz02TE
 bsyPiPS/5FpdU7/edtydsCq5eAQK/UUMPoOwvPSBU6KxL36arTogT8nALtFdE0UL
 dUUKa2zp6CZ2Le9MbqU5VTcRXdhUGPuXdD5wH8YXQfR6ikJl7PuC7VfB8rE+tpIv
 fP6uvLEDLE5klSqZHJc07AyKSXMgTudr8RP3GVMuQ5qYMYmKwi+y2pdglldopEeQ
 wTfEhRlOAWfBbOK+SB5Gw9Z5XlBziwvq4XHtGaCvnRPe7ijvd/XkOxUNhUMyXSsQ
 ==
X-ME-Sender: <xms:0XpwWiGnOKlhlzMDmd_ojGx9xMAg4Yqefh0u5KUUbK_aPSn8EtxD-g>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 4CBDA24724;
 Tue, 30 Jan 2018 09:01:53 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: dev@dpdk.org
Date: Tue, 30 Jan 2018 15:01:07 +0100
Message-ID: <7749257.NxZygTFbjZ@xps>
In-Reply-To: <1517304210-15061-1-git-send-email-hemant.agrawal@nxp.com>
References: <1517304210-15061-1-git-send-email-hemant.agrawal@nxp.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: fix build with GCC 6 or
	prior
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Jan 2018 14:01:54 -0000

30/01/2018 10:23, Hemant Agrawal:
> This patch fixes the compilation with compiler GCC < 7
>=20
> dpaa2_sec/hw/rta/operation_cmd.h:12:32: error: unknown option after
>  =E2=80=98#pragma GCC diagnostic=E2=80=99 kind [-Werror=3Dpragmas]
>  #pragma GCC diagnostic ignored "-Wimplicit-fallthrough"
>=20
> Fixes: 2ab9a9483196 ("crypto/dpaa2_sec: fix build with GCC 7")

Sorry for having broken it with a quick fix yesterday.

> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
[...]
> +#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION > 70000)
>  #pragma GCC diagnostic ignored "-Wimplicit-fallthrough"
> +#endif

I think it must be GCC_VERSION >=3D 70000

Applied with this change, thanks