From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57EB4436FF; Fri, 15 Dec 2023 17:21:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 468BC42E30; Fri, 15 Dec 2023 17:21:29 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 97075402F1 for ; Fri, 15 Dec 2023 17:21:27 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id D5BCB5C0111; Fri, 15 Dec 2023 11:21:25 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 15 Dec 2023 11:21:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1702657285; x=1702743685; bh=MKEvVmnkYSk7H6XaccXhSOGy+ofY6r7sElLL2E/CpiQ=; b= gN4LJM1sXdCoiXb4Nq3bfJZMm37CI+eAHT741JkA65StMBvoaDRgEU3b4hTOcd9K Nkcqwnyd2xxRFta6b0Rq0vunMGv8waMlNsxdV8D+fsar/MDBjTrxugNnQ/0C9Jw/ lpdEicqwQcukubNg7hKA0oGrvCXlAFOokDswXzrMATxILDsSko8tKtlH4suU0MhO feHSY/cekwK1pTkdzaxEgJx59YVjZ0zp8lL+eKVp+4V0//B2o/8BfJFryvQHFpei XUoqNhxx9WXxFHA81320IVbvug4J20LyXdunhCmJiooQyL/XG/uOF9mkEg5eKakB XvmVs6otazD20zZBAijY0Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1702657285; x= 1702743685; bh=MKEvVmnkYSk7H6XaccXhSOGy+ofY6r7sElLL2E/CpiQ=; b=H rIUpnQgkC89JXuhvlETSp6hNhiE0qdxnyDZDWE9y/Tlqe18I4qPuVQpF/K8ocUjn 5meXqotBxtAvZKqVWdJnVca3O1eKzrBFY0nlt5yIpceltPq4hR+sqi4POmZfd9Ld pjycuX4wjtP+WxSSjxknQAEB0GdJI+frTVIb6Am7BNzBuno99Jt/oSYazCzmQM21 CZAnUkP8E2F7Q2GSboc26JzJALO2DUIApK8obsN2Iw3Nvt6SLBeRCMhqvSdIqgkP /+u3APiBXW5nDbKlkcoPxAISbUJB7X7t4+BXYhKK+d3sOoWWLNkqTLeMnXdkJt17 oHnGce82kQrqofYLvDziw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddtvddgkeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeegtddtleejjeegffekkeektdejvedtheevtdekiedvueeuvdei uddvleevjeeujeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 15 Dec 2023 11:21:23 -0500 (EST) From: Thomas Monjalon To: Stephen Hemminger , Ori Kam , Ferruh Yigit Cc: "Dumitrescu, Cristian" , Dariusz Sosnowski , Andrew Rybchenko , "dev@dpdk.org" , Raslan Darawsheh Subject: Re: [RFC] ethdev: introduce entropy calculation Date: Fri, 15 Dec 2023 17:21:21 +0100 Message-ID: <7755907.4vTCxPXJkl@thomas> In-Reply-To: <09acf24d-fc48-44cd-aa4c-9e810bd96f85@amd.com> References: <20231210083100.7893-1-orika@nvidia.com> <20231214092609.1b109278@hermes.local> <09acf24d-fc48-44cd-aa4c-9e810bd96f85@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 15/12/2023 14:44, Ferruh Yigit: > On 12/14/2023 5:26 PM, Stephen Hemminger wrote: > > On Thu, 14 Dec 2023 17:18:25 +0000 > > Ori Kam wrote: > >=20 > >>>> Since encap groups number of different 5 tuples together, if HW does= n=E2=80=99t know > >>>> how to RSS > >>>> based on the inner application will not be able to get any distribut= ion of =20 > >>> packets. =20 > >>>> > >>>> This value is used to reflect the inner packet on the outer header, = so =20 > >>> distribution =20 > >>>> will be possible. > >>>> > >>>> The main use case is, if application does full offload and implement= s the encap =20 > >>> on =20 > >>>> the RX. > >>>> For example: > >>>> Ingress/FDB match on 5 tuple encap send to hairpin / different port= in case of > >>>> switch. > >>>> =20 > >>> > >>> Smart idea! So basically the user is able to get an idea on how good = the RSS > >>> distribution is, correct? > >>> =20 > >> > >> Not exactly, this simply allows the distribution. > >> Maybe entropy is a bad name, this is the name they use in the protocol= , but in reality > >> this is some hash calculated on the packet header before the encap and= set in the encap header. > >> Using this hash results in entropy for the packets. Which can be used = for load balancing. > >> > >> Maybe better name would be: > >> Rte_flow_calc_entropy_hash? > >> > >> or maybe rte_flow_calc_encap_hash (I like it less since it looks like = we calculate the hash on the encap data and not the inner part) > >> > >> what do you think? > >=20 > > Entropy has meaning in crypto and random numbers generators that is dif= ferent from > > this usage. So entropy is bad name to use. Maybe rte_flow_hash_distribu= tion? > > >=20 > Hi Ori, >=20 > Thank you for the description, it is more clear now. >=20 > And unless this is specifically defined as 'entropy' in spec, I am too > for rename. >=20 > At least in VXLAN spec, it is mentioned that this field is to "enable a > level of entropy", but not exactly names it as entropy. Exactly my thought about the naming. Good to see I am not alone thinking this naming is disturbing :)