From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ferruh.yigit@intel.com> Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 97BF61B118 for <dev@dpdk.org>; Fri, 21 Sep 2018 18:54:21 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Sep 2018 09:54:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,285,1534834800"; d="scan'208";a="71878340" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.39]) ([10.237.221.39]) by fmsmga007.fm.intel.com with ESMTP; 21 Sep 2018 09:53:51 -0700 To: Paul Luse <paul.e.luse@intel.com>, dev@dpdk.org References: <20180921162557.48249-1-paul.e.luse@intel.com> From: Ferruh Yigit <ferruh.yigit@intel.com> Openpgp: preference=signencrypt Message-ID: <7758f4c8-ee1f-ae3c-e9ea-7669d3d7f67a@intel.com> Date: Fri, 21 Sep 2018 17:53:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180921162557.48249-1-paul.e.luse@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] vdev: free reply.msgs memory for secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 21 Sep 2018 16:54:22 -0000 On 9/21/2018 5:25 PM, Paul Luse wrote: > From: paul luse <paul.e.luse@intel.com> > > This patch fixes an issue caught with ASAN where a vdev_scan() > to a secondary bus was failing to free some memory. > > Signed-off-by: paul luse <paul.e.luse@intel.com> Hi Paul, Is this different from below patch, which seems already acked: https://patches.dpdk.org/patch/45079/ > --- > drivers/bus/vdev/vdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c > index 69dee89a8..2566d6c0d 100644 > --- a/drivers/bus/vdev/vdev.c > +++ b/drivers/bus/vdev/vdev.c > @@ -423,6 +423,7 @@ vdev_scan(void) > mp_rep = &mp_reply.msgs[0]; > resp = (struct vdev_param *)mp_rep->param; > VDEV_LOG(INFO, "Received %d vdevs", resp->num); > + free(mp_reply.msgs); > } else > VDEV_LOG(ERR, "Failed to request vdev from primary"); > >