From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5F01A00BE; Fri, 11 Feb 2022 11:38:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B8FA841144; Fri, 11 Feb 2022 11:38:40 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id AAA6840150 for <dev@dpdk.org>; Fri, 11 Feb 2022 11:38:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644575918; x=1676111918; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=vFiL4c1baC0JTOke2nRxUSGZ6AqFV7M32Nnxwtmw22k=; b=CKN8UA82kEpSAS5NSb/jQpUtZg0jOIrcIeUIr2YJfQy4bznXjalef5GD oCFomcyiusTRXElDl4rEIuAD0EeRos8+1o17zGjttT4cT98TK8pIZsk00 cvgsPaZMsPVuabvdbs8gg2WOkzRdH66sFsIzbi7DcrPLVWG2+NkunetMH lJlAI0id9yeRUO/5jF19DiC3g6u59HS0SrbzB2KGwMR8cFnhRrBTXOh8Y mt4rTn88OEtq3k9LtL1F9+ADbJZYoCUZiqB60c4okfxmjZDE0LOXAu4kQ b+DWLqtl720HuZjCxpDCKGSd86M/S4hDFwggaueJDY0EvfDYxoDCOo0IC w==; X-IronPort-AV: E=McAfee;i="6200,9189,10254"; a="249917980" X-IronPort-AV: E=Sophos;i="5.88,360,1635231600"; d="scan'208";a="249917980" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2022 02:38:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,360,1635231600"; d="scan'208";a="569004306" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga001.jf.intel.com with ESMTP; 11 Feb 2022 02:38:37 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 11 Feb 2022 02:38:36 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 11 Feb 2022 02:38:36 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 11 Feb 2022 02:38:36 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 11 Feb 2022 02:38:36 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LyXXwwotwClqItG52BcoFctttR1re63XxEu2cNfp+8GlYy5eTdYXwaUnW4PmuNfxlE1QuuEfE7q+l9jR6TSCEJXbLCC9O9XJa0qh7BVhqxQdrqsiTcZ/HsvhDLPZOKgLPhhISokVcs8T/lcvYb+NCAXKZg6vx4DypzJiW4zWuNRUEyhynypaNECSE5E0POBdO/p7kp8ikZYlnXUET+VSbtHnhqVZAfSQ6glk0TOpULIdd04PkDc+/i97HSdSx2ItkdcrjHvedt/NDWHTFSZ1nhgzaBiXeglyzuZmPDq6IAoZfIPcNRak1E4Vdhp8eN4vNryr9oysVzXqSkfgGowj4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y3aGinkbXIh6jG1ib8Ty6/y2rrRZzOB+Psv90II4nPE=; b=RL0/DfB4ZVMjmVX8G1lAMIPZO2Sl1WH/OEbWssk220bOAh6sG6DpMZzoaLKFPaO4USl34n/Dli2omvoOpkZQIgdg5QQQWaZDrQQmTam8EG9aH0tMHff1U4ldI6qXQVigOHdCV/NXIV3HJNGzbsLDtNTQA8Un4yOMNLWBGc+GIPy1CcHAn/B1pPoexqN02LC+elT+2DGwsYqPSSIUmewokpAN8RHAD70oIkFSoD2uCKmPHrMSCnUckKX9SyroWAySJSX5Tm2+gjUUoPYtebtgt1/at8UgLAOLzHCWBJV/9CPV1Kx6pAhpbl8TblfVPzC9RG1KmSuK8cRwPcuDn1yWUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by CH0PR11MB5300.namprd11.prod.outlook.com (2603:10b6:610:bf::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Fri, 11 Feb 2022 10:38:27 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.011; Fri, 11 Feb 2022 10:38:27 +0000 Message-ID: <776078cb-cab3-835f-5b5c-6b1026fc0c5e@intel.com> Date: Fri, 11 Feb 2022 10:38:22 +0000 Subject: Re: [v2 0/4] Add support for GRE optional fields matching Content-Language: en-US To: "Sean Zhang (Networking SW)" <xiazhang@nvidia.com>, "NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net> CC: "dev@dpdk.org" <dev@dpdk.org>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Ori Kam <orika@nvidia.com>, Qi Zhang <qi.z.zhang@intel.com> References: <20220126084404.40178-1-xiazhang@nvidia.com> <20220211014530.77711-1-xiazhang@nvidia.com> <ce47c463-05f0-75b8-2479-51501af4b346@intel.com> <DM8PR12MB53986ADEAB96906B701F99FFA2309@DM8PR12MB5398.namprd12.prod.outlook.com> From: Ferruh Yigit <ferruh.yigit@intel.com> X-User: ferruhy In-Reply-To: <DM8PR12MB53986ADEAB96906B701F99FFA2309@DM8PR12MB5398.namprd12.prod.outlook.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0155.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::16) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ef7c1f9b-f1e1-436f-67a1-08d9ed4aa30d X-MS-TrafficTypeDiagnostic: CH0PR11MB5300:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: <CH0PR11MB5300273B3DB609A6C73E2B1495309@CH0PR11MB5300.namprd11.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: axdZ2M0WJQmVXPdX8MdULvqlcUxqBFb2Up9n82y8xm7LbUSGH4/v05OONTGwQIcaUeTSyzNTAuWY8p2/gYDbE7TbwRJ2WEajfZyplMPyfuARF8A0hunCahYdEGCFZSCtwx7cuuDCwgSvBHgqWnkqYywsOMu6Aq4iqTEs3lcJGbzVWLadmSYOgeTPvtEja3U4badZ8TM9Cxjo3uR0kwbIw2E9C0F12/+VL5rctQwNgFgks+jXl+EFZawyDrVw/LOjmnVJAoY2XsEp5K0W+IEu19I+ML2rhVFFsa1LveOVUw5otkuEg0/I9eQwfHgn9dPlKD5c1QZVJfro2gsPHqR4ybk2cuBwLZ+ZtsqwTxRWoDHTLIGC2o+pCvtfOCRvAW8pe3Afrz1F6OU0ZhKuRs6C0nn0UkaamaRYqCfRft+OGnhXb5pACpNffTDubIoccZyD9TOPKL+P9lgudwVsL3wB5KX/kJJFzuGZEA0rktFcLrZE3ENSsWsOL+Rl5BjbrjCmQOEjNqFQThvxhRCmy6BEZsYfKtW+Yd1J9LsOWjC94tfw0GcWJJbPFMgpKJfId3RsKmsKIoxUDjVjU10oE5qqZZa8WsFwk5AydHvsfigAAYAsfz5Vb+HR51aILbt+TBFLBaeGbpjBYMnwFdu4apgd4WM3I1FrFC1fvyd4mfzsbSxW14XjuG8HM7ocqRmiiqJhyufCKeeXsSijT3TbuImY6Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(31686004)(316002)(186003)(26005)(54906003)(110136005)(2616005)(66556008)(66946007)(66476007)(4326008)(8936002)(8676002)(107886003)(82960400001)(6486002)(6666004)(31696002)(508600001)(55236004)(86362001)(2906002)(6512007)(6506007)(5660300002)(38100700002)(83380400001)(36756003)(53546011)(44832011)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eHdUTVY0ZXJiS3Z5UzNmOEx1WHF0K2hCMUVxQU4xRjcvU0lDdlgwL0ZTZlRO?= =?utf-8?B?b0NaZ1B3WWlZSjBMek51bnZtcXFxV2V2eDM5MUVlUWo2YzdLaGlxLzgyZVB6?= =?utf-8?B?QU5lSjY5OW1BeGRyWmRmYnZUU053RExKQWdmRnY1cktpaU80Zmh5MHlaZnNE?= =?utf-8?B?bGFKdndQYzhDYk03K3YxVnFVK1JPbzV4VmZUMi9iQ3haM2l5WVhqN2txM3VS?= =?utf-8?B?U0VBNkduaTd4V2hPc0s4VFlkcGZ3OThWWWQzR3hRSGtUY05GemZpZ2hiRXdC?= =?utf-8?B?NkMzU1ZsanN0dldrYy90VlhMbzlaVzdtdVhLRGxYcEYycGhpMzhFSXp1Vk5H?= =?utf-8?B?aFIyZXRrZUJOY3FoMUR0aFNmcTZaeFN0b2xEK1F0cmRicUdOZXprNGQ1TEhS?= =?utf-8?B?dFNZclV5K2tFWFBLRDQzNlkxWGlzcUZIczhzWFAvTjlkZ1dBQnlpWEs1RFFy?= =?utf-8?B?ZVlJaDFMUVNKTnlOZzZuUnpQbTE5MmpiNHhmeTBYaHJLdHg2WlJSZlZQYVVB?= =?utf-8?B?WHIrNzlBQUo4YXQ4MlFla1NKNEFTTnVqWFk5Q2kwNnRZY3Z0Y2JWVlNqdmQ4?= =?utf-8?B?VnVkbngyVE4rdTBpMlZWOTRuVjNRVU5Tam83ekRWQXAzQm1lR2RWdUM4UHkr?= =?utf-8?B?cnJ4ckJqZ09lSUZCUTMyU25NcFZySHMrdDBoY0VTdEw5b1UxbHdxUnZVT2E4?= =?utf-8?B?ZGZwU1h4ckZkQktRWTNuMVh0Z252NmQrL3J3MHNYbUNaelhQcVBSVTUyU0Vo?= =?utf-8?B?OUp5NFpFR3dQMjBPeDBTcVJRbk8zanZrN3RrVklPczNtR1JwU3JLMkNZVjdQ?= =?utf-8?B?cC9ucW9nQTJHQkMyVTEzMGpQNjBPZnNkN1NyYXhlVFlJc21rU1J4N096SW1q?= =?utf-8?B?WGMxbzZoMkF2c1I2Um9HamlqNTNjem5HdGd1c2ZmZVQ0UnpDK2VYWTU1SzFL?= =?utf-8?B?ZDNDaUhGcHV4cHFsWFVyQWxyOFFadldDbDdocm0ybmN4Y3lvWm1HNjlRY1NE?= =?utf-8?B?WkxaTVI4azlKRWhaR2dtajJpTE15Qy80VlpsR0pTbk1FTW9XRnpnd044Nzdn?= =?utf-8?B?V1NtZStEVVFoM1RGMmlOVExTVjdiUjYvYjRsWEFsT2NqcG80M2V6YVJaajly?= =?utf-8?B?ZDlGYWlWZWp2TlRsNzNGeGVlL1lVcHplRDZpTk13NW1LbzJ3V2g1N25HZkNS?= =?utf-8?B?VUZGRDBHODdWaEZ0RkNTaG5oa0dRaTVXdHpFeG93ZS9EZDZ0V1hHNjlCM1RD?= =?utf-8?B?dlpXb0hCL05oS3pVWEJoMlh3VkwyUVY5Vm1VUXRkZTRpQ2IzZ0U4dEVSb1VR?= =?utf-8?B?U09pSGhjWHBUOTFWTTB4V2NCUktjamo1VGlrb2Iybm1yRVRMQ1BYdVN2VkFp?= =?utf-8?B?MWJoL0YwSmNNQVlDTmFQejhLZDU5QVEvbDBYT2xQQUNDcGg0UTdwSnMwaC9M?= =?utf-8?B?aGVkRzc0ZkhrNUYxakd5ZUZaNUlEUzI4RVZ6cURob3NvZGt1WmpXSUVyd3Jq?= =?utf-8?B?Y3dRTklZcVp1UThubU9ndmd2YUsyVys2ekhQTk9jOWc1TW1VYXl0TFZpT29R?= =?utf-8?B?c052RzdQWUE5UERuSTIrZStwVTU4MUNlK0VaTnR5OFRhdE55NlJOSFB5UGc1?= =?utf-8?B?WXVNajNnUmNYMnJ1WXpzdnRRVlZIK2x1ODlHbFBtTlAyRWNxYmNDbm96bGRF?= =?utf-8?B?ekpWNk5TWkovVmtwcDYwZFlGdnBjbHJlVmdhbU1aREZmWCsydDdCeGY3Z3Zq?= =?utf-8?B?MG4vMFhObkJPSFQycFJtSVlYYldPQk5oUEd5N3NDNW5OT2p2TDhwVExtb2x4?= =?utf-8?B?U3ZmY1pnaHVHS3NxS1VtWWQwZGNDVFNsNWhEdVZGNkNPNFhGSVA2emZmeFBL?= =?utf-8?B?MXlwdUM5NGU4bFJ4UWdKMTFjTm1ZSGxFMm1aMXhKeHZOL05BOFF5VzdzOUJE?= =?utf-8?B?aEpzZkpEQS9vNVFNZllQM1l0Z3lmRDdvOGx6LzZMUFpHSC9odVREZWF1VmNi?= =?utf-8?B?Mk9lUTJFclRjQ04vSU9YSFl0R1ZsS3ZyZFkybWt2Y2w5Wm55VUF4eTFOVlJR?= =?utf-8?B?TS81UVhxeGV0ai9KL1M0RnZmVjhNMTExd3V0bUttV2sveVoySjNwZGhYYzAy?= =?utf-8?B?cXoyTm94KytuTFkrT28vMGVYRjJ5RkNYSktKQVQzeUg4Uk82NWJDaUt4czBx?= =?utf-8?Q?ojXk7x3gCwvVBpnvmiQXjps=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: ef7c1f9b-f1e1-436f-67a1-08d9ed4aa30d X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 10:38:27.0906 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7Z/GnVDIbcj+58AubLICMKsBmeSLfS3+3SCBQJCqXzcgoDkTCNOHxGz3g2BwExpKZAPGxmAondg/V8EFUeDhPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5300 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 2/11/2022 10:33 AM, Sean Zhang (Networking SW) wrote: > > >> -----Original Message----- >> From: Ferruh Yigit <ferruh.yigit@intel.com> >> Sent: Friday, February 11, 2022 5:37 PM >> To: Sean Zhang (Networking SW) <xiazhang@nvidia.com>; NBU-Contact- >> Thomas Monjalon (EXTERNAL) <thomas@monjalon.net> >> Cc: dev@dpdk.org; Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>; >> Ori Kam <orika@nvidia.com>; Qi Zhang <qi.z.zhang@intel.com> >> Subject: Re: [v2 0/4] Add support for GRE optional fields matching >> >> External email: Use caution opening links or attachments >> >> >> On 2/11/2022 1:45 AM, Sean Zhang wrote: >>> This patch set adds support for matching optional fields of GRE header. >>> The optional fields are checksum, key and sequence number. Currently, >>> key field is supported with pattern gre_key item '.. / gre / gre_key >>> value is xx / ..' with field gre_key in misc, but misc does not >>> support matching of checksum and sequence number of GRE. >>> To support matching of checksum and sequence number fields in GRE, >>> rdma-core needs the capbility of misc5 and support tunnel_header 0-3. >>> Since >>> tunnel_header1 is used to match checksum, tunnel_header2 for key and >> >> Hi Sean, >> >> The GRE optional fields support in flow API should be generic for any vendor, >> above description concerns me flow API implementation is done with to >> match a specific vendor implementation. >> >> Will it work to get ethdev part as previous version of this patch (v1), and get >> the mlx driver patch when rdma-core is ready? > > Hi Ferruh, > > Sorry about the confuse of the cover letter, and both flow API patches of v1 and v2 are common, not for specific vendor. > OK, thanks for clarification, we don't want any PMD specific implementation. > Thanks, > Sean >> >>> tunnel_header3 for sequence by hardware. If checksum and sequence >>> number not present in the pattern, use misc as before for the matching. >>> Application can still use gre_key item 'gre_key value is xx' for key >>> matching, the effect is the same if use 'gre_option key is xx'. >>> If using gre_option item, the flags in gre item should be >>> correspondingly set. For example, if using gre_option to match >>> checksum, the c_bit should be set '1' (.. / gre c_bit is 1 / gre_option >> checksum is xx / ..). >>> >>> change in v2: >>> -changed the struct defined in rte_flow for gre_option item. >>> -fixed raw encap issue. >>> >>> Sean Zhang (4): >>> lib: add optional fields in GRE header >>> ethdev: support GRE optional fields >>> app/testpmd: add gre_option item command >>> net/mlx5: support matching optional fields of GRE >>> >>> app/test-pmd/cmdline_flow.c | 72 +++++++++++++++ >>> doc/guides/nics/mlx5.rst | 8 ++ >>> doc/guides/prog_guide/rte_flow.rst | 17 ++++ >>> doc/guides/rel_notes/release_22_03.rst | 5 ++ >>> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 6 ++ >>> drivers/common/mlx5/mlx5_devx_cmds.c | 3 + >>> drivers/net/mlx5/linux/mlx5_os.c | 2 + >>> drivers/net/mlx5/mlx5.h | 1 + >>> drivers/net/mlx5/mlx5_flow.c | 108 +++++++++++++++++++++++ >>> drivers/net/mlx5/mlx5_flow.h | 6 ++ >>> drivers/net/mlx5/mlx5_flow_dv.c | 130 >> ++++++++++++++++++++++++++++ >>> lib/ethdev/rte_flow.c | 1 + >>> lib/ethdev/rte_flow.h | 19 ++++ >>> lib/net/rte_gre.h | 22 +++++ >>> 14 files changed, 400 insertions(+) >>> >