From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0573A0564; Fri, 28 Feb 2020 13:56:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 351261BFCE; Fri, 28 Feb 2020 13:56:41 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 00CA21BFCC; Fri, 28 Feb 2020 13:56:39 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 8F87221FBF; Fri, 28 Feb 2020 07:56:39 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Fri, 28 Feb 2020 07:56:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=ZdZllfFmtyGkEkKMtE7q56nE/mIAriAREfqJE3+Fdh8=; b=oEyFQzoIzEUq Izbj8/WsnOFWGixJmEmaLgWAtPy82IYUH9eyczMZTVzPdAfIEv3f6MdcLuFDytSF 7N0AEPQWIXhw5mk740+nUGvocPRomiEmkfNAWJC8f2i3iRwGBFBCnwHye5ZF5Hye vysi9uEnNi29Vl7IX8XTcQTsiZWI824= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ZdZllfFmtyGkEkKMtE7q56nE/mIAriAREfqJE3+Fd h8=; b=iCbxhalBJatrsC8PVtjgCwbyX0wnq/kQj+hYDXZX09ju4WCwyq53P2XjU VxaW0yDb7VADziWPGF0E09zoVcAFIZEAop2SWaqN86d+nTid9wfTCilsTCFzy3eI UrtFOsNGit84IeK3NPfEaJ6I4HHvCOk1u4b6xVMNdNzaAtWV4ttxzmQHin7UX9GY bX97BcSYbBrKHh7wfEMx2MJA/Lp4DndLtJEerp0n2L2u6Zz4iXOj9OOk20xdwVAx Br/qSVA+ywIMJiXHobbdstMmauXR6P4iLGLnSvz0MK0o93ZLFveLdJSHXRengYtk hWSPtnSDJ1gxihyEUcPIBLZ7IcZIA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrleekgdeghecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepughpughkrdhorhhgpdhgnhhurdhorhhgnecukfhppeelfedriedrudegledr uddugeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114]) by mail.messagingengine.com (Postfix) with ESMTPA id C617930611F2; Fri, 28 Feb 2020 07:56:37 -0500 (EST) From: Thomas Monjalon To: Akhil Goyal Cc: "dev@dpdk.org" , "roy.fan.zhang@intel.com" , "pablo.de.lara.guarch@intel.com" , "bruce.richardson@intel.com" , "stable@dpdk.org" , Declan Doherty , Luca Boccassi Date: Fri, 28 Feb 2020 13:56:36 +0100 Message-ID: <7762076.NyiUUSuA9g@xps> In-Reply-To: <5479929.MhkbZ0Pkbq@xps> References: <20200227223326.507857-1-thomas@monjalon.net> <5479929.MhkbZ0Pkbq@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] drivers/crypto: fix build with make X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/02/2020 13:41, Thomas Monjalon: > 28/02/2020 13:24, Akhil Goyal: > > Hi Thomas, > > > > > > > > In the check for the version of intel-ipsec-mb library, > > > there is a backslash in front of the #include. > > > It is not clear why this backslash is for. > > > It is not clear why there was no error so far. > > > > > > In an up-to-date ArchLinux, these errors were seen: > > > > > > syntax error near unexpected token `|' > > > `grep -e "IMB_VERSION_STR" \#include | cut -d'"' -f2' > > > syntax error near unexpected token `|' > > > `grep -e "IMB_VERSION_NUM" \#include | cut -d' ' -f3' > > > > > > The makefiles are fixed by removing the backslash. > > > > > > Fixes: 3067c8ce77ac ("crypto/aesni_mb: fix build with custom dependency path") > > > Fixes: 457b8e372975 ("crypto/aesni_gcm: check dependency version with make") > > > Fixes: bf6eb2c22fd1 ("crypto/kasumi: use IPsec library") > > > Fixes: 7c87e2d7b359 ("crypto/snow3g: use IPsec library") > > > Fixes: 61f7c988e39e ("crypto/zuc: use IPsec library") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Thomas Monjalon > > > --- > > > > I see that CI is still failing after removing that backslash. > > Yes my patch is failing on Intel CI: > http://mails.dpdk.org/archives/test-report/2020-February/118888.html > > I caught this issue on my machine. > > > I believe the issue is not because of backslash. It is something else. > > It works on my machine. > > We need to find a solution which works on both environment. > Maybe the cause is using make 4.3 on my machine. I confirm the issue: " * WARNING: Backward-incompatibility! Number signs (#) appearing inside a macro reference or function invocation no longer introduce comments and should not be escaped with backslashes: thus a call such as: foo := $(shell echo '#') is legal. Previously the number sign needed to be escaped, for example: foo := $(shell echo '\#') Now this latter will resolve to "\#". If you want to write makefiles portable to both versions, assign the number sign to a variable: H := \# foo := $(shell echo '$H') This was claimed to be fixed in 3.81, but wasn't, for some reason. To detect this change search for 'nocomment' in the .FEATURES variable. " https://lists.gnu.org/archive/html/info-gnu/2020-01/msg00004.html I will send a v2 patch