From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 5BB5C2BC6 for ; Fri, 18 Nov 2016 14:38:18 +0100 (CET) Received: by mail-wm0-f41.google.com with SMTP id f82so38330073wmf.1 for ; Fri, 18 Nov 2016 05:38:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=RANy5dYPJj25aZd5jRXozy3jRNiK+wNuc0AHbOtrNQE=; b=QkP9VAYGwG+6fY8/aRBqJhsV4OO5beyQkLrQmyg6tVWcjySrDF01H0+svJ8OjFGnxT Hor6zbJs33FMhKrmRpTa7Onm7XcilGysgY666K7OVv8q/GZddkanEY53GdOz7HZCB+/g iBtBGprxaQcLGkGwVo4pQ3sYk56Kd/pgxIvda20dnipWwnSVprvSwKUGqyZWdpT2Ez6D XCnZaiFB+9gAQgn3qKAadwvyHqP6UrlK882h1D2PV8iqiYefrHElcQxjGoIF3Pl9et6p Aw1wWxTYpIzwH/BKljCa9KqcelqgHyyKgSlunqJUwWnvQdkff11KGlHXcHBhx/sFb78b Cz8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=RANy5dYPJj25aZd5jRXozy3jRNiK+wNuc0AHbOtrNQE=; b=TApmMIXzo1g8zLBUT30vfrSRadCF9OInvKRpRiIdiz7MkqBhet4ROvQHCUPKBjKwA+ +2HZFVojSgkliSYJUj43Z9b0XmO7948waqr7PaDNsb9WbQdb5d4t87tROIdkHtWaJLhB bImmZRVHi4BlL7iK+qx9Z7Au+g9nt2i5FY8uxKRBiO0RMXiShewz/vQMgii+HSSM0B24 VSq5Daywp4HusVKOV4GyKp8w+cFBsiZpQjksjnIXA6DkxcGDg/Zm/eMX7llTxVBrXGPc 3ESWIa4RUmUTTWD05ofl9jfCGZF311oE0XVH7KwoooUhrIp3ns1Zur1v3iL40ltTtlGv SvbQ== X-Gm-Message-State: ABUngvfd++HZmarogV6FLwCD33HeID2Yj+qcFUpUCj4T+g4gl7nd4tY0Ko43TybTS6wO//Nk X-Received: by 10.28.232.213 with SMTP id f82mr24453264wmi.85.1479476298165; Fri, 18 Nov 2016 05:38:18 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id w66sm3456959wme.4.2016.11.18.05.38.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Nov 2016 05:38:17 -0800 (PST) From: Thomas Monjalon To: Hemant Agrawal Cc: dev@dpdk.org Date: Fri, 18 Nov 2016 14:38:16 +0100 Message-ID: <7765421.y4BZ5iUgMg@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] Clarification for - SoC specific driver based common sub component placing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2016 13:38:19 -0000 2016-11-18 12:44, Hemant Agrawal: > We like to introduce NXP's DPAA (Data Path Acceleration Architecture Gen2) Poll mode drivers into the DPDK. > > We need some clarification w.r.t the right placing of some dependent components, which can be common across drivers. E.g. We have hardware queue and buffer manager driver. This will be used by both network driver and crypto driver. But it is specific to NXP platform only. > > What is the right place for such common hardware specific components in DPDK? > 1. Add a new generic Soc library structure. e.g. librte_soc/nxp/. For each soc configuration only the required components will be compiled-in. > 2. Create a drivers/soc/nxp/dpaa2 structure to keep common driver libs. And link the network and crypto drivers to it. > 3. Add it to main network driver and make the crypto driver dependent on it. Your question is more generic than SoC context. You just want to share some code between drivers, right? What about building a library located in drivers/common/nxp/ ?