From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5BDBA0A02; Tue, 23 Mar 2021 16:10:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 56097140F2B; Tue, 23 Mar 2021 16:10:27 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 2D30E4069E for ; Tue, 23 Mar 2021 16:10:25 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 85C915C011A; Tue, 23 Mar 2021 11:10:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 23 Mar 2021 11:10:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= H44jBea4CAXriMsF3p4d21e1AigdrZl+XWdTDGbCq0Q=; b=3kSwmUT/xQxxIXvb gRAwjWjItQwPrhc5XcNfBWX46GZO1Jfjbhmw9F+32+0L7XcfwAOB17e1axKxYg8g liMM17dhMLA/fSzVMcfY3w0WyegApdbb6RSxsAU3Aphm4PZZXlikqtyhoJyQmlDB ZOBpud1VTwNDyXB33tAcUrWx0vPPsFuK96p1e5VE1dEX+Y+jLpw0eBR75J74a3CF xnE7f+0sRAFWNciQ4RTZaYGaRz1gYIJuIckt+INFxsogtOueXbbgM2PV9B51c4+5 TgWWKDEI2U/SSuQDAA2Qat2dblacAhouwVnwHmvzvN52E6m2k1JOizgRvOozcGEk F3VRrQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=H44jBea4CAXriMsF3p4d21e1AigdrZl+XWdTDGbCq 0Q=; b=UJxMJyNvn34et2Y0+EiPvkDajl+Bd3jf4yl4iGo+FWFmYQ8VsB5GDSw/9 weoEBA0abhNN/kempfiLbC/bzg559eHtPgySjzeSqZYHfSCmaFFFHtiR8xNP3ZOs GAaP4m7nzDufdAYNhxqxcrjFuKqE+IzFc0QsweLu7YyrDJpdevMmDzlAv3RApNer Vn0FERgsu93fiIQAlp46XEPlvm7WnzG5veIUtfV2TmVgWUqThl+J12BQrHnv6VkR A+gfUr4lWuWU0pJyGAnFMnl5XzhpxM7cGrT2yEyF5rg5NTpasThtnt/PiQXf/Fkc Pbe2GpigLU07Z2UdxnBnVAL5fjjNA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudegiedgjeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 47C27240425; Tue, 23 Mar 2021 11:10:21 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev , Bruce Richardson , Andrew Rybchenko , Ray Kinsella Date: Tue, 23 Mar 2021 16:10:19 +0100 Message-ID: <7775971.yr5XXRrMVS@thomas> In-Reply-To: References: <20210309233116.1934666-1-thomas@monjalon.net> <20210321223116.1340974-8-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 07/11] eal: add log level help X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/03/2021 14:37, David Marchand: > On Sun, Mar 21, 2021 at 11:32 PM Thomas Monjalon wrote: > > > > The option --log-level was not completely described in the usage text, > > and it was difficult to guess the names of the log types and levels. > > > > A new value "help" is accepted after --log-level to give more details > > about the syntax and listing the log types and levels. > > > > The array "levels" used for level name parsing is replaced with > > a (modified) existing function which was used in rte_log_dump(). > > If we forget about the slightly different formatting, why not simply > reuse rte_log_dump? > It has the advantage of listing the default level for each logtype > that a user cannot guess otherwise. I considered rte_log_dump() too much verbose for the help text. It is printing the global level and the logtype ids. The need for the end-user in the help is different of a debug dump.