From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA4D9A0524; Fri, 14 May 2021 12:51:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37F9340042; Fri, 14 May 2021 12:51:52 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id E31C940041 for ; Fri, 14 May 2021 12:51:50 +0200 (CEST) IronPort-SDR: fYdIQxLnILkgUTp1w0+WnvYJIeeyUqjrAcntI3rgv/irpTdGZ8Kw/ogXGjNCeWPUljxfx04Y10 OglpAQFx8GbA== X-IronPort-AV: E=McAfee;i="6200,9189,9983"; a="199845788" X-IronPort-AV: E=Sophos;i="5.82,299,1613462400"; d="scan'208";a="199845788" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2021 03:51:49 -0700 IronPort-SDR: /xHFlqPaaImOZdQM1ARwTDMTrSy0Ju7B1A4Kez2cXx/MGdBPMXgSKxaAqkB0Jqd8UCwg9brA76 tZWkHZjmszmw== X-IronPort-AV: E=Sophos;i="5.82,299,1613462400"; d="scan'208";a="457104712" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.241.112]) ([10.213.241.112]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2021 03:51:48 -0700 To: Thomas Monjalon , dev@dpdk.org Cc: andrew.rybchenko@oktetlabs.ru, Asaf Penso References: <1612458325-13508-1-git-send-email-asafp@nvidia.com> <20210407223320.2952469-1-thomas@monjalon.net> <20210407223320.2952469-4-thomas@monjalon.net> From: Ferruh Yigit X-User: ferruhy Message-ID: <778def48-a0db-8353-dd5c-1d254a778230@intel.com> Date: Fri, 14 May 2021 11:51:45 +0100 MIME-Version: 1.0 In-Reply-To: <20210407223320.2952469-4-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 3/3] devtools: check flow API doc tables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/7/2021 11:33 PM, Thomas Monjalon wrote: > The script check-doc-vs-code.sh may be used to add > some automatic checks of the doc. > > If run without any argument, a complete check is done. > The optional argument is a git history reference point > to check faster only what has changed since this commit. > > In this commit, the only check is for rte_flow tables, > achieved through the script parse-flow-support.sh. > If run without a .ini reference, it prints rte_flow tables. > Note: detected features are marked with the value Y, > while the real .ini file could have special values like I. > The script allow parsing exceptions (exclude or include), > like for bnxt code which lists unsupported items and actions. > Overall great to be able to generate and check document against code, also good to have this by relatively small/simple scripts, thanks for the work. This helps to remove the maintenance concerns I had. > Signed-off-by: Thomas Monjalon > --- > devtools/check-doc-vs-code.sh | 79 ++++++++++++++++++++++++++++++++++ > devtools/parse-flow-support.sh | 76 ++++++++++++++++++++++++++++++++ Will there be automated checks as part of the build system? Presumably in 'developer_mode'? btw, scripts points out some new features not documented in .ini files, those are the recently added ones, patch requires a rebase on top of latest code. > +rte_flow_support() # > +{ > + title="rte_flow $1s" > + pattern=$(echo "RTE_FLOW_$1_TYPE_" | awk '{print toupper($0)}') > + list "$title" "$pattern" | grep -vwE 'void|end' Should 'RTE_FLOW_ITEM_TYPE_ANY' also excluded, does it have benefit to have it as listed?