From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jianfeng Tan <jianfeng.tan@intel.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
dev@dpdk.org, john.mcnamara@intel.com,
yuanhan.liu@linux.intel.com, stephen@networkplumber.org
Subject: Re: [dpdk-dev] [PATCH v2 3/3] doc: postpone ABI changes in igb_uio
Date: Fri, 10 Feb 2017 11:44:11 +0100 [thread overview]
Message-ID: <7792524.kWq49NKEN6@xps13> (raw)
In-Reply-To: <21c3f97a-c13b-2d5b-84cd-4d84a2d23717@intel.com>
2017-02-09 17:40, Ferruh Yigit:
> On 2/9/2017 4:06 PM, Jianfeng Tan wrote:
> > This ABI changes to remove iomem and ioport mapping in igb_uio. The
> > purpose of this changes was to fix a bug: when DPDK app crashes,
> > those devices by igb_uio are not stopped either DPDK PMD driver or
> > igb_uio driver.
> >
> > Then it has been pointed out by Stephen Hemminger that it has
> > backward compatibility issue: cannot run old version DPDK on
> > modified igb_uio.
> >
> > However, we still have not figure out a new way to fix this bug
> > without this change. Let's postpone this deprecation announcement
> > in case this change cannot be avoided.
> >
> > Fixes: 3bac1dbc1ed ("doc: announce iomem and ioport removal from igb_uio")
> >
> > Suggested-by: Stephen Hemminger <stephen@networkplumber.org>
> > Suggested-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > Suggested-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
The images are not real vector images and are almost unreadable.
Please make the effort to use inkscape in order to have images
we can update.
I did some changes: s/virtio_user/virtio-user/ in order to be consistent.
Like for vhost-user, we use the underscore only in code.
next prev parent reply other threads:[~2017-02-10 10:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 7:34 [dpdk-dev] [PATCH 0/3] doc upates Jianfeng Tan
2017-01-24 7:34 ` [dpdk-dev] [PATCH 1/3] doc: add guide to use virtio_user for container networking Jianfeng Tan
2017-01-24 7:34 ` [dpdk-dev] [PATCH 2/3] doc: add guide to use virtio_user as exceptional path Jianfeng Tan
2017-01-24 7:34 ` [dpdk-dev] [PATCH 3/3] doc: remove ABI changes in igb_uio Jianfeng Tan
2017-01-24 13:35 ` Ferruh Yigit
2017-01-30 17:52 ` Thomas Monjalon
2017-02-01 7:24 ` Tan, Jianfeng
2017-02-09 14:45 ` [dpdk-dev] [PATCH 0/3] doc upates Thomas Monjalon
2017-02-09 16:06 ` [dpdk-dev] [PATCH v2 " Jianfeng Tan
2017-02-09 16:06 ` [dpdk-dev] [PATCH v2 1/3] doc: add guide to use virtio_user for container networking Jianfeng Tan
2017-02-09 16:06 ` [dpdk-dev] [PATCH v2 2/3] doc: add guide to use virtio_user as exceptional path Jianfeng Tan
2017-02-09 16:06 ` [dpdk-dev] [PATCH v2 3/3] doc: postpone ABI changes in igb_uio Jianfeng Tan
2017-02-09 17:40 ` Ferruh Yigit
2017-02-10 10:44 ` Thomas Monjalon [this message]
2017-02-10 11:20 ` Tan, Jianfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7792524.kWq49NKEN6@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jianfeng.tan@intel.com \
--cc=john.mcnamara@intel.com \
--cc=stephen@networkplumber.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).