From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73E1D432D8; Wed, 8 Nov 2023 16:15:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EF5C240DDB; Wed, 8 Nov 2023 16:15:50 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 5B8F5402A7 for ; Wed, 8 Nov 2023 16:15:49 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id E0136320093E; Wed, 8 Nov 2023 10:15:45 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 08 Nov 2023 10:15:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1699456545; x=1699542945; bh=fPZVb1c+t7UJX6L3vCfWN/1onECd4Ja9cs8 C1KtQF1g=; b=OJ3MirFj0OEjFBSwalbaABWnuTeC5sWaTU15sbEp/XggsI+alEX J1QB/Kt2ZNdHLYDJTRdiWhyihGVUIBJYDL5TsCafChrJ6c0UGaZdxBWimbtdqfoI 5vgnPBwbvX0txIUG97H/MvcgixFKOFoKfjXCPaUIbhi00Tqqb4JzAoNMZoz73RnQ vQFTc2Nb6b1vfmD08XbDxN2KXHCw4IOs8C9lohncGLe5S44luM3T8VS5MGJwrL24 BIaXRvhKc9tiBAh0I8sVFgoJ3VHM8YNiUq3c6Clq5wNJJ2E6pSWCtjZFwGw4K5eJ kt4Bth4OWFyF89C1CndItr186h8tWgoLrmA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1699456545; x=1699542945; bh=fPZVb1c+t7UJX6L3vCfWN/1onECd4Ja9cs8 C1KtQF1g=; b=foo+AvuRsArVdpwOAHMjOoDoBhLUNmVS1FAR4fWWg8Xiclpu3gZ YEf7D1JZZaQPWsRM1L1I+MsQVhrUeNRduAq0j0Wt3TPZBpkhBtKbLze2cCmbLGbi HU2rjxf/idU+oVWb86aKVEWJE2KJmBM6yjZ/3+JouMgWrqYxRL8LHkWR37dtVo0X ldok7XxI4nacG7DurnVkRsU7/UdB7stD7ctXJi+zndH2sCkmyP68r/rGcRGOlpZl RSPO/2DotQSV3Q/vGjPqhzg0kkMy3IPRwKbkaqQ0qkMdSiUycL4pw5KdpiyQ9cjp 6PA46yPaoOlVodGccfEOPm/5zI8VZrpS2aQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudduledgjedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 8 Nov 2023 10:15:43 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, anatoly.burakov@intel.com, David Hunt , Tyler Retzlaff Subject: Re: [PATCH] eal/x86: fix segfaults in waitpkg power intrinsics Date: Wed, 08 Nov 2023 16:15:41 +0100 Message-ID: <7797250.gsGJI6kyIV@thomas> In-Reply-To: <20231108031920.GA19492@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20231107161900.46058-1-bruce.richardson@intel.com> <20231108031920.GA19492@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 08/11/2023 04:19, Tyler Retzlaff: > On Tue, Nov 07, 2023 at 04:19:01PM +0000, Bruce Richardson wrote: > > From: David Hunt > > > > The code was recently enhanced to allow the use of the waitpkg > > intrinsics rather than the raw assembly in the rte_power functions. > > However, the parameters to the intrinsics, while compiling fine, were > > incorrect, and would segfault when run on the appropriate hardware. > > This patch fixes the intrinsic parameters. Tested on a system with > > tpause and umonitor/umwait instructions. > > > > Fixes: 60943c04f3bc ("eal/x86: use intrinsics for power management") > > > > Signed-off-by: David Hunt > > Reviewed-by: Bruce Richardson > > Reviewed-by: Tyler Retzlaff Applied, thanks.