From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 933CFA034F; Sun, 21 Feb 2021 16:54:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 15D0522A297; Sun, 21 Feb 2021 16:54:06 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 939BC22A293 for ; Sun, 21 Feb 2021 16:54:04 +0100 (CET) Received: from [192.168.1.192] (unknown [188.242.181.57]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id AFDE37F514; Sun, 21 Feb 2021 18:54:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru AFDE37F514 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1613922843; bh=1Ls2I02ObEA8uQAyoNjPmVj/sR/f1ElCHhTCmxaEICA=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=IUctoW18o98rVgqF1OzhUjyNjd8EysuRQ6a32aA5ZIxvz/Tvnv1VPNwjM2VN6/7gD WiFTa6+bOynSb38n+vJeN6wVGpgTfZXMeYrigh6XHQkpOCGqkqLQjpsBIwOI/2Ds2N ZcP/cFLpocuYtdcEpktiwUukHOMo40NdEKfyrzIU= To: Tal Shnaiderman , Dmitry Kozlyuk , "dev@dpdk.org" Cc: Tyler Retzlaff , Nick Connolly , Matan Azrad , Shahaf Shuler , Slava Ovsiienko , Beilei Xing , Jeff Guo References: <20210220232910.772-1-dmitry.kozliuk@gmail.com> <20210221012831.14643-1-dmitry.kozliuk@gmail.com> <20210221012831.14643-7-dmitry.kozliuk@gmail.com> From: Andrew Rybchenko Message-ID: <779ae112-eb54-b6c4-22c3-ca9f30274f19@oktetlabs.ru> Date: Sun, 21 Feb 2021 18:54:01 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 6/7] drivers: remove POSIX dependencies X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/21/21 11:59 AM, Tal Shnaiderman wrote: >> Subject: [dpdk-dev] [PATCH v2 6/7] drivers: remove POSIX dependencies >> >> External email: Use caution opening links or attachments >> >> >> Replace POSIX strncasecmp() with EAL rte_strncasecmp(). >> Replace POSIX strtok_r() with EAL rte_strtok(). >> Replace POSIX strdup() with EAL rte_strdup(). >> >> Signed-off-by: Dmitry Kozlyuk >> --- >> i40e: checkpatches.sh complains about long lines (it's ~85). >> I doubt that mechanical fix would keep the code readable. >> It's on 5th level of indentation, so I'd extract a function, >> but would like to hear from maintainers first. >> >> drivers/bus/pci/private.h | 2 +- >> drivers/bus/vdev/vdev.c | 4 +- >> drivers/bus/vdev/vdev_params.c | 3 +- >> drivers/common/mlx5/mlx5_common_pci.c | 4 +- > > bus_cmdline_options_handler in mlx5_common_pci.c has a call to strdup which needs to be renamed to rte_strdup > (Also failed CI: https://lab.dpdk.org/results/dashboard/patchsets/15674/ ) > Frankly speaking I don't understand why such changes are useful/needed. Patch description does not explain/prove it.