From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2842DA0547; Thu, 9 Sep 2021 10:58:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A8EF840041; Thu, 9 Sep 2021 10:58:13 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id A3EA44003E for ; Thu, 9 Sep 2021 10:58:12 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10101"; a="207839483" X-IronPort-AV: E=Sophos;i="5.85,279,1624345200"; d="scan'208";a="207839483" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2021 01:58:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,279,1624345200"; d="scan'208";a="431726529" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga003.jf.intel.com with ESMTP; 09 Sep 2021 01:58:11 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 9 Sep 2021 01:58:11 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 9 Sep 2021 01:58:10 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 9 Sep 2021 01:58:10 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 9 Sep 2021 01:58:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mh2QImwaXNkEILcsxAXjPfLSwSMZE7MyBI0kdambeEcT6jN+aziTZAWOJfkmthy9LsQRtGuW1k16kpi+T1tzpLcOn2/G/W6+qgDzN6zWWaecRKTRFKZsJcRV5F/ErqH78wQSs8etv6Asv6esa8b7SB8V2SCx0iozSd42ADCUUHkBDBTuPu96rjHeibjwIpPoxUvSYBr8W3S8EGYYkmlN3C6IYMpNQS2Ed8VPtVqVAfj43rcML+638IxdiDqV111CQAp2UASo6r5iBPR5vRUibL9qym06xvK2DjnaS/9xBq1c4rzXeh6fv9gkFKz05n/ueQLQMSPLLKvCTdfuzHmPmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Zwa3R4BpylZHkG416Uluz5aW/wIBfF7aRv473F2Z+jI=; b=oKcvd2vqq5H6hb1qgiNLbclfHLiHEHQ0d5+mQml6z2UArgKMZqHz3VHL4gje2ieZLzykrEWesgct+9O7VWZYaassTrCitWUoPCyGazrnN19pQMTEjl8oaGnFly1W9dRTNUkOqTy949Qluvqz1g6tGRQiDmjCaav7yEYneoWeYGBecggeuFtk/W9ymB83e7M52awIWo1hgJWoywhdSO1iXIbxJ9g0EAWdbXWc6Mk+FEdd+iJ+OoR6v4q8/XfCnMYBNTqK02eB7BbChNiAknp+651Nqwr6nhkXIWW/mu5QPgP0TdsTyYsmxEmiYLLDB9RlRE/2uV+pDe4ruB69d/rduA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zwa3R4BpylZHkG416Uluz5aW/wIBfF7aRv473F2Z+jI=; b=QBxLxVF8VhNSW3Cjl9bZe8b6swB9crSbzfyFhHyQUzh+UO8SH1zmjAeirmJb6iAkT2kQisRXEFi5DibXOiBbL7zsEonGz60v92HZUsiDnwUV4KY+iWp/YoBn+GEjN0CFHVsla46Meo5R/N0B1JtMmuGhPunS6bisqJqvmdpQgLM= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from CO1PR11MB4868.namprd11.prod.outlook.com (2603:10b6:303:90::19) by MWHPR11MB1342.namprd11.prod.outlook.com (2603:10b6:300:1e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.16; Thu, 9 Sep 2021 08:58:06 +0000 Received: from CO1PR11MB4868.namprd11.prod.outlook.com ([fe80::4dcc:489e:1d86:47cb]) by CO1PR11MB4868.namprd11.prod.outlook.com ([fe80::4dcc:489e:1d86:47cb%9]) with mapi id 15.20.4500.017; Thu, 9 Sep 2021 08:58:06 +0000 To: Akhil Goyal CC: "dev@dpdk.org" , "declan.doherty@intel.com" References: <20210903112257.303961-1-radu.nicolau@intel.com> <20210903112257.303961-2-radu.nicolau@intel.com> From: "Nicolau, Radu" Message-ID: <77aeb50a-adbe-5986-3c9e-17268bd46563@intel.com> Date: Thu, 9 Sep 2021 09:57:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: DB7PR03CA0075.eurprd03.prod.outlook.com (2603:10a6:10:72::16) To CO1PR11MB4868.namprd11.prod.outlook.com (2603:10b6:303:90::19) MIME-Version: 1.0 Received: from [192.168.1.12] (109.255.186.106) by DB7PR03CA0075.eurprd03.prod.outlook.com (2603:10a6:10:72::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Thu, 9 Sep 2021 08:58:05 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 54c2d7c4-f77e-4146-fd3a-08d9736ff04b X-MS-TrafficTypeDiagnostic: MWHPR11MB1342: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n88nd8OrEnsNV8FXR2WKUqt+7stW+KaY/ySoOuIFVUYbm66pbTmg0U8BH9n5TJceUXBbHLrS1wbopQ1yqDR7u5Ul7l1SgbBAqcJLxKspv3V9/BzI7ddh8Hk/Jf8/MTpjAnx9PbLLh50ST16VMkGbgLWXtvYWiz3kcH7WYowJlYSqdQDqq/tcN8iGJzdvX0tmIKYLHGDxlSN8s2wHnl6WPjAOKxkIgBTIuuXxDVj6PYWTW4FfEacu7k9vxlBEKJKUlHnCgxe2HDiklFlQGyES5LFPaqeaK7Ob4+/ruflYVoj8RHXE4zQq0WQxNaJlfqJnbKWBmFep9kMGwwipVSrxIUdBq9QwX81NYKLj1l8Guv+yzZl52iFb3NsTxVUdLjexUH6imWSfF8m9VRO1KEk2QEb2EUEv9Tm5v8xZm+/Ue8RRK3URH2FG3SUsbBdM7GbRWmkNYuQ7D7kNGDZtdPODQ1vl/3NdElRZKyAZt/Ps9Eb0zbVr5WKXHXERe3iOou6IIHrkSvXmN/YQlE7uYBPwSIe39qkn3a13ry3BZOwdFKGh6+AJ2GFr9JV/tyZJQfUs8JY9cx5JdhdGLry1tVVMD2uG3drSKv+6enXGKMVwOREPM+sfNdiNGSpziLyVqp7wJwWcEfG+xrxh1DebYFFKLC7IJhvYcwQyypqJ7eUC1I7IVsx3W1klS9d+nIIDohTy1wCsu6hg424H0NxWRjh31QjVZ4A7LFNQJn1uW743TGA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB4868.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(956004)(5660300002)(4744005)(2616005)(38100700002)(86362001)(107886003)(316002)(2906002)(16576012)(26005)(66556008)(31686004)(54906003)(186003)(6666004)(8936002)(31696002)(6916009)(508600001)(66476007)(8676002)(66946007)(53546011)(55236004)(4326008)(36756003)(6486002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0FsNVdlNnA5T1RZWGNmU01tYzQ4ZmZOdDZXWGtPRGx3Uk1oYk5KcWN1NThV?= =?utf-8?B?MSt2ZVplUU9WWE44aXJJR2dXeUNPN3ZCcksvYmtoajVFd1pqemlKS09SRzZa?= =?utf-8?B?OWVCeHVFVVl3KzIrbkpvdk9BdmVaR0lrVFVKT0N4VmFSbEo2SGdIVDgzVi9v?= =?utf-8?B?RW9uMTZ1Z2pReEM3TGxlRjRWb2lsUjZqOW1GUWxTMHlIZTdGc09pMDBYUHAw?= =?utf-8?B?Z05BU1YxTjgzUTVoZ3ZxaUIzR2ZZczFORGpVZTZxRjZVSlk4Sm5BMXg4Z0Nh?= =?utf-8?B?L2FkaE91OTdGajV4ZEhqc2VKNzRlcVphWDFxUEFUdW1HKzVTL2t0NzJBSmdB?= =?utf-8?B?K3ZmdDVobHJRMmR1akZTYmJjL0ZiQlBBU01tUk1HQVFudWh3L0pnOVYvdE05?= =?utf-8?B?ZnBXNjBMMUdtbU1DZmlFZ0twUlpyUURqSzlyUmNVZWJkNkdYdUZzbFN2RDJB?= =?utf-8?B?WGVobjQyU2sxT0gxUXJTN1lFUXVzL2orSit5ODR0bXlvUXUwOGZpTURDeldt?= =?utf-8?B?d1pxb3VlSDZ0YkNWSUJPRTU5c1U3RWRGM24xWmVDUzBrL21xWU9aSFNUZ3Vn?= =?utf-8?B?RlJZbkh4K3lMQlkyQURleS85Mm9rWUlMRVhacXUxQjlQNG5uK1Z0eUN6Rzh3?= =?utf-8?B?dHhYMW9aR0tGd1AzZ0kwQ0JmQjJiQ1BJZWM3YmxGWHJ0ME1PV0NhV0NEbkhC?= =?utf-8?B?dVdOVm15QzJFOS9CZlNYV1M5TmZBNGplMWw0Wll6ZjBRSjE3cnpEVXlRdEc4?= =?utf-8?B?elZWKzZJNUpnNGkzZDFwMjRJaGU3eUtsTnVqc2JJSGdEdE55N1VKTEp3L3Ro?= =?utf-8?B?YzhCM3dVNmRPdGN1c1NDQ29zTmxaRnZydzFBN1c5ZUhwNk5od1NKeS9EZDQ5?= =?utf-8?B?dnlWWDF3QkpTN2wzb3duc1ZDMWlYeVVudW1qQXBueXF5ejVDYnprUGE3RTJt?= =?utf-8?B?ZGlJUmRjYXcweFRabmdkM0dzQ0FpQTMwOFVaRlA1U3duMEFBT2Z3SzQ1QXR6?= =?utf-8?B?SUFvU1MrZE92TDhBdWxaMFJtR01idFo5ajc1RFkyMlRKY3RqT2c3cXhHR09q?= =?utf-8?B?Y1VIZkRzWVlzSVpjcXhubXFJZThJeVNwN0V2THV5RlkrS1duUEtSaElqM3lL?= =?utf-8?B?VTd5SC9GTEc2RDc5UVhjVVdrR3NJaEVBNUxSWFZvWjR4WWlYSDRXVWlveERs?= =?utf-8?B?aU9KN0k3bkVsSWNobzdCVERiM2Z2MlJIZWJTL3ZDUnhvZDdhNUZZNUpEeHMw?= =?utf-8?B?V1JJNGpLWHo5WUIvZlAxdmxHa0tzNmkrRy8yeElDOVNTdmcwVGoxSmF6TEpw?= =?utf-8?B?Y1VUdVVmM3RIYVM2cE5jcnVZUHlidDlxSTJWdGlQRU1xS2VQY24yd1VmaHhV?= =?utf-8?B?Qk9zcjFHVmN6QW5MVURjODNCMTFYQVpzMnNUWUdYdnFOaDlLeWVINnMvNEZV?= =?utf-8?B?cUEwYXNrUHRsWG5EWTNhS2o4bnV5Znhjamk0Y3BLZ3VrUnkrdDBpVmlvekJ4?= =?utf-8?B?aHcwUEcxVXl4eWNKb3A4eVZacEU4Y2E5ZWppbWhjNjRlQWhwbWl1NjYwczlw?= =?utf-8?B?NklMcjhhTHBjVW03aW10cVJWOTBtZkdXOElyRVp4Ukl1SnJoOGl1bjc1T2FI?= =?utf-8?B?OU1hSFBtSk9VczQ3dnZRQnNyUEdBeVVteHJlNWlldmtZSkNNSUhNdU44alpH?= =?utf-8?B?N0lZZTZmdkxyNnVrZG5zS2R6dmNZQ3ZNa2toTGtVYWtMNVpsWGxFaENGL1VT?= =?utf-8?Q?dsJWe/4m4BEyGOyOsHefy8qYcoxN/ovaEe4M59B?= X-MS-Exchange-CrossTenant-Network-Message-Id: 54c2d7c4-f77e-4146-fd3a-08d9736ff04b X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4868.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2021 08:58:06.2927 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iiwou2FO5GZ+BYFJICITkItazH6RxqSVaUjPA22qD7ONTcZAQpLvHQRRYcWZx26uUdeiiHcWUa1ICT7tG0tBJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1342 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [EXT] [PATCH 1/7] examples/ipsec-secgw: add ol_flags support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, On 9/8/2021 1:48 PM, Akhil Goyal wrote: >> Add support for ol_flags to the IPsec GW sample app. > Description is not appropriate. > ol_flags are supported to do what? > How the existing code was not good and > what benefit do we get from this patch? > Thanks for reviewing the series! I will address your feedback for all the patches in the v2.