From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 02D22A0547;
	Tue, 19 Oct 2021 19:45:51 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 7C8F040683;
	Tue, 19 Oct 2021 19:45:51 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id AF17B4003E
 for <dev@dpdk.org>; Tue, 19 Oct 2021 19:45:50 +0200 (CEST)
Received: from [192.168.1.192] (unknown [188.242.181.57])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 369FE7F59B;
 Tue, 19 Oct 2021 20:45:50 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 369FE7F59B
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1634665550;
 bh=IFJJePQiLQx5YA9R4jsUXo0C+Y2+KuYaoQOTuof7Z18=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=LqjrlMEaUX3wmQUqYzby9jt76skDxncOz9N4en0GzadNmnQc8Fyx1yPUt1hcXAv7v
 i7h0zGC/0RTssnyqvGJxq29jAzLvtfSQGZ2/mnsdAeLvfrtjdfhQNAO4aaLAr+st8m
 kT0GFYLpxJYIrhkE7HDZF9CCwxHKeZ3E6yvMedYI=
To: Olivier Matz <olivier.matz@6wind.com>
Cc: David Marchand <david.marchand@redhat.com>,
 Maryam Tahhan <maryam.tahhan@intel.com>,
 Reshma Pattan <reshma.pattan@intel.com>, Xiaoyun Li <xiaoyun.li@intel.com>,
 Pavan Nikhilesh <pbhagavatula@marvell.com>,
 Shijith Thotton <sthotton@marvell.com>, Jerin Jacob <jerinj@marvell.com>,
 "Artem V. Andreev" <artem.andreev@oktetlabs.ru>,
 Nithin Dabilpuram <ndabilpuram@marvell.com>,
 Kiran Kumar K <kirankumark@marvell.com>, Maciej Czekaj
 <mczekaj@marvell.com>, Maxime Coquelin <maxime.coquelin@redhat.com>,
 Chenbo Xia <chenbo.xia@intel.com>, dev@dpdk.org
References: <20211018144907.1145028-1-andrew.rybchenko@oktetlabs.ru>
 <20211019100845.1632332-1-andrew.rybchenko@oktetlabs.ru>
 <20211019100845.1632332-3-andrew.rybchenko@oktetlabs.ru>
 <YW7uwaJH0JQyntxW@platinum>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Message-ID: <77b2cf67-94a7-8795-5bcd-6eaee67b8453@oktetlabs.ru>
Date: Tue, 19 Oct 2021 20:45:49 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <YW7uwaJH0JQyntxW@platinum>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2 2/6] mempool: add namespace prefix to flags
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/19/21 7:13 PM, Olivier Matz wrote:
> On Tue, Oct 19, 2021 at 01:08:41PM +0300, Andrew Rybchenko wrote:
>> Fix the mempool flgas namespace by adding an RTE_ prefix to the name.
> 
> nit: flgas -> flags

Thanks, fixed.

> 
>> The old flags remain usable, to be deprecated in the future.
>>
>> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> 
> (...)
> 
>> @@ -777,12 +777,12 @@ rte_mempool_cache_free(struct rte_mempool_cache *cache)
>>   	rte_free(cache);
>>   }
>>   
>> -#define MEMPOOL_KNOWN_FLAGS (MEMPOOL_F_NO_SPREAD \
>> -	| MEMPOOL_F_NO_CACHE_ALIGN \
>> -	| MEMPOOL_F_SP_PUT \
>> -	| MEMPOOL_F_SC_GET \
>> -	| MEMPOOL_F_POOL_CREATED \
>> -	| MEMPOOL_F_NO_IOVA_CONTIG \
>> +#define MEMPOOL_KNOWN_FLAGS (RTE_MEMPOOL_F_NO_SPREAD \
>> +	| RTE_MEMPOOL_F_NO_CACHE_ALIGN \
>> +	| RTE_MEMPOOL_F_SP_PUT \
>> +	| RTE_MEMPOOL_F_SC_GET \
>> +	| RTE_MEMPOOL_F_POOL_CREATED \
>> +	| RTE_MEMPOOL_F_NO_IOVA_CONTIG \
>>   	)
> 
> I guess MEMPOOL_KNOWN_FLAGS was kept as is on purpose.
> 

Yes, since it is internal and located in .c file.