From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13F7AA0547; Thu, 28 Oct 2021 15:00:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F2C42411EE; Thu, 28 Oct 2021 15:00:41 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3754840DF4 for ; Thu, 28 Oct 2021 15:00:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635426040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FNZYcilQJbaTB+xHaQf2Klc8fMHCI1sxkBS+tfJQ+qw=; b=fPBrYB2Dov5QZGidbD/Nsgmc4Kalmexr6Du4O1YYNKf+VzL9qAwiVo3xp2XvZ4sm/WCjX9 tUlMT4I1hatwWHwmIJMVQJ8HDouTfRtM6J208fvi+K0jsXb1mfiqGTITgewfHrI99W6mXF lEsnaPoCMd4kHzsehFWSaRUpTiZL0Hc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-40-_sfgEyq7OxKckPsoZnTQ2A-1; Thu, 28 Oct 2021 09:00:39 -0400 X-MC-Unique: _sfgEyq7OxKckPsoZnTQ2A-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3C7221018723; Thu, 28 Oct 2021 13:00:38 +0000 (UTC) Received: from [10.39.208.32] (unknown [10.39.208.32]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 080CB6C8F7; Thu, 28 Oct 2021 13:00:23 +0000 (UTC) Message-ID: <77babc7e-bf81-0136-9251-869ea5f68485@redhat.com> Date: Thu, 28 Oct 2021 15:00:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 To: techboard@dpdk.org, David Marchand Cc: dev , "Xia, Chenbo" , "Xueming(Steven) Li" , Xiao Wang , Thomas Monjalon , Ray Kinsella References: <20211028120329.44710-1-maxime.coquelin@redhat.com> From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] vhost: mark vDPA driver API as internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/28/21 14:38, David Marchand wrote: > On Thu, Oct 28, 2021 at 2:03 PM Maxime Coquelin > wrote: >> >> This patch marks the vDPA driver APIs as internal and >> rename the corresponding header file. >> >> Signed-off-by: Maxime Coquelin >> --- >> drivers/vdpa/ifc/ifcvf_vdpa.c | 2 +- >> drivers/vdpa/mlx5/mlx5_vdpa.h | 2 +- >> lib/vhost/meson.build | 4 +++- >> lib/vhost/vdpa.c | 2 +- >> lib/vhost/{rte_vdpa_dev.h => vdpa_dev.h} | 6 ++++++ > > It is more explicit it is a driver-only header if we rename as > vdpa_driver.h or vdpa_pmd.h. Agree, I can take the opportunity to rename it to vdpa_driver.h. > [snip] > >> @@ -86,3 +82,12 @@ EXPERIMENTAL { >> rte_vhost_async_channel_unregister_thread_unsafe; >> rte_vhost_clear_queue_thread_unsafe; >> }; >> + >> +INTERNAL { >> + global; >> + >> + rte_vdpa_register_device; >> + rte_vdpa_unregister_device; >> + rte_vhost_host_notifier_ctrl; >> + rte_vdpa_relay_vring_used; >> +}; > > Alphabetical order, please. Will do. > Please also add a note in the release notes. > > Strictly speaking, this is an announced API change. > Cc: techboard. Correct, I think we need a vote from the techboard. @Techboard, this API change felt through the cracks. Please note that the drivers APIs that are being marked as internal were already moved in a dedicated header last year, so any application are likely not using these APIs. There is a patch for mlx5 vdpa that introduces a new entry to struct rte_vdpa_dev_ops, so I think it would be better to have these APIs marked as internal before mlx5 patch is applied. Thanks in advance, Maxime > > The rest lgtm. > Thanks. >