From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F0A9A0A0A; Wed, 20 Jan 2021 19:24:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5118D140E6C; Wed, 20 Jan 2021 19:24:56 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id BDD87140E6B for ; Wed, 20 Jan 2021 19:24:54 +0100 (CET) IronPort-SDR: OKQhsLDGJpKyW8CHA9VCspYH8rp1Ac65n/JoyYJD1xNhsF0znZkRycwQ2ndajycMYC59/Vm+E+ J5FaKfVyfHtA== X-IronPort-AV: E=McAfee;i="6000,8403,9870"; a="240696241" X-IronPort-AV: E=Sophos;i="5.79,361,1602572400"; d="scan'208";a="240696241" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2021 10:24:51 -0800 IronPort-SDR: +OyxzlL8I60P/F84o6Z1sEgEEVE5wgpVVkm4enhgY2ofJzsaF1Y/fJONOMKfVj6j69oSgqTG3r bvQ/KCjsgJjg== X-IronPort-AV: E=Sophos;i="5.79,361,1602572400"; d="scan'208";a="366395665" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.192.162]) ([10.213.192.162]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2021 10:24:48 -0800 To: Dmitry Kozlyuk , David Marchand Cc: dev@dpdk.org, navasile@linux.microsoft.com, dmitrym@microsoft.com, pallavi.kadam@intel.com, Beilei Xing , Jeff Guo , Wenzhuo Lu , Leyi Rong , Bruce Richardson References: <20210120164016.26745-1-david.marchand@redhat.com> <20210120212124.72fe1289@sovereign> From: Ferruh Yigit Message-ID: <77c3a7fb-a703-4b8d-62b5-f81dcfcca15a@intel.com> Date: Wed, 20 Jan 2021 18:24:43 +0000 MIME-Version: 1.0 In-Reply-To: <20210120212124.72fe1289@sovereign> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/i40e: disable AVX512 for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/20/2021 6:21 PM, Dmitry Kozlyuk wrote: > On Wed, 20 Jan 2021 17:40:16 +0100, David Marchand wrote: >> There is probably better to do rather than disabling AVX512 globally for >> Windows but since I saw no patch fixing this, here it is. >> >> --- >> drivers/net/i40e/meson.build | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/i40e/meson.build b/drivers/net/i40e/meson.build >> index c0acdf4fd4..c9a1a50407 100644 >> --- a/drivers/net/i40e/meson.build >> +++ b/drivers/net/i40e/meson.build >> @@ -54,7 +54,7 @@ if arch_subdir == 'x86' >> cc.has_argument('-mavx512f') and >> cc.has_argument('-mavx512bw')) >> >> - if i40e_avx512_cpu_support == true or i40e_avx512_cc_support == true >> + if not is_windows and (i40e_avx512_cpu_support == true or i40e_avx512_cc_support == true) >> cflags += ['-DCC_AVX512_SUPPORT'] >> avx512_args = [cflags, '-mavx512f', '-mavx512bw'] >> if cc.has_argument('-march=skylake-avx512') > > Clang doesn't seem to be affected, suggesting a cc.get_id() == 'gcc' check. > > The error seems related to SEH (structured exception handling). Some MinGW > flavours don't use it, which can explain why the bug isn't not 100% > reproducible. IMO, just disabling AVX512 for MinGW is enough. > Is there a way to disable it selectively, only for the compiler versions that doesn't support it? > A nit, is there a reason to prefer "x == true" over "x"? >