From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3ACA2A0555; Wed, 25 May 2022 19:44:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 305184113F; Wed, 25 May 2022 19:44:38 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2041.outbound.protection.outlook.com [40.107.237.41]) by mails.dpdk.org (Postfix) with ESMTP id 52201400EF; Wed, 25 May 2022 19:44:37 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UBVeM+/Z00D4PnnrTcoYJublYVG0PLoX13iOLY2ubcWs/kqGtO8eKyJjnuwKa0ocPmd5hnDPsjj7yDB1OzBrKwPw9uI4z+gU5cg6JwWbxddwtJqXi+5wYn3jgAghIMH8PWm/66lOzMGl3JIN7Aiop5FbhCTB1Rs4qXLylbesTkHBTVeb/Po3Zs9TzxIMiMsEUtc2xUE8z1un43rJYQoNLo212M39Rk05zH2niNNDBMQJpQcaT8Frl6T59Afx1ejN4G81UOukJYDij/3w83dPqgoibpgIEUa30UJhqiy9CmpY2DWCTnIznMB9PVEl1cZaP2LaK5UGtXKbnEaHlvDwvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hPernJcaHS6wgYwARJz/TgTqpxq/6dvLITT4R/F/Wkk=; b=juCMc0QSqTjyaVK7yts5OhaJUzKrjdmiG4hizO2LAaU4gszH0UMV+mbvc3CTlnyyWn3WGCxTSG98JqPqo7IxqM1JPAhklFI3fK2weWJVLQzidkbbhwM7ep87zKXFPJ++8SZGudy+rm0unS+MezVwoBZ4NDE1nk4dQQimpTJPwU1zhJKTp+4YIf4wf3kFfMl/DKsZKxJmwgp3svVXPFc/Y16qYgXGfyGoIyiGqLi7UdMB/4oMrMaRfg7rg8kVn5xTcTFjiyh4cGpIPIXro6yz2rKgDzTUyW9ZUzSR59WHJPA7nkQkYTucm8exKlWrrFB2+9/Uo5wzVquuwGiKd/pv9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=huawei.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hPernJcaHS6wgYwARJz/TgTqpxq/6dvLITT4R/F/Wkk=; b=YW3/GwHfAR/pwzoRDOa98PCmpB0mabxnu5+2uVZqrf2GZ5v1eu1jqB6l+sDXCSo7b6H9tu5aGZ8BAxRiTcgSd84qJsKt7lRu6ZP3OHUoNqRuL3WcJSl87jIWSX82vlJl7yyqmw2gP5RjdPgUMj+xaqXPOQ1KXcLr5oVVLNTzB50= Received: from DM3PR12CA0125.namprd12.prod.outlook.com (2603:10b6:0:51::21) by BYAPR02MB4184.namprd02.prod.outlook.com (2603:10b6:a02:ff::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Wed, 25 May 2022 17:44:35 +0000 Received: from DM3NAM02FT007.eop-nam02.prod.protection.outlook.com (2603:10b6:0:51:cafe::ec) by DM3PR12CA0125.outlook.office365.com (2603:10b6:0:51::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Wed, 25 May 2022 17:44:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT007.mail.protection.outlook.com (10.13.4.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5293.13 via Frontend Transport; Wed, 25 May 2022 17:44:34 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 25 May 2022 18:44:33 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 25 May 2022 18:44:33 +0100 Envelope-to: humin29@huawei.com, dev@dpdk.org, stable@dpdk.org, chas3@att.com, thomas.monjalon@6wind.com, david.marchand@6wind.com, nhorman@tuxdriver.com Received: from [10.71.116.211] (port=55216) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1ntv3g-0007Lz-Uz; Wed, 25 May 2022 18:44:33 +0100 Message-ID: <77d365ca-4468-3683-ab57-75df1dc3415d@xilinx.com> Date: Wed, 25 May 2022 18:44:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 From: Ferruh Yigit Subject: Re: [PATCH v2] net/bonding: fix mbuf fast free usage To: "Min Hu (Connor)" , CC: , Chas Williams , Thomas Monjalon , David Marchand , Neil Horman References: <20220521070814.35704-1-humin29@huawei.com> <20220525010828.39276-1-humin29@huawei.com> Content-Language: en-US In-Reply-To: <20220525010828.39276-1-humin29@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 54e80ac9-2932-4774-fc14-08da3e763b31 X-MS-TrafficTypeDiagnostic: BYAPR02MB4184:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cwTAo2yzhunR0syPqctr8bfoHK9ik5hHXGAowL4BLoMG7vewO9dOY6RYm5bgXllDVDDSrhvXCGOntjG8bUAKpkzjq0Zbx+J/YsJpJ983rSDvXRMA5vKT9Fi+L9+vYHPCwRtvx+vhLTBgRK+izFiWAqUF9Y/pPZRVEijE8Cl3itBrvvgiKA520Cme5zjM6HEjwn8ndQ/mPgdmpYFOeLHihCxy3TXHVplx9cgIJ0XXyZUkjAvpUTOOk1WxA2z+GXaNX41DpqJjQ1/LKqd5KGi64IHVDQfRmSa7nL08VoTP4zhSHUeAsIEJqcN1dzcoObTHQxPRGhQE+Z09SJzbRoKZzfJ7XOtOUrIP2OFcuzYm3xharZ20UH1bP/DXtJYBIht6aeh2W9y4520sH+gUP+tkF86ltq1qJguxgYjV/XVMuIksCa4qmseksG5zN2SihRLOhxoc7gv/9nEBTzVHZnVRYvUuJaP2G2mShQA+ynNjSVk8yl8UwnuNtyFmjFSEgv6vRwwttKDdxi1EOTsgK0MS1IWJvLia0zgPpCX+z4PM3rkOa1Wws5d6BENeeIXPbN2G1NLIPP9KPkgllCCn2cfdUmXa+FEJYXMRQET9lNQbGIZ+TW8rUL2k/FSHyw5sQs5nSR0bh3XxWmZxWXNa0hdSy/LNFPV+EHu4+X6DWWZ2Emgzr3d0BQlDhP61Wj14hpl7SbCbj4ktww4Tbo7ipVXp9wSZ7BGlQJwJbSVUQYzU8tE= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(2616005)(31686004)(26005)(36756003)(82310400005)(426003)(110136005)(316002)(54906003)(356005)(7636003)(8936002)(4744005)(186003)(4326008)(31696002)(9786002)(53546011)(508600001)(5660300002)(36860700001)(44832011)(2906002)(40460700003)(47076005)(70206006)(336012)(8676002)(70586007)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 17:44:34.4353 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 54e80ac9-2932-4774-fc14-08da3e763b31 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT007.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR02MB4184 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/25/2022 2:08 AM, Min Hu (Connor) wrote: > > Usage of 'RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE' offload has two > constraints: per-queue all mbufs comes from the same mempool and > has refcnt = 1. > > Bonding mode Broadcast, Tx mbuf has more than one refcnt. > Bonding mode 8023AD, It contains two mempools separately for LACP > packets and other packets. In Tx or Rx, Fast mbuf free will operate > mbuf from different mempool. > > This patch will prevent 'RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE' offload > when in bonding mode Broadcast and mode 8023AD. > > Fixes: 78aecefed955 ("bond: move param parsing in configure step") > Cc: stable@dpdk.org > > Signed-off-by: Min Hu (Connor) Applied to dpdk-next-net/main, thanks.