From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22649A04FD; Wed, 26 Oct 2022 12:01:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F18040F17; Wed, 26 Oct 2022 12:01:14 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2079.outbound.protection.outlook.com [40.107.92.79]) by mails.dpdk.org (Postfix) with ESMTP id DB85140041 for ; Wed, 26 Oct 2022 12:01:12 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N7qGKkZ09mg1mRoNXqaWlF3wU9zkFGvD+1Q6YBKgyu7yKORYKwOs1RzrHgLYyEgOk/Hs43O1+qQY1PcN+f5I2jLtx7VSskjj07EIvfhR/E2ahiqp0iQFVq9VjEaPO+fOgjpUMS8W34OwKWB2rAkhiyoHHPkQPmybSaMoIkR0f9G0SbuhKhyfgBRN/NJKS5Hfx69wDm8JtRzAaqhAhlflbx1O6GNz1VzCJholNhr8QiYEgp3NcRtvORJDgPHFatunGUw8h7LTt5U86v4Har/YNInMZxpgaiLpl5ao9D5C9LN0WObT9/lbGLx9CiBdJBUUtXaH/r3mOjCzumDVGSDC5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kqKP8lF2/NpsCb1DF2UtzV7e7hAcwF1WGkRMIGxvp+c=; b=Ud9s7HKiBNmz9fglvs7irwWVinIW4BY+Q5o+t4YzwaSCxyJovJCcpdV51Qkt1WvJ+oD4kK48pHbgUBqDTf9v5RwjhhgB3hRRtCVWf58lWbkSNzN99RuVRMw9B1sxIoMDlnL/QokoyWqIxuq2jO3AHO0LnzAlWfDWYkx8jkfOsdY0DmBG3aBz144tAasbPmW4XO3d0suhomSbu4bfnOKQ/cILDS91u7i2NKIspuQRvvq/QH/vPfVH2QCG4sNpJ3JISfkI45WtYGI2oPnCvFsCVMIMRAxbgEWM1WAileSLt2S2Ghx2jnR275rxYL3iW9NgVPpjmthof9tsAAYiTNGwpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kqKP8lF2/NpsCb1DF2UtzV7e7hAcwF1WGkRMIGxvp+c=; b=Y6zPwYnqjKVErBaHZmt1gBYxrZk5lqvBAfSl2H9OoCJ/cWIFpUrnwR7hpooaieoFMF55u3KJXJ0R+XLsV255m+dH0t26Wulj8lLl8+lSH4HeNsj09PaZo0hA65P3n1vDG0jBtoYkXcsFymEjkwH2lb+++TTUxdCMD0A/IOezCCw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) by SN7PR12MB7321.namprd12.prod.outlook.com (2603:10b6:806:298::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Wed, 26 Oct 2022 10:01:10 +0000 Received: from MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::7900:1b25:bc:104c]) by MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::7900:1b25:bc:104c%8]) with mapi id 15.20.5746.028; Wed, 26 Oct 2022 10:01:10 +0000 Message-ID: <77e5b7c9-15a2-cf8e-4bb5-41fb9ec06ce9@amd.com> Date: Wed, 26 Oct 2022 11:01:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH] net/gve: fix meson build failure on non-Linux platforms Content-Language: en-US To: David Marchand , Junfeng Guo Cc: qi.z.zhang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, dev@dpdk.org, xiaoyun.li@intel.com, awogbemila@google.com, bruce.richardson@intel.com, hemant.agrawal@nxp.com, stephen@networkplumber.org, chenbo.xia@intel.com, helin.zhang@intel.com References: <20221026084244.22083-1-junfeng.guo@intel.com> <67f72e30-5247-6055-88cb-b019a85328ab@amd.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0204.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:318::14) To MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB4301:EE_|SN7PR12MB7321:EE_ X-MS-Office365-Filtering-Correlation-Id: debb7fa3-0296-48d6-4b86-08dab7390234 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kWg02evT/3DWX6I1uaUtB3ewt84jo1ZUm1lFFKkLCT2v8ClQz0/Caf0W8OCFo2RbD3NV7ocN23F09pkZ81ZSIITcJmQtpFD+IdYur4wg8b5zeJA6qkCrn3Mf+1jhtK/Gzsod+VRZvyK9RN/JMPIfdlZ8ukRf5tRMbGaaX+dQebpgh5YPGTVroyEryUvNrwvuRJKQPaTaiHje947XaERHlba13fISB4bCXCceREgfRh5ivjEjqTeutgBr5MyCHtAQTrXXOXji2eSP9gXi0ReoveYReGkW+ohhWqRCDbO1HXBPHt49WEA507UQBp3tYVaWELqkAxpRAE6YOn5aZ9ZSOjWy1N70Hf9ovhD93UZlFa8NFQETY5EakFS/OBXCgXj9NSnt4XFMI0vBy4yWYtdA2g2DEGeSC3tvze9n1msvGU/THhIT353YX/w8I0dXTNK6hgvZsdjusI/Y1TPXY33K10OAhQTgGXk3TZnxxTDwWSKulEB5ClPuKem/52+XX/9X8rfezqzSBzBEysxv2x9K/H7ArNf+zsNQzw8NL6CrE9usf93p10/y6AT48TDKSg/KxeLli0s6hhBE+y0ucGccnsOTserxhk9JCud8PlbZ5AmceZ+a/dimL3CjcI6b+mKj62kpbtoz7JpHRHgj14pVZCdBjFH578PIt4s4hSCSekqMht70O16aP+I1B9yfH+xdIfIM4hWaLhV+g8Oy5AVyEHKI3hs9A3PLh9dSJdYRbwPH8OLF0XvIYUhcvR7X3P6MatjkkuhdRVJjCKleIv793dlQHz0EPjPet3jDuYpelX+hVH8M7g9zc969uLONG9Cu X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4301.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(396003)(136003)(346002)(376002)(39860400002)(451199015)(5660300002)(2616005)(26005)(83380400001)(186003)(38100700002)(31696002)(2906002)(44832011)(7416002)(86362001)(8936002)(478600001)(6666004)(8676002)(6506007)(53546011)(966005)(66556008)(4326008)(316002)(66946007)(6512007)(41300700001)(110136005)(36756003)(31686004)(66476007)(6486002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZkdNMlNqMVpvZDFjdTJONVlMcmsrUXlObHYveWZMallxRGQ5T1p5Q044b0Zk?= =?utf-8?B?VlVxckJHaTRtR3BNcnpCODMwTXpPZ1cxdExWZFJaUEVrOGR4M29RT2crL29G?= =?utf-8?B?MTVFSzlYQ0RiMk5ZOUNRTGs3dWxkNUl4MWxwQnBzUVlIVzN6bDgvMEZkdHBW?= =?utf-8?B?ZWM5UCtqand3MkZ6UktzMGZUeE1MVjg4QjBUdnV1eExTKzd2NlFqdHdzcUcy?= =?utf-8?B?Q3F5cURRM2FvR2hKekhQbE9TYXlmL0lOQ2swV24yVW5PcmdaWnhzVUNJTS9X?= =?utf-8?B?UjJkV29ub0ZwdGxqMkYvUmlkcjVrYkNESnNnbEhnMFl2RXo4bE9xd2R6Q3ZD?= =?utf-8?B?a3BmL2lLV0svQTBFcGl0cFY5VEJTYnZraTYxaVd2NFZYN1ZzaUF1bk9La2c1?= =?utf-8?B?b0dXSStpY2NUU2tQcG5TaW8xNVRkNHFhYmZmSE9SS1R6cHBsZzNWN1dWejRK?= =?utf-8?B?eDJpNjZjckE2Wmd6TUJ2VFpEWTA5Y3JFTFBkWFUxN3hxTkRtVmEzUW51ZXNu?= =?utf-8?B?dzh6QzMrTDljTlhBc0dyNWVJd0krUm40bkN6TE93d0VpV3VhS0M5TE5uelpW?= =?utf-8?B?SHNpZm8yYVpwQzQ2ckVyYjVpZ0QvOWJFM1U1NGR2d3F5NHBPbHdIRFYwUVlk?= =?utf-8?B?UHJTc3dKSm1DOWE5MDBMRmFLR0gveHRJWEt2aUV4N1paSUJGWmtlaUNoMmZR?= =?utf-8?B?ZURaOHZKOHQ1OUROOVBqQ0xlL2s3Snh3NUozQ2V4TmllT1lxajJReUtQQklB?= =?utf-8?B?NkZveEZhcTdnRmdSc1phTTZteXM3dElMNlJuMk5oTiszZUJnYTdSYlBYTDJj?= =?utf-8?B?bnFYaHRDMHpSbDUxYnhzY0VvejRBR2VwaWJNZ3dSbjRTZEJQc3loblVjWkx0?= =?utf-8?B?bkw2elQxWVZRZCs2RVBTaWFOSndLc3FIdG1vT2F0eDNOUkR0c1EveUhVUHJK?= =?utf-8?B?RVczeWJqK2NoRWczTWhUTDVMckJhMGttWWo5cTRFK3NTYUNaOUc5TVRPQm5S?= =?utf-8?B?WEtBaS9jRVBuRE1TbWVjNklQdGJYVUplLzQxRVVVYXhmdng0TFNZYnFDZDJv?= =?utf-8?B?V2dQTEFDRFhEbXV6Q3ZPSkRhV3Rac1RiMW15Sk01Qm8zMEY5cW5JN3BFT0tN?= =?utf-8?B?SElzdWV5dzA5QWYrVCtNUjJkSitCV1NsS3d1ZkMrcVF0bHZKVzFtNi82LzAw?= =?utf-8?B?ckYzMDBlbEVmMkxJaDVqOVN4UVVXREl6eDEyNStMUS8yS3BMYjB2NUNoMDFo?= =?utf-8?B?bXhUak95WnM3VzUvaHhQM0lrMjVWRUtlTTRnbmo5NjVHVlZ6OFUyNTVjVjRV?= =?utf-8?B?Um5NYVBzKzJYVm5kRkNwUzJTMVZHVTdBeElWdUE2UStzV3lOQUhsQjlCQmZn?= =?utf-8?B?TFJ1ZTFKbkNHdTB2K21aRk15bHZualpVOU5ac05abVlrN2NhVU5ZNVNGdER4?= =?utf-8?B?WVFqZ1pGMHR2ZHpBdU85eUpXZ0JCYnkwLzVPZDJTWHV4dmljeTh5OU9Rc3Qz?= =?utf-8?B?L1B4Qm9IU0svNWFONm95SEdKRldQZ0hlZHRMc0NDaVhwQ3cweEJuY2R6a3p6?= =?utf-8?B?S2hRTjVrUDI0VjFQWWZ3aHA1Q2tBYUd2Tm4ya09acUZ1ajJ3TzZWbGZlakJs?= =?utf-8?B?MC9pRkxrVXVWZnFVS3N1cnc1YnlrckZ0WkFwQmxsZjlqMnUxeVpWbTd4SEpY?= =?utf-8?B?d0ovQlFKV2tBRzVsSWVQQllNRDZaYUh0UG1hbGNwdkhTdzcwanUrc2I4Y3Fu?= =?utf-8?B?b1lkMldpb29GZFJWSmRPdXVTQUZXejhKaWRvZE5wclpaMitmMStqNWUxNmhp?= =?utf-8?B?UHFZWkdEZCtLQnptTFlNckE1YWU4d3did1hsNCtKTTlzQ0YxTUFHVGxoaEMz?= =?utf-8?B?dTZwVS9ZRVJNVWd6cW0rSmE3Wnp3RFduVDF5SUFJUEVjUWhQOGljYTVSdE5n?= =?utf-8?B?V1dybkVxejRUUlE1RlB4akRZN0xLbHl4YWhac2tlQ1J0MFRtbk1wbVg2anJ0?= =?utf-8?B?em5vb0x5VHFtVEJ1dk8rR240S2VNMjFJd1BSZTFDZmhOeUprSWpnMHNxUU40?= =?utf-8?B?dUZPRVl4VVpJTDM4MGpBaGZqWFRIOXdMTHJ1UlhQaU1sUGw5Q2VkRHNkN0cx?= =?utf-8?Q?nmcS3IRGpv0A9OiMIGj0ocPAz?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: debb7fa3-0296-48d6-4b86-08dab7390234 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4301.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 10:01:10.6378 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EkbsDVld53rjXgFepxzUc6j8jOr3PQH8fRnm6R4nrz+kGolqE2jJ6JAmtND1Odwp X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7321 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/26/2022 10:33 AM, David Marchand wrote: > On Wed, Oct 26, 2022 at 11:10 AM Ferruh Yigit wrote: >>>> diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c >>>> index b0f7b98daa..e968317737 100644 >>>> --- a/drivers/net/gve/gve_ethdev.c >>>> +++ b/drivers/net/gve/gve_ethdev.c >>>> @@ -1,12 +1,24 @@ >>>> /* SPDX-License-Identifier: BSD-3-Clause >>>> * Copyright(C) 2022 Intel Corporation >>>> */ >>>> -#include >>>> >>>> #include "gve_ethdev.h" >>>> #include "base/gve_adminq.h" >>>> #include "base/gve_register.h" >>>> >>>> +/* >>>> + * Following macros are derived from linux/pci_regs.h, however, >>>> + * we can't simply include that header here, as there is no such >>>> + * file for non-Linux platform. >>>> + */ >>>> +#define PCI_CFG_SPACE_SIZE 256 >>>> +#define PCI_CAPABILITY_LIST 0x34 /* Offset of first capability list entry */ >>>> +#define PCI_STD_HEADER_SIZEOF 64 >>>> +#define PCI_CAP_SIZEOF 4 >>>> +#define PCI_CAP_ID_MSIX 0x11 /* MSI-X */ >>>> +#define PCI_MSIX_FLAGS 2 /* Message Control */ >>>> +#define PCI_MSIX_FLAGS_QSIZE 0x07FF /* Table size */ >>> @Junfeng, Can you please move these defines to 'gve_ethdev.h'? Beginning of 'gve_ethdev.c' seems too unrelated for PCI defines. >>> No, don't introduce such defines in a driver. >>> We have a PCI library, that provides some defines. >>> So fix your driver to use them. >>> > > After chat with Ferruh, I am ok if we take this compilation fix for > now and unblock the CI.. > ack > >> >> I can see 'bnx2x' driver is using some flags from 'dev/pci/pcireg.h' >> header for FreeBSD, unfortunately macro names are not same so a #ifdef >> is required. Also I don't know it has all macros or if the header is >> available in all versions etc.. >> >> Other option can be to define them all for DPDK in common pci header? As >> far as I can see we don't have all defined right now. >> > > If there are some missing definitions we can add them in the pci header indeed. > Those are constants, defined in the PCIE standard. > > I can post a cleanup later, but I would be happy if someone else handles it. > @Junfeng, Can you have bandwidth for this cleanup? Task is to define PCI macros in common pci header, ('bus_pci_driver.h' I guess ?), and update drivers to use new common ones, remove local definition from drivers. DPDK macros can use Linux macro names with RTE_ prefix and with a define guard, as done in following: https://elixir.bootlin.com/dpdk/v22.07/source/drivers/bus/pci/linux/pci_init.h#L50