From: Thomas Monjalon <thomas@monjalon.net>
To: Tianli Lai <laitianli@tom.com>
Cc: dev@dpdk.org, "stable@dpdk.org" <stable@dpdk.org>,
Ivan Dyukov <i.dyukov@samsung.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] examples/kni: add CR character at print log
Date: Tue, 08 Mar 2022 14:29:29 +0100 [thread overview]
Message-ID: <7807989.zQ0Gbyo6oJ@thomas> (raw)
In-Reply-To: <2784dce5-50da-7a27-856b-05d7d5a7de0c@intel.com>
07/03/2022 15:52, Ferruh Yigit:
> On 3/7/2022 9:05 AM, Tianli Lai wrote:
> > add CR character at print link state information
> >
> > Signed-off-by: Tianli Lai <laitianli@tom.com>
> > ---
> > examples/kni/main.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/examples/kni/main.c b/examples/kni/main.c
> > index f5b20a7b62..e99ef5c38a 100644
> > --- a/examples/kni/main.c
> > +++ b/examples/kni/main.c
> > @@ -719,7 +719,7 @@ log_link_state(struct rte_kni *kni, int prev, struct rte_eth_link *link)
> >
> > rte_eth_link_to_str(link_status_text, sizeof(link_status_text), link);
> > if (prev != link->link_status)
> > - RTE_LOG(INFO, APP, "%s NIC %s",
> > + RTE_LOG(INFO, APP, "%s NIC %s\n",
> > rte_kni_get_name(kni),
> > link_status_text);
> > }
>
> Fixes: db4e81351fb8 ("examples: use new link status print format")
> Cc: stable@dpdk.org
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied with title "examples/kni: add missing trailing newline in log"
prev parent reply other threads:[~2022-03-08 13:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 9:05 Tianli Lai
2022-03-07 14:52 ` Ferruh Yigit
2022-03-08 13:29 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7807989.zQ0Gbyo6oJ@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=i.dyukov@samsung.com \
--cc=laitianli@tom.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).