From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <arybchenko@solarflare.com>
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
 [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 8C2A72BC8
 for <dev@dpdk.org>; Sun, 12 Aug 2018 12:51:02 +0200 (CEST)
X-Virus-Scanned: Proofpoint Essentials engine
Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])
 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id
 30C7E780055; Sun, 12 Aug 2018 10:51:01 +0000 (UTC)
Received: from [192.168.1.16] (85.187.13.33) by ukex01.SolarFlarecom.com
 (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Sun, 12 Aug
 2018 11:50:52 +0100
To: Qi Zhang <qi.z.zhang@intel.com>, <thomas@monjalon.net>,
 <gaetan.rivet@6wind.com>, <anatoly.burakov@intel.com>
CC: <konstantin.ananyev@intel.com>, <dev@dpdk.org>,
 <bruce.richardson@intel.com>, <ferruh.yigit@intel.com>,
 <benjamin.h.shelton@intel.com>, <narender.vangati@intel.com>
References: <20180607123849.14439-1-qi.z.zhang@intel.com>
 <20180810004213.44497-1-qi.z.zhang@intel.com>
 <20180810004213.44497-6-qi.z.zhang@intel.com>
From: Andrew Rybchenko <arybchenko@solarflare.com>
Message-ID: <780aace9-e241-b81f-dc98-5200be5ecaeb@solarflare.com>
Date: Sun, 12 Aug 2018 13:50:45 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180810004213.44497-6-qi.z.zhang@intel.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-Originating-IP: [85.187.13.33]
X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To
 ukex01.SolarFlarecom.com (10.17.10.4)
X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24026.003
X-TM-AS-Result: No-2.141800-8.000000-10
X-TMASE-MatchedRID: u1zqiMeMcroOwH4pD14DsPHkpkyUphL9Ct59Uh3p/NXczkKO5k4APkQZ
 C8V7yVQqi0tOPtLu9GK1Yu370vMdVuF/B1jEjV+6ngIgpj8eDcC063Wh9WVqgjuUMbK1NdLP+gt
 Hj7OwNO2OhzOa6g8KrdpVx1thiNyJEK5O448ZBqEaQp0OcSzmefJjHQSvAH5orFk+jkymyG+HzG
 THoCwyHhlNKSp2rPkW5wiX7RWZGYs2CWDRVNNHuzflzkGcoK72
X-TM-AS-User-Approved-Sender: Yes
X-TM-AS-User-Blocked-Sender: No
X-TMASE-Result: 10--2.141800-8.000000
X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24026.003
X-MDID: 1534071062-sFKukaR7tp-T
Subject: Re: [dpdk-dev] [PATCH v14 5/6] drivers/net: enable device detach on
 secondary
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 12 Aug 2018 10:51:02 -0000

On 10.08.2018 03:42, Qi Zhang wrote:
> With the enabling for hotplug on multi-process, it is not necessary
> to prevent detaching a device from a secondary process.
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>

 From the patch itself including description it is absolutely unclear
why detach works and where it actually happens.
Why is it OK to return 0 instead of error and that's it.
Why is it necessary to call uninit at all in the case of secondary
processes?