[dpdk-dev] [PATCH] examples/vm_power_manager: remove dependency on internal header file

[dpdk-dev] [PATCH] examples/vm_power_manager: remove dependency on internal header file

[Marvin Liu]

Macro CHANNEL_CMDS_MAX_CPUS stand for the maximum number of cores
controlled by virtual channels. This macro only be used in the example,
so remove it from library to example header file.

Signed-off-by: Marvin Liu <yong.liu@intel.com>

diff --git a/examples/vm_power_manager/channel_manager.h b/examples/vm_power_manager/channel_manager.h
index 67e26ec..47c3b9c 100644
--- a/examples/vm_power_manager/channel_manager.h
+++ b/examples/vm_power_manager/channel_manager.h
@@ -41,7 +41,13 @@ extern "C" {
 #include <linux/limits.h>
 #include <sys/un.h>
 #include <rte_atomic.h>
-#include "channel_commands.h"
+
+/* Maximum number of CPUs */
+#define CHANNEL_CMDS_MAX_CPUS        64
+#if CHANNEL_CMDS_MAX_CPUS > 64
+#error Maximum number of cores is 64, overflow is guaranteed to \
+    cause problems with VM Power Management
+#endif
 
 /* Maximum name length including '\0' terminator */
 #define CHANNEL_MGR_MAX_NAME_LEN    64
diff --git a/lib/librte_power/channel_commands.h b/lib/librte_power/channel_commands.h
index de6d926..383897b 100644
--- a/lib/librte_power/channel_commands.h
+++ b/lib/librte_power/channel_commands.h
@@ -40,13 +40,6 @@ extern "C" {
 
 #include <stdint.h>
 
-/* Maximum number of CPUs */
-#define CHANNEL_CMDS_MAX_CPUS        64
-#if CHANNEL_CMDS_MAX_CPUS > 64
-#error Maximum number of cores is 64, overflow is guaranteed to \
-	cause problems with VM Power Management
-#endif
-
 /* Maximum number of channels per VM */
 #define CHANNEL_CMDS_MAX_VM_CHANNELS 64
 
-- 
1.9.3

Re: [dpdk-dev] [PATCH] examples/vm_power_manager: remove dependency on internal header file

[Thomas Monjalon]

2016-07-04 16:57, Marvin Liu:
> Macro CHANNEL_CMDS_MAX_CPUS stand for the maximum number of cores
> controlled by virtual channels. This macro only be used in the example,
> so remove it from library to example header file.
> 
> Signed-off-by: Marvin Liu <yong.liu@intel.com>

Applied, thanks