From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB0C0A0C43; Tue, 14 Sep 2021 17:53:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ADAFA4069C; Tue, 14 Sep 2021 17:53:04 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 503764068F for ; Tue, 14 Sep 2021 17:53:03 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10106"; a="218863569" X-IronPort-AV: E=Sophos;i="5.85,292,1624345200"; d="scan'208";a="218863569" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2021 08:53:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,292,1624345200"; d="scan'208";a="552555979" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP; 14 Sep 2021 08:53:02 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 14 Sep 2021 08:53:01 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 14 Sep 2021 08:53:01 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 14 Sep 2021 08:52:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O+9xe6ERDSV4PDCKFJa6aRFCqbgUt3rGFAVMyVXZRjYJ/24KCOr9/mdSB6x504fDcXrhZn72b9VXmKReS+nvJvUtd12VzqpIbSU45EpQPqrNJLEqqmainn9JExrvhb9OWN9mdQnSju4Df/eQIaTOgrI9q0tSiQi3jVnZs+KMplnl8WVCpT5wBIRBmC4aS7WijYxRLysK4GYvChKNSQikz99nA6jvZSn0+EhJz5T1WAAPlreMvdMAK+RvICcC8SJ9TiK31A2VpoXVw+tMEN1uRSF2vmEfmrlGtXcStO+OXObGttvSqGXq+C+huwSPFYjNMG9KgK0lyyJResL27cGnrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=SVSI1O+iClR19zH4bvmKZ40kuQDxSZSXT9/WIjivXI0=; b=VePQzUVjwzLScFaMGMQ1onytq9zRg0pcjj8MbfysmpUgSo872ko9nRHwguJ6sUjanl1Pl5Agsl2K8np+8CMRLx4WbKv0VtwCKUi8BaQsP6iTNyEVnIHeWQ+PsLOXU0hpC97C2y9RUo+LWMNw3oDjpFmQvqOSIs5NvbCuFK/wKrURQ9lj1hEOCPmBy28SeKHze3PEWMN2VToFHjhCpHGodtRForVsT81lS+yKJhyruTMRksdUz07bET/ap7P2b5aEbVRFjZUx1CTjzw4ryu8YyiElhrKu7TY6wK827LS0j0BBfPdXg3+NV0o4a+32P9OtzSfKBJUcXy15kRK981WwNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SVSI1O+iClR19zH4bvmKZ40kuQDxSZSXT9/WIjivXI0=; b=HZsTyd9XlBVmtuxmrxlDMKN73IYh7+iUXc8xIC39cdPj1s1E6u97d2v74SBJdkme9XJsrfStnC/S6UF1AiE1aTBWkuuHs4zMjH5qbPSl0SWK0LvZIB+adgQ3EKDLYDhpOZpvWOFo+FFxqdcZ4VttSMBl0EZ1swSxyGxHkdlYIpY= Authentication-Results: xilinx.com; dkim=none (message not signed) header.d=none;xilinx.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5176.namprd11.prod.outlook.com (2603:10b6:510:3f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Tue, 14 Sep 2021 15:52:57 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4500.019; Tue, 14 Sep 2021 15:52:57 +0000 To: Andrew Rybchenko , Xiaoyun Li CC: , Xueming Li , Viacheslav Galaktionov , Andy Moreton References: <20210827063935.1834143-1-andrew.rybchenko@oktetlabs.ru> <20210831161242.3465395-1-andrew.rybchenko@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy Message-ID: <78232368-50f3-a03e-aedf-b7f0a8249792@intel.com> Date: Tue, 14 Sep 2021 16:52:51 +0100 In-Reply-To: <20210831161242.3465395-1-andrew.rybchenko@oktetlabs.ru> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2PR04CA0306.eurprd04.prod.outlook.com (2603:10a6:10:2b5::11) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0306.eurprd04.prod.outlook.com (2603:10a6:10:2b5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Tue, 14 Sep 2021 15:52:56 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 26803eb4-1de5-4d31-3c0a-08d97797b8b7 X-MS-TrafficTypeDiagnostic: PH0PR11MB5176: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5236; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 70Vm53+A5udMTODOWfBWy3ZIAmm2EK3CKokd9z38KIS8ueBRSM/CnclQdDlZfhvrk29IdEp06Z5kZa9koBQFcEA26EW09asNMMOo+vgo6i8wr9KMP8tOOz/Fl6+0ZfEMGk9Ca2VdqSgCobouw2KNvD34IjWUKw+Hrv+or3HfStZEmZm4aTb7oBLZU+Smp9hks+ykMJSjAL9FGAG/B/GTc/8flb9El/Gi8tL2UFesaiK4O36AAU5ZKGFDRuAsSe25pcEe204l8/8hOra8maPsvrEKE23u14Qef0DmzyLiX8bicSgF7IqgNM4ONeMwkTAwY6hNweaGiVG8zFssGHDHh0nw2vgv79oYTnipLr08Nz7yDc8WSW9+EFagluzWr23i+U7BnscUmnQXd679J38yrOqvRHlDPq9P9+R5UMvCe/zoVOCZa9fTKH+xITeQN405Yn3wnkVi4dvONCaaI4KM0YkvfB38azmPZPmeWwrT0+3Q9i2v+kbUZWZE+ZEg1lF6uvzk6GkrLfC8Fk/5yByItTFwea4qfP5c8I44i8RtyCHceyN7m1tuS5HNcZqVtp0J2n6kXHqb+XcMPuHw0AuGJDYDOW/UV/mw4n397eaxxkl31RJDVPhflycDf8DAdtpDZ7hZtpm1GFR+HiPUNHo2lb4ueNJOCpZcerYLnb+MKzUn8IQDIdxRSD5dInEcssK1tIDeKVISAgPmkDAXtCcUKQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39860400002)(366004)(396003)(346002)(136003)(478600001)(44832011)(36756003)(86362001)(31686004)(2906002)(8676002)(8936002)(6666004)(31696002)(186003)(2616005)(6636002)(5660300002)(6486002)(956004)(4326008)(16576012)(316002)(66476007)(66556008)(54906003)(38100700002)(53546011)(26005)(110136005)(66946007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWs5U2UrS0E0YVUxRTdtQ3o4YjJjdjByYXlvd1lFclNhbEozRGljQ2FzLzFi?= =?utf-8?B?TVhTU1BQQVdYblRidmtBaFQ1bmlZTlJYZk8xYXdrc2FMYldlbmkyU1BWZzhy?= =?utf-8?B?bnlDbWgzS0NPb3FpcWZvUm50azBwa3Q0N0o2V0Z2a0FQa2d1d1kwWkZRK3ZD?= =?utf-8?B?dHdzQ1dsTlNkYkZiVy9mZExKQW5KZHpRQnNSSnpLQnJMT2pBdEh4cktrcXJj?= =?utf-8?B?cjB0VWh6L3NLWlVtNEtyMWZUMUoyUWhYUCtlbWtIbkRQRzFlTnA4a3Ewd0ts?= =?utf-8?B?akp0Q2JpRytUUFFORkhUUXhrclRLS1Z5bU1JODRZRVFQVTJmQ1gzMDk3MmRD?= =?utf-8?B?US9oeHhIVHhSOEtwQXo0emtMYUp3anhRUHB0WUpKSnZLUmU2YW0xUFRQZm93?= =?utf-8?B?eEhvWG0vbmtHWTdsNWFJZitXR0dPRzlhOGlqYnJBeURJL2ZOSjNxWXFmbTdJ?= =?utf-8?B?R0pSOUIwYkFzK3J2dXBKcmJCQk00aWVSMURSK1l5WXhqVDJ2L0JkUTZqaXFH?= =?utf-8?B?TTk5WVQ4a0N6UCtvdlZFeGVZc20xQzhvWnlhN2VEaElRcXRkNlRrNFIwSTlj?= =?utf-8?B?RkQ4VVNvSG05TjlMWWtRSjNNazFsempuRWZSUGhsYS9IaVI5WGxDbWlrK1ZK?= =?utf-8?B?TUloYUFLQW52VmpRMTdEb0IxMC8wOWhHV1EraitMelBOa1hkN1VrbW5NY0kx?= =?utf-8?B?czRPNWNNLy8xNHB1WDFVblUyVmxuN0ZYZVdheVl2bmNid0dRZ1dOYS9UUWx0?= =?utf-8?B?emxucDY0c1E5V2xzR2o5bDMvcTYvRmU2V3FndTlIbVVheitJUUFsRWR4cy9z?= =?utf-8?B?QUd2VVAweWNyempBN1hUVEJmQmgvbjhZeTBJVE1OWDVPYlpWS0ZQd2R2eXJn?= =?utf-8?B?WjhqLzd1cGQrdFlveGVmMlFuOENiQi9hK09GNWtsUnE0Nmtha3NiSTdxM0FK?= =?utf-8?B?ODA1QzBZWnBBdE9RbUcyT0F6RnJGL3RZUUVDVEVSQVZOWkRYZGtXSTI2Q0gx?= =?utf-8?B?bjRSSEtPbHpEYUtwazFlV2pkVlBEek92Z2tMd0p3TmNUczU3TnhlVkdGOWxU?= =?utf-8?B?Wk9lUzFVNFlNNDVmTXFaZWVabkZESFQ3MXMyaDBud3R6MXpweS9jVnFWNDJC?= =?utf-8?B?NmFFVmhyTGkvTTM2N1gxeGlOalIzR3hEYm83VVBUYzZYYkhrMENpRkxxbTFT?= =?utf-8?B?Mkx6bHdTUkUvNzNKOVpBVGVOczFpU1JFRFNtWFBZZS9na245VjhySGNTR1dT?= =?utf-8?B?NHZXVnVkd0h2NjRQcFBSUlpOWWRNU1JKWGFuN2JHclpVUlVYa3hhaXljd1ZY?= =?utf-8?B?SGdBdHZVZ3NjLzllVTQ5d1N0WGJKMXpoSDhQL2lSd25DOTQ4MEIwcWMwbWpj?= =?utf-8?B?S0x1U09EcGNodUI2SFgvZDNUdnc5K0N0QVhzdVYyTUoyc2hvc2ZlUTFCWUhi?= =?utf-8?B?b2U3YlJOVHJvUEZIanpEcDBpQ1I5ZGY0TVFjZ1hnMXNBQ2NxTnR3ZEVBNHNj?= =?utf-8?B?aXZBRzI4Y2Ezb3k1WHhHeGI0QWtWb3hPZDR6enBjTWNXeFdHdnY2Tzc1QVRq?= =?utf-8?B?bUo0bVRiZDdma2xyczNDNng0V1VJbTlseGZBamJIcGxUVVI3V1RkNERsSUFm?= =?utf-8?B?RzMvUHNvZE9qRHJnRWtQSWRIVExTb2xCeFFISnlUSWNDa053T05pVFVoc0ZU?= =?utf-8?B?MWdLNGNPTEtXWGdEL1FtUWVHVlNGVkZicGx5UzNwSXcxMzZ2ZlRkWkNJSjdE?= =?utf-8?Q?h/hq3WYjDK/6zh2OZ40BTEo3pfpZsM8Lp7s/cFf?= X-MS-Exchange-CrossTenant-Network-Message-Id: 26803eb4-1de5-4d31-3c0a-08d97797b8b7 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2021 15:52:57.6212 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Eh1M92Z5R1+pKKuYeVL/8L3xjDedBNjpGdPlaDKZqpNROs2fNnfbH3h2Yf6nunOp25WJzYBVwuqPTksi+4MWrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5176 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: add command to print representor info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/31/2021 5:12 PM, Andrew Rybchenko wrote: > From: Viacheslav Galaktionov > > Make it simpler to debug configurations and code related to the representor > info API. > > Signed-off-by: Viacheslav Galaktionov > Signed-off-by: Andrew Rybchenko > Reviewed-by: Andy Moreton > --- > v2: > - change output format to log just one line per range > > app/test-pmd/cmdline.c | 135 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 135 insertions(+) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 82253bc751..ae700f9dd1 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -236,6 +236,10 @@ static void cmd_help_long_parsed(void *parsed_result, > " Show port supported ptypes" > " for a specific port\n\n" > > + "show port (port_id) representor info\n" > + " Show supported representors" > + " for a specific port\n\n" > + What do you think extending existing "show port info #" command instead of creating a new command for it? Since "show port info #" is a well known command, it can simplify the usage. When port is representor port it can display additional info.