From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D01FEA034F; Mon, 11 Oct 2021 13:41:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E6102410F5; Mon, 11 Oct 2021 13:41:55 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id F3693410F2 for ; Mon, 11 Oct 2021 13:41:54 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10133"; a="226754298" X-IronPort-AV: E=Sophos;i="5.85,364,1624345200"; d="scan'208";a="226754298" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2021 04:41:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,364,1624345200"; d="scan'208";a="523786738" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga001.jf.intel.com with ESMTP; 11 Oct 2021 04:41:54 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 11 Oct 2021 04:41:53 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 11 Oct 2021 04:41:53 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 11 Oct 2021 04:41:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gmExeVOnTN+96LTOH/f7TZcUQTwTVoWcRrGZ8qFJ8EtcPMklCTL10BoVYadamYczwzGjcJdV95pXQpy9WYOuy5vqOD7cUvbQCB8Uz+Vbe+/iIbxsAKhB2KsTcwoV7VTbXFjHdOeol5ff6tJ+mhULj12DWKTziU2YdcRWtShLtN3PegiXYUxvQHi5E3UTqWDu5m4bCJ5QYiOD03GZIz/hx7cj8HAaQL1Yvgz09Z0BacZ/WUyeUd2CyW8wGx2gbpyV/KYiVpR/oWaZ1X8CB9uNY3LXN0HlBGq8coC7Yf7D/1ZI6ZWY841Qs1QJZlV2DaXOX25hd3Tg02ZZjXOjOkb5gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yAF8ZNJs8i1jdnNFsRGrDLIGUrsEGnsuKFAiK9e+D+c=; b=RWqIUPMjo9EUP1DJZA73HzIqJdq0MgYaj5WIFvLRhYywBkwKbVNWe4r/l2yyLjBVjVCLakgxyoF9O0uT3XJHaTd49jq3WBalGcvn7GEXJEwpePcNR1xTWbrX3XlTSSeRTZPG2zZWSGDtg2MQU/yJ30To00UeaP/wEy2pbYkJvoY9locciVMpmK/ZmEjepI1fd0UbjWJT0sKldqlXuLnNNTvANGEQVAuNDa+YU3az7bmvRxcxK0RqLwwxxdLhqDKlgfB9Ut4zkfvzYGhXJDFa1+mZ7XxWzxTmAHMWRHJLn3TXoUiYe6mHF5JoVrh2mDi32nG/FhQjGmhGbaCrjzM/cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yAF8ZNJs8i1jdnNFsRGrDLIGUrsEGnsuKFAiK9e+D+c=; b=fkkPwDT8Mc7+fPsa9zW71Yz1y7lMBtJj0Q0sopwYKpsYZfqdD4PWU7nSBQ0gnpfB6VX2H6Wzz363qRuA6o7cnDYLZ/vSyuf5LnQMl4kkwY+FRlLa0F4uX3dCw52Lvq1mteAN/G5JC1m2iMJIAFrXOA0Zf3fOKD1kuh7Tnas21lg= Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5079.namprd11.prod.outlook.com (2603:10b6:510:3d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Mon, 11 Oct 2021 11:41:35 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021 11:41:35 +0000 Message-ID: <7831c65e-deab-a7bf-18d0-16c63e06cc2a@intel.com> Date: Mon, 11 Oct 2021 12:41:29 +0100 Content-Language: en-US To: Jerin Jacob CC: Pavan Nikhilesh Bhagavatula , "Jerin Jacob Kollanukkaran" , "Maciej Czekaj [C]" , "dev@dpdk.org" , Bruce Richardson References: <34ea1ee8-1ba2-4a70-8d9a-85b30fed4a6c@intel.com> <7b432da0-d51d-f7da-2679-cfc67b20b47d@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR0301CA0095.eurprd03.prod.outlook.com (2603:10a6:6:30::42) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0301CA0095.eurprd03.prod.outlook.com (2603:10a6:6:30::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25 via Frontend Transport; Mon, 11 Oct 2021 11:41:34 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fa31d470-07b9-4e3d-d3d6-08d98cac147f X-MS-TrafficTypeDiagnostic: PH0PR11MB5079: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Eag3O7YefNTSMVJKoChBfgzZu2QdiSYQatVHvwSuxzbKAFVR+8Yj5CYj4HkzhtNHwAyBSRGfCBFFELOOclfZnYCq3Q1UCStHbEe5l2uzq4CQV01n+7vyQLYYEvZ8XyajcMwonU3pKsZAu9NeBOFV7zuvyv/GfY4ELnnKohRh2ylSlc+boSzIWFAN8TpdtmaBdaZeVszgR59kgOacOH7dKoXJq3BSRvllHcvUfdRjXHLRGKOUKA3UtsaBcJLAToT5hAstebg5dM+E+RtyHnjbYxes7JuS877+PwwDiiILDYNmQIChhcVlZ0mRyvhix9xPs/+FUbQae7fq5ufRNVHvIJezfO8I1DXeHNYavl7vA6AP/yG0g6gDyMsAoRmkRYKknDNsGJ1DGR3N08whz6sj54kEZMLE72NIfNpkT7O3b/MggqIKAap9D3vrKl6MWKzfphJBDnUCte1Fot1MGjS1aexwEpgqUJfvZ6jlrkSqR2E4I2bFjc1hTMzeBJXHAE3HpIobSgW+p3UFDspWfAiVvb+xXjCcoosNwYmdXt7qHY35oBkwiHW9sKPHrlqwxltdnHkpr6xEHBGTmNbQK68YkSLeiIMV50hWp06hTGdCP/uaDrTJ3Jx2PutXipvFsdKDPBqMQR3T9lsfqqcQSUmKXH0bxcgVJNW06zaL9SK5m3+YxWwYkBPO+IUeY4DoMuLQweAt2uzmnP6pJWIdC1dXdg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(26005)(8936002)(31696002)(5660300002)(956004)(2616005)(2906002)(54906003)(6916009)(16576012)(316002)(4326008)(8676002)(186003)(53546011)(508600001)(6666004)(83380400001)(44832011)(6486002)(107886003)(86362001)(66946007)(66556008)(66476007)(38100700002)(36756003)(31686004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjBmOUZKSFRVYjlGaUNTKzJIUzdicUtJZDYvMitqTks3NGV4NUxubWNJSTEz?= =?utf-8?B?QWhuYkRxSlV1ZEV1Z0tuaENITlQwZUNiempabzdzMFhHYWMxSGU0V1dZN0tO?= =?utf-8?B?UklpekNPcTR4KzM0SnFyRk8ySGY5Ykp4NkZRd3A1YmFiYUd4Z2hveis4ZGFt?= =?utf-8?B?bVVPYytXWCtwbFNtbEZ2NHhGRmM2U0ljOTZkQ1IrTFR1eitvbUpSREZhNnJq?= =?utf-8?B?anRpTWc0N1lrMy9tWVNGbzZ5Mkc4UWE2eEhyeFVlSkRqU2M3VDNHMHREMlR1?= =?utf-8?B?RmpHdldWVXdXMENPeHVqTytFbUFuVUc5TGNUVUhWYUFZcXV4ZndPOTRCdlBW?= =?utf-8?B?d09TZk5ZL2REbzR6eW1nNEVvVTdBK1l3L2VZQkxQTXFsaldJTlM3RU5QOUVW?= =?utf-8?B?R2c2VkQyMWxtK1hWdFphVWhLMS90UzU3cW1TQU9hb0NzNVBsVE9UV0c5cjZQ?= =?utf-8?B?ZGtoMFJnOXhhVzRycEpQUTBINlVjQ0ZPOVBkMno0b21VZEIzZStNZU1RTGQ5?= =?utf-8?B?WWxCMmtuTm13cXVUcE5uWnRYeTVlSXByVzVhd051cnBlZHQrV2hBcUhneFRp?= =?utf-8?B?d3hzQnJ5T0FQMEVxOFp2dkV0bDV6eGloUnJEZXBqYWZOcHdYTWowTUtWS2tm?= =?utf-8?B?VnQ4NWcrWVBoVW5RWm1ZVGZUaGZ6UzExM1Z2UXRPemsra0orUjJmQVg4Ryt6?= =?utf-8?B?bGc0Y0V0M1orRUZnM080WDlOcERlVjBKcXkxQ2dLY21hZm8xWFZzZytPODlj?= =?utf-8?B?MVAxVlo5czlicitzTHVjanRsSWFKZE5MckJLOFN1emhMb1dVSFVwVE9VMThR?= =?utf-8?B?L0VqYXl4dllLOEg4Q3UzWnVGVWUxWk9WRFVteU1WQ0pjT00wdWVDZFdqYkd4?= =?utf-8?B?b2NoQ0toRlhsTEI5VlJiMzhwWmpLNE1WY2paaHdzZjU5K0Y3R29YaDUzT3pr?= =?utf-8?B?ZUZWenl3U0crY2RhaUpHU2tnY09IZ0RMTkZibXFhOTdYRFR1cXNBbmFtVWlG?= =?utf-8?B?RWJoazNaeXNzRVNxa0RTMytWbEVqQS9aVE1kRjFDL0F3YWFDQldYdW9zRnFY?= =?utf-8?B?QTZNL0FiajQzM1FCVlR5VFlseTRVM2NteXVtOVJINmNTS3Fva2pGOVdZQTFs?= =?utf-8?B?Q2owdS9rakFyZm1PcGNNYTBraXJJdmpXR0EzNThhb1N0ZWRubklXNlVnT1VC?= =?utf-8?B?N3RqVkhtMUJLamJnMldhbDBFYXdRVG4wY3JSM256Mi9hRWQ4Y0RVMkZ2OGE1?= =?utf-8?B?Znkrd3hDNkE3eldMeDJuR0laSUhjYkVxNWRvejgvY0l6Z1VWb2dIN3dEN2xM?= =?utf-8?B?Q2Z5UWhMUU8ydXFhaU9rZU1BLzZ3NzZzMkNUZHpZNGdmREFvdWJJbEhDTUJo?= =?utf-8?B?MVBLbkQ0NUJIQllJTFVFOHl5cWxYL2Jub05YbVV6dlJJVHZQM1R4MUk0WDB3?= =?utf-8?B?cnE5ZjN4eUQxb3lPNGZBZEJoRVFZMGxKTm9QQWtaUzJrSzRZbnpnZTFxQnJM?= =?utf-8?B?RjR4MEpZZHhCV0RHdjlFekNlNXN4bm1PeUVsVFQxZnJBVFBCQzZmbWErcEl3?= =?utf-8?B?UUF0ZUNxMmNENVNGUms4YTd4dGZkdTRybzJDL3lGZHQyQmZ5Wm1uUTIxZGxM?= =?utf-8?B?bTMrUFhJNmU0M0NqbUgrN2pKMnVvWkh5WmJUSjNNVWUwOVFVVWI3UjFnWkZJ?= =?utf-8?B?b0EvcC9UdkRRdnR3cmtKZVZxN2ZLdDB2dldhLzBmUm1lb3pBVHdQTGVLa21U?= =?utf-8?Q?9n3bMIGCntAq+6vILkvtFi2ANJrYRORSG9iDbDR?= X-MS-Exchange-CrossTenant-Network-Message-Id: fa31d470-07b9-4e3d-d3d6-08d98cac147f X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 11:41:35.8011 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: huljSfzkiVoOGxwMsybkJIdr/eAIbLIdY1qO2Ml8XaHjB6vSv1Ab19pAFo4whfVapzsu0OqHQQqJpKqK+W9pZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5079 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v5 1/3] net/thunderx: enable build only on 64-bit Linux X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/10/2021 10:38 AM, Jerin Jacob wrote: > On Fri, Oct 8, 2021 at 9:00 PM Ferruh Yigit wrote: >> >> On 10/4/2021 1:54 PM, Pavan Nikhilesh Bhagavatula wrote: >>>> On 10/4/2021 1:01 PM, Pavan Nikhilesh Bhagavatula wrote: >>>>>> On 10/4/2021 12:34 PM, Pavan Nikhilesh Bhagavatula wrote: >>>>>>>> On 10/4/2021 11:02 AM, Pavan Nikhilesh Bhagavatula wrote: >>>>>>>>>> On 10/4/2021 6:56 AM, pbhagavatula@marvell.com wrote: >>>>>>>>>>> From: Pavan Nikhilesh >>>>>>>>>>> >>>>>>>>>>> Due to Linux kernel AF(Admin function) driver dependency, >>>> only >>>>>>>>>> enable >>>>>>>>>>> build for 64-bit Linux. >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Hi Pavan, >>>>>>>>>> >>>>>>>>>> Isn't it possible to provide a commit log in the kernel side etc, >>>> that >>>>>> let >>>>>>>>>> others to verify why only 64 bit is required, or if someone want >>>> to >>>>>>>>>> support >>>>>>>>>> 32bit that may help them to investigate the source of the >>>>>> restriction. >>>>>>>>> >>>>>>>>> Arch 32 support is not implemented on ThunderX, so 32bit will >>>> not >>>>>>>> run. >>>>>>>>> >>>>>>>> >>>>>>>> I see, is following correct: >>>>>>>> All thunderx, octeonx & octeontx2 only supports VF in the DPDK, >>>>>> and PF >>>>>>>> is >>>>>>>> supported by Linux kernel driver. And Linux kernel driver doesn't >>>>>>>> support arch32. >>>>>>> >>>>>>> AF != PF, AF is something that manages all the shared resources >>>>>> between PF/VF. >>>>>>> >>>>>> >>>>>> I see, I though AF is part of PF functionality. Are there two different >>>>>> kernel >>>>>> modules for PF and AF? >>>>>> >>>>>> So can DPDK driver drive PF? In a way, PF by DPDK, VF by DPDK, AF >>>> by >>>>>> Linux >>>>>> kernel driver. >>>>> >>>>> Yup that’s correct. >>>>> >>>>>> >>>>>>>> >>>>>>>> Is something changed in kernel driver side to drop the 32bit >>>> support? >>>>>>>> If it was not supported at all, what is the motivation to disable the >>>>>> DPDK >>>>>>>> drivers now? >>>>>>>> >>>>>>> >>>>>>> It was never supported to begin with, motivation is that build will >>>> fail if >>>>>> we try to >>>>>>> compile with 32b. >>>>>>> >>>>>> >>>>>> If there is no plan to support 32bit in the kernel side, that is >>>> reasonable >>>>>> to >>>>>> disable 32bit build, please provide above details in the commit log. >>>>>> >>>>>> And after above said, how much maintenance cost to support 32bit, >>>> if >>>>>> the build >>>>>> error is on the logging format "%lx" etc .. (as we mostly have 32bit >>>> build >>>>>> errors), it is better to fix them using 'PRIx64' which is more proper >>>> way >>>>>> anyway. If there is more logical issue with 32bit pointers, I agree with >>>>>> you to >>>>>> disable it. >>>>>> Can you please provided the build error in the commit log as record? >>>>>> >>>>> >>>>> Apologies, I meant that all the functions that don’t fall under 64b are >>>> stubbed out >>>>> so the driver wouldn’t work. >>>>> >>>> >>>> so is there build error or not? >>>> >>> >>> No build error. >>> >> >> Just trying to clarify, >> >> Linux kernel AF kernel driver only build for 64-bit Linux. >> And mentioned DPDK drivers have a dependency to this kernel module. >> >> But DPDK drivers are userspace application, can't 32-bit application >> run on 64-bit Linux? >> >> Can you please clarify what exactly is not supported? > > > armv8 specification has two operating modes, > > 1) AArch32 mode, where a 32 bit application can run on armv8 > 2) AArch64 mode, where it is native 64bit support. > > In Thunderx and Octeon families, AArch32 mode is not implemented to save > the power and RTL cost. So it can never use AArch32 32bit mode. > > There was an attempt to emulate 32bit mode in 64 bit like X32_ABI, it > is called IPL32 in arm64, that never became mainstream. So 32bit application > can not run on ThunderX/Octeontx so we would like to remove building this option > to avoid removing the cost of maintaining it. > > Thanks for the clarification, so main motivation is not the AF driver dependency? Can you please put above description to the commit log in next version? Thanks, ferruh > >> >> >>>>>>>>>> >>>>>>>>>>> Signed-off-by: Pavan Nikhilesh >>>>>>>>>>> Acked-by: Jerin Jacob >>>>>>>>>>> --- >>>>>>>>>>> v5 Changes >>>>>>>>>>> - s/fuction/function. >>>>>>>>>>> >>>>>>>>>>> v4 Changes: >>>>>>>>>>> - Update commit message regarding dependency on AF >>>> driver. >>>>>>>>>>> >>>>>>>>>>> drivers/net/thunderx/meson.build | 4 ++-- >>>>>>>>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>>>>>>>> >>>>>>>>>>> diff --git a/drivers/net/thunderx/meson.build >>>>>>>>>> b/drivers/net/thunderx/meson.build >>>>>>>>>>> index 4bbcea7f93..da665bd76f 100644 >>>>>>>>>>> --- a/drivers/net/thunderx/meson.build >>>>>>>>>>> +++ b/drivers/net/thunderx/meson.build >>>>>>>>>>> @@ -1,9 +1,9 @@ >>>>>>>>>>> # SPDX-License-Identifier: BSD-3-Clause >>>>>>>>>>> # Copyright(c) 2017 Cavium, Inc >>>>>>>>>>> >>>>>>>>>>> -if is_windows >>>>>>>>>>> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64') >>>>>>>>>>> build = false >>>>>>>>>>> - reason = 'not supported on Windows' >>>>>>>>>>> + reason = 'only supported on 64-bit Linux' >>>>>>>>>>> subdir_done() >>>>>>>>>>> endif >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> 2.17.1 >>>>>>>>>>> >>>>>>>>> >>>>>>> >>>>> >>> >>