From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10073.outbound.protection.outlook.com [40.107.1.73]) by dpdk.org (Postfix) with ESMTP id F0E8FA488 for ; Thu, 1 Feb 2018 15:13:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Ps755CGiQLqZTvY92uqtTUyuE/OPjWwKI1Hvy1wcydQ=; b=rytf8myuSzcXk0nN0YRmF3xflhQ4fpSWRPdK7wHhdnLx5F5pAVlYRSjsK6DF+3ykiQ+XJmZZ6fqYWiIn2zvge6sZLek4JgtJRqZMzUxOD16miWTEGEMjGcaH/HLdVpqVoAKRj08gTW6furooAWZIMBBE6bJskvN7RkW1IO8IhNk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; Received: from [10.232.14.39] (192.88.169.1) by DB6PR0401MB2455.eurprd04.prod.outlook.com (2603:10a6:4:35::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Thu, 1 Feb 2018 14:13:33 +0000 To: Bruce Richardson Cc: dev@dpdk.org, ferruh.yigit@intel.com, thomas@monjalon.net, matan@mellanox.com, konstantin.ananyev@intel.com, hemant.agrawal@nxp.com References: <20180201124439.21633-1-shreyansh.jain@nxp.com> <20180201124823.22621-1-shreyansh.jain@nxp.com> <20180201132724.GB13884@bricha3-MOBL3.ger.corp.intel.com> From: Shreyansh Jain Message-ID: <78379784-5872-b051-bede-27ee4a8c0845@nxp.com> Date: Thu, 1 Feb 2018 19:58:32 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180201132724.GB13884@bricha3-MOBL3.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.88.169.1] X-ClientProxiedBy: BMXPR01CA0045.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:c::31) To DB6PR0401MB2455.eurprd04.prod.outlook.com (2603:10a6:4:35::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 0703d84f-b0d6-4955-6893-08d5697dfba4 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:DB6PR0401MB2455; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0401MB2455; 3:+9re4EnjmbneXRClT5EvgW4aqCJW+1D/2tWJoFGgILsMCPlR4FK6lBs5nWwNVlw3yS8nspf8SIga2y5PfZ2Ts1xtj/x7aYO3geF63T3UYPb2clrrH9UlonCqxyzMyNpBnoBaHJbV64lMb2xV2EUBENywBBlFB8RWhYAYfwQUEzRHCmSgg74huPUMOI9fdr8eIj+FFUIHSsPm5KcDvoPKRdcmT92L3CLBlV0iQrs5iecgXgCPPH8gozs1XIvAleMC; 25:gNOYNXg6xhIGxNglh73XAU6S0YFn9FvIkHgx3gcJWSmWLyovi3ngNQuvgp0kQViXZ/NqKYbFHKdU5idSh500u0pCYzR0k8V9N4RNpdFBkmwktVpwv9g+1OCivopf5WPeBryksYC2VwIF1c9IZKpCzgXOxsU8/AcR8RwhvdLCmDZ4//zdRInQFVB6R1w4rAYC+vrPhtGI1KI/fgPCD36YIJCt8NEpOXo/agg+gXBADO54p4ct/3hRt0LQehM1XBNVQahgk5Y1eCERWSwiDO7HLhBrVwTWyOnrOGCPT1hFKlcq5d/MgFz/cLXHmb6u+tI/9XVb9Z8h3bOFGpEv3mGFfg==; 31:3aXs15lzOVi/BZ23V+aj+ts5CfgyEATmwWAu9yzDZnNus5IzWEx0Ju01lIiX5E1wfEN6D9N8nfdR0On6Yg5NQWW0zRWKOXykAAtepu+8oYFwiA7dCIohWWr8DLAAQzw4WthCB1A0sUgJYYlbkC25Hg7Mfr82Xd0solN2nydaXFkZ4TLb8vmyNStGMwtmZpTMKB/NAVo6jSsqlLXP+HSellDm0YGy81NgadcyrYrsEFU= X-MS-TrafficTypeDiagnostic: DB6PR0401MB2455: X-Microsoft-Exchange-Diagnostics: 1; DB6PR0401MB2455; 20:qYVv/w29KxRwsw4blR8QcXWF/4z2ArM3j3x4yl6dB9zonTmtxrTusVQ3spJ8P8l/6+NWHzFWLFrCafiLzqGVsOJAEAYDs8LISWyvQJ968S3sh4VfINCF+rva/LpNu9Buma41okDZq1pcJtusd3kRJmpXIZvBk69+tDw2LlNJDh9aiF9iH8842Kuk1m07E75yiV2a9sEmUbb1k88Zad10rkfuaL25jeSJeqLqx04CQy0OefPkTE1eQV71pUBqnj+oGKU6fwf0JHJUonZPyIAv3KSc8xzis49+tmt8rk6c/mTBXsTr9ftRoVWOPf4i5LWE7EOls1DoNxX9rseIi4aTHq1LHXC6wQ69b5Lr18p8IQY6IMLwAlmPAsp9XraJJZlr8xfimFOkgwhUl0Dz7NxGggD4H7NeiFSS8KI3BEd3r3GRRculz6EVzV39UFIgM7ree6BnjMLWDxj1JINgqNFjcRWMub+x1P2WgyeEXeL35tEuQD9mRnle9rfvaya2Z2e6; 4:e8Np42fWaO8qoo3LSa81ea1YEoScv45NH+wLoRMIWhShPeUNjg+nLFqpqnyxQRMyrixRf1H05jf8QezRPSdWjXZ5bOC4eiFmK6VjLFPUOvIXwu6QxNOIBVg0FphtnVvznSeN3Zzzx4vEVQGEuTy4kWsP6E9AxiVIX4iUdfnvUQUS2kSQUoBZTVDNzdTujlgZCpjpMIbz6GpurwfKKMT76eidNl5wWjwm4rVtGzx70iNQKTPPPJDVkDWoQKqvueeqGfYnEAN+Kc0g1X7wrHqe7lBlAVvii/OAiQwplgAD1bIV/Do6T7Z1qu8+DP+EU/SIhu8c90lzuWkXEUAaTlMJsIAK6ANFs3GHtHtuZNQp8GY= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231101)(2400082)(944501161)(6055026)(6041288)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:DB6PR0401MB2455; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0401MB2455; X-Forefront-PRVS: 0570F1F193 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(346002)(366004)(396003)(39380400002)(39860400002)(376002)(199004)(189003)(81156014)(2486003)(25786009)(86362001)(6306002)(68736007)(230700001)(2906002)(31696002)(81166006)(6116002)(3846002)(59450400001)(8936002)(23676004)(36756003)(386003)(229853002)(8676002)(1720100001)(106356001)(305945005)(966005)(65826007)(52116002)(53376002)(478600001)(7736002)(6246003)(31686004)(6486002)(52146003)(4326008)(50466002)(105586002)(53936002)(16576012)(5660300001)(67846002)(83506002)(66066001)(47776003)(97736004)(26005)(64126003)(2950100002)(65956001)(6916009)(77096007)(58126008)(16526019)(65806001)(316002)(76176011); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0401MB2455; H:[10.232.14.39]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjZQUjA0MDFNQjI0NTU7MjM6enVvaDBDcWF1NW90MUZaZ2JRTUFvdXBI?= =?utf-8?B?T0s5VllEUnFMR2VjNStzdW1rWkxhU0UrL01tcVBUZE1NYmJnUmlSdlp3T1FH?= =?utf-8?B?bHNVMm9EYlpKU0h4RzBwZ2Z2SU5BRWNmZW1SS1Y1OVZuVnR3ZDhPUDRFUURO?= =?utf-8?B?ejBsVEs4UmNwaGQ1NTIxNFRMOG0rOE5XYU85bjh3VzBsUW9XMmc5QTR3b2ZR?= =?utf-8?B?U2F1VytlaVRweE5nRGZyYVBjblE5RFpEOFJvcnlrYlZld3Y2Y2I1UmZvMGRC?= =?utf-8?B?aldiV2swWE5QczZrQ2Z5aXZ6a1ZYY3pnSXpERmJKOG91T3JNM2s2bitwbTJm?= =?utf-8?B?RHFVdUhrMVlXeEdSMGZHUzBxc2JvQUlBT0NINkNOc0pUcW5yQmlidkdzdGhk?= =?utf-8?B?d1ZxZjI2MFBucWE0QzJQZC9jYTRleEp0ZEVDaFRMSmVaTGFzNDJHdkpSU1lx?= =?utf-8?B?T05yQ3VYMzhnTG9lUTY5ZEdETk52bTNqUVFZODkzd2NINGtGbFZvbzd3RzhJ?= =?utf-8?B?N1diUUErSmd3ZWRjZVppUjZBdzhWVlI4T1pNSUZybTJhRGgwRWhqUHgvRXVu?= =?utf-8?B?ZDUvUWJIVGVqbTRYNDlVaUJBU2w1MTBhRXZheDdWTEoyVlF6U2cwdnkyN2gx?= =?utf-8?B?K3o3dHF1OWVaMmlCendvVzQrMS9UQ0Z1OTBEV2dSV0xaR0lmUkdwZGhyQm1P?= =?utf-8?B?b1JLTkFRSlRNV0J2bmtGY1JKTjNuRlkzN3E3TWRJdmRxZTJWbGc1QjVlUFIy?= =?utf-8?B?MSs2V0p0bTIyelhRS3FkKzhCRFZKNko5UGJJSU5BZzBTRVNHeFNLTHhneFdy?= =?utf-8?B?b0VLL1QzWC93U0dxemtPMDZNRndQd2JNd3RKSHd3TGdkTURhNmMrOGozb3pT?= =?utf-8?B?c3psbnExRlNFOHBTNEJxcmp1OTVvMGtZOERyVitCS3lkbFB0RXRXSjdPS2dY?= =?utf-8?B?bmx4WlNLMmhnQmFFbmVwMGx1K3lSY2pGK2tYSk5HTzNIUFlsd1BYVVVJMG5E?= =?utf-8?B?TEN2bDcrY2JINjMzZnpEZCtaZkdJNDYrWW1HcCtaVzh3ZzJ6YnlZS0xPVkRk?= =?utf-8?B?SlFLbzFnNnBFeVhsUVhCSENtUnlnZUJiRDZjU0hBb2JnMUdJVk8rKzhOYkxq?= =?utf-8?B?OUpxOHZDaEtRQjh1bGE4R3cyN3AyRnJYL0hvd2c5UjUwZGVBY1QweVlyWThR?= =?utf-8?B?eWx0RFBSVVdpVlJyZkVJdVlqamJmbkRhYmEzT3kzTVJDQXMzVzNyZmtEMzAv?= =?utf-8?B?UTlyak0rU1ZrblhzWVJXb29kNEtHZFUzWFlTYXhod0Fpb2tkbmNiT1NKZ1lW?= =?utf-8?B?TjhJY3QyQTRWUkFZNXkrTkRHUmh0VnlsRnkyREhWQVVwWDhCRm4xZEc5VXRj?= =?utf-8?B?K1h6YVNqejBFRUVGREM1VEhmazByd1RiOWJ4YmdEQStrcmtDeWthei9Rc3Vv?= =?utf-8?B?RU43azg2d1JsM3A4OWt0NnkxMmtJcnBBZ0FqNHVKYXJwUmhhcDZFd0p5VUVQ?= =?utf-8?B?YzBEZXNJWFBVV1RvcDc5Z2xDTzdrVXdTRWlzdFk1YzI0NDJ4OUdoNjZyQ0k1?= =?utf-8?B?K2VEMlZ3ckZwZGQxOWtJcUc4US9tU3hSUlY3eTIvSUVVOFlUYlZtLzh3OWpB?= =?utf-8?B?QnM4TzlDazEvMnlqNUdzRlN4aHEyWnNvN01sTzUvVDA2VVROeDMra0FSdzl6?= =?utf-8?B?T2NTU25vR3VJTnpJRFJpTFQ0Q2RaQmpOY3pOV0tjRXV1dXU1YVVQYU1sb09m?= =?utf-8?B?TG0zNlZTRWM2THozS3VvQzIzdjhYSDJRZk5hMVkzWHhWM1FTbC9SN2I5c3U5?= =?utf-8?B?RWVRcmRwckJOU2laWUxrWGgxcFBBckd6TGIxSmdxVUdGL25SSlZaM0luQndV?= =?utf-8?B?OGdud3BjVmNuYXpZN3Q4MUJ6OHVqc2hPdVFIU0VZVTNaOFVvY1lFS3JxNWFx?= =?utf-8?B?VFFkd05xM2V4OHc9PQ==?= X-Microsoft-Exchange-Diagnostics: 1; DB6PR0401MB2455; 6:lCJc3D8gwQBQZHjwQujlv/nBT0K4GmvO9hg9b9TcYIegN599pZn+Lo1anXHZDzFh9RYQ8mUODIQ4JLxSr9Ho3qkz76miqDM/n37cHSmVQeUVRghe2J7WbL62+Hk5heoAIBz8ygfkJV60f+ceDVQHkJz06c6cnzC1X3Js1MxhLZYWqUIdAZ4XUaDj3dLq5onn0mc9E8U2gqYyVbqXlBf/jAaT2BAhu2aB1DR8mO3qcqbTnKclZ5OCjc4gQMrh2M3AgTbNucD+sFJd/0+asSzAjJ/gjr+1U2Lp10JijcRun+XgrZBoj5u9qNWCvAFanO20ggIoVklzLxuZw0ibXs2wkA9p9UxXh4ez8PqS26phvb8=; 5:8QhMO5thQvhJ4x8PkvPDxTzc6+3auYDYI+/HD+1OZFB3Vj6CBKcLB6ETGnf0nu1XnXye6PZ0v8zzr0KoRzHohVZ762Mof0KIz+YWdaD9vMkUoumgib2g0MVHMkro/bknkWPo4aL5CLuofYywCnKOeHoGzshUrlpoPHb6JcTvSC0=; 24:OEbpXx/dCVHpNWnK+HrqYR2IIpqrK/OhTgjqA1dD2DfbMYFv3cWi1zH5jAi+nYpMA8fOdgm1aFYBFoWeVsKA7E4o+dkw7qVT08XlqZyTLMU=; 7:j1956rrYuu6r9vIWAc6h3MvA3CVEXILmv7lczaDgDVqC/9CyZg/H9UqdWyqJlLkn2Iuk6WKFkX4hMONLD+jisxSdgMFlw2BZIUZhXisYqKPxr7dRHt80rzDCpB5/N2mX0+kmgJ2BJHCiuJiJk4+RkVtyCBn5LbKz4XBtucOIywMd3Z0A4r04VXphnlxDOglGiSWVDzwydk5QTCK2J+s/tpbUuC1XplvUx/C84ocOT5Ym78vFPfsVrgiGjKQEP7mw SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2018 14:13:33.9446 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0703d84f-b0d6-4955-6893-08d5697dfba4 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2455 Subject: Re: [dpdk-dev] [PATCH v2] doc: add preferred burst size support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Feb 2018 14:13:37 -0000 On Thursday 01 February 2018 06:57 PM, Bruce Richardson wrote: > On Thu, Feb 01, 2018 at 06:18:23PM +0530, Shreyansh Jain wrote: >> rte_eth_rx_burst(..,nb_pkts) function has semantic that if return value >> is smaller than requested, application can consider it end of packet >> stream. Some hardware can only support smaller burst sizes which need >> to be advertised. Similar is the case for Tx burst. >> >> This patch adds deprecation notice for rte_eth_dev_info structure as >> two new members, for preferred Rx and Tx burst size would be added - >> impacting the size of the structure. >> >> Signed-off-by: Shreyansh Jain >> --- >> * Refer: http://dpdk.org/dev/patchwork/patch/32112 for context >> >> v2: >> - fix spelling error in deprecation notice >> >> doc/guides/rel_notes/deprecation.rst | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst >> index d59ad5988..fdc7656fa 100644 >> --- a/doc/guides/rel_notes/deprecation.rst >> +++ b/doc/guides/rel_notes/deprecation.rst >> @@ -59,3 +59,11 @@ Deprecation Notices >> be added between the producer and consumer structures. The size of the >> structure and the offset of the fields will remain the same on >> platforms with 64B cache line, but will change on other platforms. >> + >> +* ethdev: Currently, if the rte_eth_rx_burst() function returns a value less >> + than *nb_pkts*, the application will assume that no more packets are present. >> + Some of the hw queue based hardware can only support smaller burst for RX >> + and TX and thus break the expectation of the rx_burst API. Similar is the >> + case for TX burst. ``rte_eth_dev_info`` will be added with two new >> + parameters, ``uint16_t pref_rx_burst`` and ``uint16_t pref_tx_burst``, >> + for preferred RX and TX burst sizes, respectively. >> -- >> 2.14.1 >> > > LTGM as far as it goes, but following discussion on this patch, > http://dpdk.org/ml/archives/dev/2018-January/089585.html > I think we might also want to add in parameters for "pref_tx_ring_sz" > and "pref_rx_ring_sz" too. While it is the case that, once the structure > is changed, we can make multiple additional changes, I think it might be > worth mentioning as many as we can for completeness. > > Another point to consider, is whether we might want to add in a > sub-structure for "preferred_settings" to hold all these, rather than > just adding them as new fields. It might help with making names more > readable (though also longer). > > struct { > uint16_t rx_burst; > uint16_t tx_burst; > uint16_t rx_ring_sz; > uint16_t tx_ring_sz; > } preferred_settings; This, and the point above that we can make multiple additional changes, is definitely a good idea. Though, 'preferred_setting' is long and has chances of spell mistakes in first go - what about just 'pref' or, 'pref_size' if only 4 mentioned above are part of this. For now I saw need for burst size because I hit that case. Ring size looks logical to me. We can have a look if more such toggles are required. > > In any case, for this or subsequent versions: > > Acked-by: Bruce Richardson > > /Bruce > Thanks.