From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id DF7D2A0096 for ; Thu, 6 Jun 2019 17:55:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A99CE5424; Thu, 6 Jun 2019 17:55:18 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id C559128F3; Thu, 6 Jun 2019 17:55:16 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1546A3082A9B; Thu, 6 Jun 2019 15:55:16 +0000 (UTC) Received: from localhost.localdomain (unknown [10.18.25.8]) by smtp.corp.redhat.com (Postfix) with ESMTP id F36465F7D8; Thu, 6 Jun 2019 15:55:12 +0000 (UTC) To: jerinj@marvell.com, dev@dpdk.org Cc: thomas@monjalon.net, gavin.hu@arm.com, honnappa.nagarahalli@arm.com, aconole@redhat.com, stable@dpdk.org References: <20190606145054.39995-1-jerinj@marvell.com> From: Michael Santana Francisco Organization: Red Hat Message-ID: <78430567-3032-8a9c-ee53-d721ca7803cb@redhat.com> Date: Thu, 6 Jun 2019 11:55:12 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190606145054.39995-1-jerinj@marvell.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Thu, 06 Jun 2019 15:55:16 +0000 (UTC) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] acl: fix build issue with some arm64 compiler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: msantana@redhat.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/6/19 10:50 AM, jerinj@marvell.com wrote: > From: Jerin Jacob > > Some compilers reporting the following error, though the existing > code doesn't have any uninitialized variable case. > Just to make compiler happy, initialize the int32x4_t variable > one shot in C language. > > ../lib/librte_acl/acl_run_neon.h: In function 'search_neon_4' > ../lib/librte_acl/acl_run_neon.h:230:12: error: 'input' may be > used uninitialized in this function [-Werror=maybe-uninitialized] > int32x4_t input; > > Fixes: 34fa6c27c156 ("acl: add NEON optimization for ARMv8") > Cc: stable@dpdk.org > > Signed-off-by: Jerin Jacob > --- > lib/librte_acl/acl_run_neon.h | 29 ++++++++++++----------------- > 1 file changed, 12 insertions(+), 17 deletions(-) > > diff --git a/lib/librte_acl/acl_run_neon.h b/lib/librte_acl/acl_run_neon.h > index 01b9766d8..dc9e9efe9 100644 > --- a/lib/librte_acl/acl_run_neon.h > +++ b/lib/librte_acl/acl_run_neon.h > @@ -165,7 +165,6 @@ search_neon_8(const struct rte_acl_ctx *ctx, const uint8_t **data, > uint64_t index_array[8]; > struct completion cmplt[8]; > struct parms parms[8]; > - int32x4_t input0, input1; > > acl_set_flow(&flows, cmplt, RTE_DIM(cmplt), data, results, > total_packets, categories, ctx->trans_table); > @@ -181,17 +180,14 @@ search_neon_8(const struct rte_acl_ctx *ctx, const uint8_t **data, > > while (flows.started > 0) { > /* Gather 4 bytes of input data for each stream. */ > - input0 = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 0), input0, 0); > - input1 = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 4), input1, 0); > - > - input0 = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 1), input0, 1); > - input1 = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 5), input1, 1); > - > - input0 = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 2), input0, 2); > - input1 = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 6), input1, 2); > - > - input0 = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 3), input0, 3); > - input1 = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 7), input1, 3); > + int32x4_t input0 = {GET_NEXT_4BYTES(parms, 0), > + GET_NEXT_4BYTES(parms, 1), > + GET_NEXT_4BYTES(parms, 2), > + GET_NEXT_4BYTES(parms, 3)}; > + int32x4_t input1 = {GET_NEXT_4BYTES(parms, 4), > + GET_NEXT_4BYTES(parms, 5), > + GET_NEXT_4BYTES(parms, 6), > + GET_NEXT_4BYTES(parms, 7)}; > > /* Process the 4 bytes of input on each stream. */ > > @@ -227,7 +223,6 @@ search_neon_4(const struct rte_acl_ctx *ctx, const uint8_t **data, > uint64_t index_array[4]; > struct completion cmplt[4]; > struct parms parms[4]; > - int32x4_t input; > > acl_set_flow(&flows, cmplt, RTE_DIM(cmplt), data, results, > total_packets, categories, ctx->trans_table); > @@ -242,10 +237,10 @@ search_neon_4(const struct rte_acl_ctx *ctx, const uint8_t **data, > > while (flows.started > 0) { > /* Gather 4 bytes of input data for each stream. */ > - input = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 0), input, 0); > - input = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 1), input, 1); > - input = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 2), input, 2); > - input = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 3), input, 3); > + int32x4_t input = {GET_NEXT_4BYTES(parms, 0), > + GET_NEXT_4BYTES(parms, 1), > + GET_NEXT_4BYTES(parms, 2), > + GET_NEXT_4BYTES(parms, 3)}; > > /* Process the 4 bytes of input on each stream. */ > input = transition4(input, flows.trans, index_array); Fixed on travis: https://travis-ci.com/Maickii/dpdk-2/builds/114612090 Acked-by: Michael Santana