From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6AC742C4C; Wed, 7 Jun 2023 11:12:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F68E40A84; Wed, 7 Jun 2023 11:12:53 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id D713540698 for ; Wed, 7 Jun 2023 11:12:51 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4389B5C01F0; Wed, 7 Jun 2023 05:12:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 07 Jun 2023 05:12:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1686129170; x=1686215570; bh=sRynqvbdVC0WhNVDIBT+5cbFA8POeD2WrY1 Dl52wrYI=; b=EBwbg+/RZx4xrO/vJaktCre8s19dpOXQ6LLb2yFmKu2KdKgQw6s LltzCvgoqTpDAtF0+7TrwJeJI9KvoqznaRWSn0Kc3U5f48oewtMKPy8wVXaZA5oR aSQzZPTwyOlWF0Co+VNDqcmS3K6TvJNNzxEtMQA9MkNxWJxJUZbFQbZ25j3tKzFG 0gAGlbp3GCj4Zu2uZo5gP5AZGPqK+Oz36tf/fh3Qlg2ySxomQyu8sS4xO99gRdUX as3AIN5cY7Jk9k1pdJDt7cAGWYKvvyf8Y/e3NAcI0H1u7gBvvjWXzW6NdcYtN5XJ c23lXSXdPec4c4cNBmjMUZZDpWKb/bX1ybw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1686129170; x=1686215570; bh=sRynqvbdVC0WhNVDIBT+5cbFA8POeD2WrY1 Dl52wrYI=; b=iZHWzcBp1rb+x6KF4zEpP3v21icn7/g/XAkxDNoDG6cqQ1CzaBv 7kGqct7EwfHSPX1bSRUX8EIN6S5x9Ejg8y3nUWzDa4c+JUNoz7jEvLnIS2Lc5XTe rdVDXsOWDdoU6BoJGwt/tY2CBd6k9U69E100MqtVoMwNdg5Un60v+kj0UVavlC+1 9zafut7cZ5gueJGlki8vLPrfzWzWoLNdx1b3pv0wA9NjNrJ68Cg1gnhpRDTTBRtL vtoRua8Hft3tMmVGvSF4Y3IAQRxL08AWbIsYKuLRJsY0pO++fya1WOcLQoe/Cmra eajXw5EK3e0PQkGVpORmEQkEK/pLKx41cfw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedtgedgudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtudenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeefhfejleeuvdevtddutdeutdevhfeijeethfffueejhfetuddu vedtkedtieekffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 7 Jun 2023 05:12:48 -0400 (EDT) From: Thomas Monjalon To: Morten =?ISO-8859-1?Q?Br=F8rup?= Cc: dev@dpdk.org, olivier.matz@6wind.com, andrew.rybchenko@oktetlabs.ru, bruce.richardson@intel.com, roretzla@linux.microsoft.com Subject: Re: [PATCH v4] mempool: optimize get objects with constant n Date: Wed, 07 Jun 2023 11:12:46 +0200 Message-ID: <7845046.qOBuL9xsDt@thomas> In-Reply-To: <20230418200924.13290-1-mb@smartsharesystems.com> References: <20230411064845.37713-1-mb@smartsharesystems.com> <20230418200924.13290-1-mb@smartsharesystems.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 18/04/2023 22:09, Morten Br=F8rup: > When getting objects from the mempool, the number of objects to get is > often constant at build time. >=20 > This patch adds another code path for this case, so the compiler can > optimize more, e.g. unroll the copy loop when the entire request is > satisfied from the cache. >=20 > On an Intel(R) Xeon(R) E5-2620 v4 CPU, and compiled with gcc 9.4.0, > mempool_perf_test with constant n shows an increase in rate_persec by an > average of 17 %, minimum 9.5 %, maximum 24 %. >=20 > The code path where the number of objects to get is unknown at build time > remains essentially unchanged. >=20 > Signed-off-by: Morten Br=F8rup > Acked-by: Bruce Richardson Applied with suggested added comment, thanks.