[PATCH] power: fix a typo in the PM QoS guide

[PATCH] power: fix a typo in the PM QoS guide

[Huisong Li]

The typo in the guide is hard to understand. Necessary to fix it.

Fixes: dd6fd75bf662 ("power: introduce PM QoS API on CPU wide")

Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
 doc/guides/prog_guide/power_man.rst | 2 +-
 lib/power/rte_power_qos.h           | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/guides/prog_guide/power_man.rst b/doc/guides/prog_guide/power_man.rst
index 22e6e4fe1d..024670a9b4 100644
--- a/doc/guides/prog_guide/power_man.rst
+++ b/doc/guides/prog_guide/power_man.rst
@@ -118,7 +118,7 @@ based on this CPU resume latency in their idle task.
 
 The deeper the idle state, the lower the power consumption,
 but the longer the resume time.
-Some services are latency sensitive and very except the low resume time,
+Some services are latency sensitive and request the low resume time,
 like interrupt packet receiving mode.
 
 Applications can set and get the CPU resume latency with
diff --git a/lib/power/rte_power_qos.h b/lib/power/rte_power_qos.h
index 7a8dab9272..a6d3677409 100644
--- a/lib/power/rte_power_qos.h
+++ b/lib/power/rte_power_qos.h
@@ -24,7 +24,7 @@ extern "C" {
  * https://www.kernel.org/doc/html/latest/admin-guide/abi-testing.html?highlight=pm_qos_resume_latency_us#abi-sys-devices-power-pm-qos-resume-latency-us
  *
  * The deeper the idle state, the lower the power consumption, but the
- * longer the resume time. Some service are delay sensitive and very except the
+ * longer the resume time. Some service are delay sensitive and request the
  * low resume time, like interrupt packet receiving mode.
  *
  * In these case, per-CPU PM QoS API can be used to control this CPU's idle
-- 
2.22.0

Re: [PATCH] power: fix a typo in the PM QoS guide

[Thomas Monjalon]

11/11/2024 13:52, Huisong Li:
> -Some services are latency sensitive and very except the low resume time,
> +Some services are latency sensitive and request the low resume time,

I suppose it should be "request a low resume time".

Re: [PATCH] power: fix a typo in the PM QoS guide

[lihuisong (C)]

在 2024/11/11 21:11, Thomas Monjalon 写道:
> 11/11/2024 13:52, Huisong Li:
>> -Some services are latency sensitive and very except the low resume time,
>> +Some services are latency sensitive and request the low resume time,
> I suppose it should be "request a low resume time".
Ack, thanks
>
>
>
> .

[PATCH v2] power: fix a typo in the PM QoS guide

[Huisong Li]

The typo in the guide is hard to understand. Necessary to fix it.

Fixes: dd6fd75bf662 ("power: introduce PM QoS API on CPU wide")

Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
 doc/guides/prog_guide/power_man.rst | 2 +-
 lib/power/rte_power_qos.h           | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/guides/prog_guide/power_man.rst b/doc/guides/prog_guide/power_man.rst
index 22e6e4fe1d..74039e5786 100644
--- a/doc/guides/prog_guide/power_man.rst
+++ b/doc/guides/prog_guide/power_man.rst
@@ -118,7 +118,7 @@ based on this CPU resume latency in their idle task.
 
 The deeper the idle state, the lower the power consumption,
 but the longer the resume time.
-Some services are latency sensitive and very except the low resume time,
+Some services are latency sensitive and request a low resume time,
 like interrupt packet receiving mode.
 
 Applications can set and get the CPU resume latency with
diff --git a/lib/power/rte_power_qos.h b/lib/power/rte_power_qos.h
index 7a8dab9272..ce0c6eda15 100644
--- a/lib/power/rte_power_qos.h
+++ b/lib/power/rte_power_qos.h
@@ -24,7 +24,7 @@ extern "C" {
  * https://www.kernel.org/doc/html/latest/admin-guide/abi-testing.html?highlight=pm_qos_resume_latency_us#abi-sys-devices-power-pm-qos-resume-latency-us
  *
  * The deeper the idle state, the lower the power consumption, but the
- * longer the resume time. Some service are delay sensitive and very except the
+ * longer the resume time. Some service are delay sensitive and request a
  * low resume time, like interrupt packet receiving mode.
  *
  * In these case, per-CPU PM QoS API can be used to control this CPU's idle
-- 
2.22.0

Re: [PATCH v2] power: fix a typo in the PM QoS guide

[Thomas Monjalon]

12/11/2024 09:35, Huisong Li:
> The typo in the guide is hard to understand. Necessary to fix it.
> 
> Fixes: dd6fd75bf662 ("power: introduce PM QoS API on CPU wide")
> 
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> ---
> --- a/doc/guides/prog_guide/power_man.rst
> +++ b/doc/guides/prog_guide/power_man.rst
> -Some services are latency sensitive and very except the low resume time,
> +Some services are latency sensitive and request a low resume time,
>  like interrupt packet receiving mode.
[...]
> --- a/lib/power/rte_power_qos.h
> +++ b/lib/power/rte_power_qos.h
>   * The deeper the idle state, the lower the power consumption, but the
> - * longer the resume time. Some service are delay sensitive and very except the
> + * longer the resume time. Some service are delay sensitive and request a
>   * low resume time, like interrupt packet receiving mode.

Why not the same as above? "Some services are latency sensitive"

[PATCH v3] power: fix a typo in the PM QoS guide

[Huisong Li]

The typo in the guide is hard to understand. Necessary to fix it.

Fixes: dd6fd75bf662 ("power: introduce PM QoS API on CPU wide")

Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
 doc/guides/prog_guide/power_man.rst | 2 +-
 lib/power/rte_power_qos.h           | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/doc/guides/prog_guide/power_man.rst b/doc/guides/prog_guide/power_man.rst
index 22e6e4fe1d..74039e5786 100644
--- a/doc/guides/prog_guide/power_man.rst
+++ b/doc/guides/prog_guide/power_man.rst
@@ -118,7 +118,7 @@ based on this CPU resume latency in their idle task.
 
 The deeper the idle state, the lower the power consumption,
 but the longer the resume time.
-Some services are latency sensitive and very except the low resume time,
+Some services are latency sensitive and request a low resume time,
 like interrupt packet receiving mode.
 
 Applications can set and get the CPU resume latency with
diff --git a/lib/power/rte_power_qos.h b/lib/power/rte_power_qos.h
index 7a8dab9272..05a3f51ae2 100644
--- a/lib/power/rte_power_qos.h
+++ b/lib/power/rte_power_qos.h
@@ -24,8 +24,8 @@ extern "C" {
  * https://www.kernel.org/doc/html/latest/admin-guide/abi-testing.html?highlight=pm_qos_resume_latency_us#abi-sys-devices-power-pm-qos-resume-latency-us
  *
  * The deeper the idle state, the lower the power consumption, but the
- * longer the resume time. Some service are delay sensitive and very except the
- * low resume time, like interrupt packet receiving mode.
+ * longer the resume time. Some services are latency sensitive and request
+ * a low resume time, like interrupt packet receiving mode.
  *
  * In these case, per-CPU PM QoS API can be used to control this CPU's idle
  * state selection and limit just enter the shallowest idle state to low the
-- 
2.22.0

Re: [PATCH v2] power: fix a typo in the PM QoS guide

[lihuisong (C)]

在 2024/11/12 20:55, Thomas Monjalon 写道:
> 12/11/2024 09:35, Huisong Li:
>> The typo in the guide is hard to understand. Necessary to fix it.
>>
>> Fixes: dd6fd75bf662 ("power: introduce PM QoS API on CPU wide")
>>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>> ---
>> --- a/doc/guides/prog_guide/power_man.rst
>> +++ b/doc/guides/prog_guide/power_man.rst
>> -Some services are latency sensitive and very except the low resume time,
>> +Some services are latency sensitive and request a low resume time,
>>   like interrupt packet receiving mode.
> [...]
>> --- a/lib/power/rte_power_qos.h
>> +++ b/lib/power/rte_power_qos.h
>>    * The deeper the idle state, the lower the power consumption, but the
>> - * longer the resume time. Some service are delay sensitive and very except the
>> + * longer the resume time. Some service are delay sensitive and request a
>>    * low resume time, like interrupt packet receiving mode.
> Why not the same as above? "Some services are latency sensitive"
will fix it in next version.
>
>
>
>
> .

Re: [PATCH v3] power: fix a typo in the PM QoS guide

[Thomas Monjalon]

13/11/2024 01:59, Huisong Li:
> The typo in the guide is hard to understand. Necessary to fix it.
> 
> Fixes: dd6fd75bf662 ("power: introduce PM QoS API on CPU wide")
> 
> Signed-off-by: Huisong Li <lihuisong@huawei.com>

Applied, thanks.