From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 065371B796 for ; Wed, 7 Feb 2018 08:26:09 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5BF9E210AF; Wed, 7 Feb 2018 02:26:08 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 07 Feb 2018 02:26:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=kVzXKNtEFCRfF6fUrTCWuyvUT4 8z83dE75UwwVPHTRE=; b=S2HwFJVe2aY5VYMTg7KGP7emkNJMFhZVyrJotWJiqL yIsn9XQtuW/NhcBZqriE8/dDjfHYAki0cnV4ihexkGE6oSaBz19kBs7pSLFG8Rs9 egu0ro0Byxy4jeTVewwE4y0bBGnv4rWk3sr5r6xxJ3csZoMJ462rDKSGKhQ5vmnJ o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=kVzXKN tEFCRfF6fUrTCWuyvUT48z83dE75UwwVPHTRE=; b=jwYSSSyB+NhY0XeieW7hvg oGhtK79dNGgg2nbgGrYLJ1qqfkwr9iNu7+FYTFrUYSjt3tDXUIG90OYqUNoIA3Uk mb2PZN1Ez2Oh8WpyrFbCWox8kWiRglH/DSOXZfpvMFPSKG168vbaBDOHsSpCeQao /L0UaK/w+P0M92c7atJV/pNyJyv2NYQDrxVbx7WK0sZwWp7+yhuRJF+cYsM9rQF/ XZkJfEgtBxW2BVqSQRMrKDd6Li20anzN/Yb6cHfoUMkN+8+6UVa6FgDE1BLrUpCE o1CZIqN7gYSXHu2KqNT/mNJM9Ra1I7RPySbwinAnedh0VjOslSWzT7EOb7qQwQKA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0B63C240B6; Wed, 7 Feb 2018 02:26:08 -0500 (EST) From: Thomas Monjalon To: Chao Zhu Cc: 'Gowrishankar' , dev@dpdk.org Date: Wed, 07 Feb 2018 08:26:04 +0100 Message-ID: <7852603.J7xFuoqAEp@xps> In-Reply-To: <000901d39fe1$fcdfcde0$f69f69a0$@linux.vnet.ibm.com> References: <3728847.cnur1V9eyL@xps> <000901d39fe1$fcdfcde0$f69f69a0$@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal/ppc64: revert implement arch-specific TSC freq query X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Feb 2018 07:26:09 -0000 07/02/2018 08:05, Chao Zhu: > The previous patch has some misunderstanding of the the TSC frequency > counting. > I support this. Chao, it is very late in the release cycle. Do you want to take the risk of applying this patch in 18.02-rc4? If you discover a bug in this patch next week, it will be too late for fixing it in 18.02. > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: 2018=E5=B9=B42=E6=9C=881=E6=97=A5 8:30 > > To: Gowrishankar ; Chao Zhu > > > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] eal/ppc64: revert implement arch-specif= ic > TSC > > freq query > >=20 > > 30/01/2018 09:59, Gowrishankar: > > > From: Gowrishankar Muthukrishnan > > > > > > This reverts commit 15692396fd68932b6a81f00f12d4b0da12baa7d3 > > > (eal/ppc64: implement arch-specific TSC freq query). We intended to > > > derive pkt/sec estimation with cpu clock frequency. As timebase > > > register serves the timer purpose, we need to stick with it for > > > calculating pkt/sec, hence reverting the change. > > > > > > Fixes: 15692396fd (eal/ppc64: implement arch-specific TSC freq query) > >=20 > > It is not clear what it is fixing. > >=20 > > Chao, please review. >=20 >=20