* [dpdk-dev] [PATCH 1/2] drivers/net: update icc deprecated parameter
@ 2018-03-12 12:38 Ferruh Yigit
2018-03-12 12:39 ` [dpdk-dev] [PATCH 2/2] drivers/net: remove redundant icc flag Ferruh Yigit
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Ferruh Yigit @ 2018-03-12 12:38 UTC (permalink / raw)
To: Harish Patil, Rasesh Mody, Rahul Lakkireddy, Wenzhuo Lu,
Qi Zhang, Xiao Wang, Beilei Xing, Konstantin Ananyev,
Shahed Shaikh, Andrew Rybchenko, Shrikrishna Khare
Cc: dev, Ferruh Yigit
With icc (ICC) 18.0.1 20171018, -wd usage generates following warning:
icc: command line remark #10010: option '-wd3656' is deprecated and will
be removed in a future release. See '-help deprecated'
"icc -help deprecated" output is:
-wd use -diag-disable
Based on above information "-wd" converted to "-diag-disable"
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
drivers/net/bnx2x/Makefile | 2 +-
drivers/net/cxgbe/Makefile | 2 +-
drivers/net/e1000/Makefile | 3 ++-
drivers/net/fm10k/Makefile | 3 ++-
drivers/net/i40e/Makefile | 2 +-
drivers/net/ixgbe/Makefile | 5 +++--
drivers/net/qede/Makefile | 4 ++--
drivers/net/sfc/Makefile | 2 +-
drivers/net/sfc/meson.build | 2 +-
drivers/net/vmxnet3/Makefile | 3 ++-
10 files changed, 16 insertions(+), 12 deletions(-)
diff --git a/drivers/net/bnx2x/Makefile b/drivers/net/bnx2x/Makefile
index 90ff8b1ee..e3a39a9e0 100644
--- a/drivers/net/bnx2x/Makefile
+++ b/drivers/net/bnx2x/Makefile
@@ -18,7 +18,7 @@ EXPORT_MAP := rte_pmd_bnx2x_version.map
LIBABIVER := 1
ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
-CFLAGS += -wd188 #188: enumerated type mixed with another type
+CFLAGS += -diag-disable 188 #188: enumerated type mixed with another type
endif
#
diff --git a/drivers/net/cxgbe/Makefile b/drivers/net/cxgbe/Makefile
index 65df14253..5dee3c723 100644
--- a/drivers/net/cxgbe/Makefile
+++ b/drivers/net/cxgbe/Makefile
@@ -49,7 +49,7 @@ ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
#
# CFLAGS for icc
#
-CFLAGS_BASE_DRIVER = -wd188
+CFLAGS_BASE_DRIVER = -diag-disable 188
else
#
# CFLAGS for gcc/clang
diff --git a/drivers/net/e1000/Makefile b/drivers/net/e1000/Makefile
index ba81a1f45..01941ac69 100644
--- a/drivers/net/e1000/Makefile
+++ b/drivers/net/e1000/Makefile
@@ -22,7 +22,8 @@ ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
#
# CFLAGS for icc
#
-CFLAGS_BASE_DRIVER = -wd177 -wd181 -wd188 -wd869 -wd2259
+CFLAGS_BASE_DRIVER = -diag-disable 177 -diag-disable 181 -diag-disable 188
+CFLAGS_BASE_DRIVER += -diag-disable 869 -diag-disable 2259
else
#
# CFLAGS for gcc/clang
diff --git a/drivers/net/fm10k/Makefile b/drivers/net/fm10k/Makefile
index b059a700a..d657dff8a 100644
--- a/drivers/net/fm10k/Makefile
+++ b/drivers/net/fm10k/Makefile
@@ -19,7 +19,8 @@ ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
#
# CFLAGS for icc
#
-CFLAGS_BASE_DRIVER = -wd174 -wd593 -wd869 -wd981 -wd2259
+CFLAGS_BASE_DRIVER = -diag-disable 174 -diag-disable 593 -diag-disable 869
+CFLAGS_BASE_DRIVER += -diag-disable 981 -diag-disable 2259
else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
diff --git a/drivers/net/i40e/Makefile b/drivers/net/i40e/Makefile
index 5663f5b1c..c91545741 100644
--- a/drivers/net/i40e/Makefile
+++ b/drivers/net/i40e/Makefile
@@ -24,7 +24,7 @@ LIBABIVER := 2
# to disable warnings
#
ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
-CFLAGS_BASE_DRIVER = -wd593 -wd188
+CFLAGS_BASE_DRIVER = -diag-disable 593 -diag-disable 188
else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
CFLAGS_BASE_DRIVER += -Wno-sign-compare
CFLAGS_BASE_DRIVER += -Wno-unused-value
diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile
index d0804fc5b..f8cad125b 100644
--- a/drivers/net/ixgbe/Makefile
+++ b/drivers/net/ixgbe/Makefile
@@ -20,9 +20,10 @@ ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
#
# CFLAGS for icc
#
-CFLAGS_BASE_DRIVER = -wd174 -wd593 -wd869 -wd981 -wd2259
+CFLAGS_BASE_DRIVER = -diag-disable 174 -diag-disable 593 -diag-disable 869
+CFLAGS_BASE_DRIVER += -diag-disable 981 -diag-disable 2259
-CFLAGS_ixgbe_rxtx.o += -wd3656
+CFLAGS_ixgbe_rxtx.o += -diag-disable 3656
else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
#
diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile
index ccbffa45d..db5ba966e 100644
--- a/drivers/net/qede/Makefile
+++ b/drivers/net/qede/Makefile
@@ -73,8 +73,8 @@ ifeq ($(shell clang -Wno-pointer-bool-conversion -Werror -E - < /dev/null > /dev
CFLAGS_BASE_DRIVER += -Wno-pointer-bool-conversion
endif
else #ICC
-CFLAGS_BASE_DRIVER += -wd188 #188: enumerated type mixed with another type
-CFLAGS_qede_ethdev.o += -wd279 #279: controlling expression is constant
+CFLAGS_BASE_DRIVER += -diag-disable 188 #188: enumerated type mixed with another type
+CFLAGS_qede_ethdev.o += -diag-disable 279 #279: controlling expression is constant
endif
#
diff --git a/drivers/net/sfc/Makefile b/drivers/net/sfc/Makefile
index d2decd09e..fa7238cec 100644
--- a/drivers/net/sfc/Makefile
+++ b/drivers/net/sfc/Makefile
@@ -46,7 +46,7 @@ else ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
# Suppress ICC false positive warning on 'bulk' may be used before its
# value is set
-CFLAGS_sfc_ef10_tx.o += -wd3656
+CFLAGS_sfc_ef10_tx.o += -diag-disable 3656
endif
LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs
diff --git a/drivers/net/sfc/meson.build b/drivers/net/sfc/meson.build
index b60a8f58d..a37fc44a7 100644
--- a/drivers/net/sfc/meson.build
+++ b/drivers/net/sfc/meson.build
@@ -32,7 +32,7 @@ extra_flags += [
# Suppress ICC false positive warning on 'bulk' may be used before its
# value is set
-extra_flags += '-wd3656'
+extra_flags += '-diag-disable 3656'
foreach flag: extra_flags
if cc.has_argument(flag)
diff --git a/drivers/net/vmxnet3/Makefile b/drivers/net/vmxnet3/Makefile
index 6bfbf0195..911850140 100644
--- a/drivers/net/vmxnet3/Makefile
+++ b/drivers/net/vmxnet3/Makefile
@@ -15,7 +15,8 @@ ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
#
# CFLAGS for icc
#
-CFLAGS_BASE_DRIVER = -wd174 -wd593 -wd869 -wd981 -wd2259
+CFLAGS_BASE_DRIVER = -diag-disable 174 -diag-disable 593 -diag-disable 869
+CFLAGS_BASE_DRIVER += -diag-disable 981 -diag-disable 2259
else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
#
--
2.13.6
^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-dev] [PATCH 2/2] drivers/net: remove redundant icc flag
2018-03-12 12:38 [dpdk-dev] [PATCH 1/2] drivers/net: update icc deprecated parameter Ferruh Yigit
@ 2018-03-12 12:39 ` Ferruh Yigit
2018-04-11 10:12 ` De Lara Guarch, Pablo
2018-04-11 10:11 ` [dpdk-dev] [PATCH 1/2] drivers/net: update icc deprecated parameter De Lara Guarch, Pablo
2018-04-13 22:21 ` [dpdk-dev] [PATCH v2 1/2] drivers/net: fix icc deprecated parameter warning Ferruh Yigit
2 siblings, 1 reply; 8+ messages in thread
From: Ferruh Yigit @ 2018-03-12 12:39 UTC (permalink / raw)
To: Harish Patil, Rasesh Mody, Rahul Lakkireddy, Wenzhuo Lu,
Qi Zhang, Xiao Wang, Beilei Xing, Konstantin Ananyev,
Shahed Shaikh, Andrew Rybchenko, Shrikrishna Khare
Cc: dev, Ferruh Yigit, stable
ICC warning #188 already disabled globally via commit [1], no
need individual arguments in PMDs.
[1]
Fixes: 1b80b9c854c3 ("mk: disable icc warning 188")
Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
drivers/net/bnx2x/Makefile | 4 ----
drivers/net/cxgbe/Makefile | 8 --------
drivers/net/e1000/Makefile | 2 +-
drivers/net/i40e/Makefile | 2 +-
drivers/net/qede/Makefile | 1 -
5 files changed, 2 insertions(+), 15 deletions(-)
diff --git a/drivers/net/bnx2x/Makefile b/drivers/net/bnx2x/Makefile
index e3a39a9e0..0c0f51aaa 100644
--- a/drivers/net/bnx2x/Makefile
+++ b/drivers/net/bnx2x/Makefile
@@ -17,10 +17,6 @@ EXPORT_MAP := rte_pmd_bnx2x_version.map
LIBABIVER := 1
-ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
-CFLAGS += -diag-disable 188 #188: enumerated type mixed with another type
-endif
-
#
# all source are stored in SRCS-y
#
diff --git a/drivers/net/cxgbe/Makefile b/drivers/net/cxgbe/Makefile
index 5dee3c723..33267f6a6 100644
--- a/drivers/net/cxgbe/Makefile
+++ b/drivers/net/cxgbe/Makefile
@@ -45,12 +45,6 @@ EXPORT_MAP := rte_pmd_cxgbe_version.map
LIBABIVER := 1
-ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
-#
-# CFLAGS for icc
-#
-CFLAGS_BASE_DRIVER = -diag-disable 188
-else
#
# CFLAGS for gcc/clang
#
@@ -59,9 +53,7 @@ ifeq ($(shell test $(GCC_VERSION) -ge 44 && echo 1), 1)
CFLAGS += -Wno-deprecated
endif
endif
-CFLAGS_BASE_DRIVER =
-endif
LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs
LDLIBS += -lrte_bus_pci
diff --git a/drivers/net/e1000/Makefile b/drivers/net/e1000/Makefile
index 01941ac69..87cfb265d 100644
--- a/drivers/net/e1000/Makefile
+++ b/drivers/net/e1000/Makefile
@@ -22,7 +22,7 @@ ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
#
# CFLAGS for icc
#
-CFLAGS_BASE_DRIVER = -diag-disable 177 -diag-disable 181 -diag-disable 188
+CFLAGS_BASE_DRIVER = -diag-disable 177 -diag-disable 181
CFLAGS_BASE_DRIVER += -diag-disable 869 -diag-disable 2259
else
#
diff --git a/drivers/net/i40e/Makefile b/drivers/net/i40e/Makefile
index c91545741..7e34b50a7 100644
--- a/drivers/net/i40e/Makefile
+++ b/drivers/net/i40e/Makefile
@@ -24,7 +24,7 @@ LIBABIVER := 2
# to disable warnings
#
ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
-CFLAGS_BASE_DRIVER = -diag-disable 593 -diag-disable 188
+CFLAGS_BASE_DRIVER = -diag-disable 593
else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
CFLAGS_BASE_DRIVER += -Wno-sign-compare
CFLAGS_BASE_DRIVER += -Wno-unused-value
diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile
index db5ba966e..831ee15df 100644
--- a/drivers/net/qede/Makefile
+++ b/drivers/net/qede/Makefile
@@ -73,7 +73,6 @@ ifeq ($(shell clang -Wno-pointer-bool-conversion -Werror -E - < /dev/null > /dev
CFLAGS_BASE_DRIVER += -Wno-pointer-bool-conversion
endif
else #ICC
-CFLAGS_BASE_DRIVER += -diag-disable 188 #188: enumerated type mixed with another type
CFLAGS_qede_ethdev.o += -diag-disable 279 #279: controlling expression is constant
endif
--
2.13.6
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] drivers/net: update icc deprecated parameter
2018-03-12 12:38 [dpdk-dev] [PATCH 1/2] drivers/net: update icc deprecated parameter Ferruh Yigit
2018-03-12 12:39 ` [dpdk-dev] [PATCH 2/2] drivers/net: remove redundant icc flag Ferruh Yigit
@ 2018-04-11 10:11 ` De Lara Guarch, Pablo
2018-04-11 10:46 ` Ferruh Yigit
2018-04-13 22:21 ` [dpdk-dev] [PATCH v2 1/2] drivers/net: fix icc deprecated parameter warning Ferruh Yigit
2 siblings, 1 reply; 8+ messages in thread
From: De Lara Guarch, Pablo @ 2018-04-11 10:11 UTC (permalink / raw)
To: Yigit, Ferruh, Harish Patil, Rasesh Mody, Rahul Lakkireddy, Lu,
Wenzhuo, Zhang, Qi Z, Wang, Xiao W, Xing, Beilei, Ananyev,
Konstantin, Shahed Shaikh, Andrew Rybchenko, Shrikrishna Khare
Cc: dev, Yigit, Ferruh
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit
> Sent: Monday, March 12, 2018 12:39 PM
> To: Harish Patil <harish.patil@cavium.com>; Rasesh Mody
> <rasesh.mody@cavium.com>; Rahul Lakkireddy
> <rahul.lakkireddy@chelsio.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> Zhang, Qi Z <qi.z.zhang@intel.com>; Wang, Xiao W <xiao.w.wang@intel.com>;
> Xing, Beilei <beilei.xing@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Shahed Shaikh
> <shahed.shaikh@cavium.com>; Andrew Rybchenko
> <arybchenko@solarflare.com>; Shrikrishna Khare <skhare@vmware.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: [dpdk-dev] [PATCH 1/2] drivers/net: update icc deprecated parameter
>
> With icc (ICC) 18.0.1 20171018, -wd usage generates following warning:
>
> icc: command line remark #10010: option '-wd3656' is deprecated and will be
> removed in a future release. See '-help deprecated'
>
> "icc -help deprecated" output is:
> -wd use -diag-disable
>
> Based on above information "-wd" converted to "-diag-disable"
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Should this go into the stable branch? These warnings will be present there too.
Apart from this comment:
Tested-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH 2/2] drivers/net: remove redundant icc flag
2018-03-12 12:39 ` [dpdk-dev] [PATCH 2/2] drivers/net: remove redundant icc flag Ferruh Yigit
@ 2018-04-11 10:12 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 8+ messages in thread
From: De Lara Guarch, Pablo @ 2018-04-11 10:12 UTC (permalink / raw)
To: Yigit, Ferruh, Harish Patil, Rasesh Mody, Rahul Lakkireddy, Lu,
Wenzhuo, Zhang, Qi Z, Wang, Xiao W, Xing, Beilei, Ananyev,
Konstantin, Shahed Shaikh, Andrew Rybchenko
Cc: dev, Yigit, Ferruh, stable
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit
> Sent: Monday, March 12, 2018 12:39 PM
> To: Harish Patil <harish.patil@cavium.com>; Rasesh Mody
> <rasesh.mody@cavium.com>; Rahul Lakkireddy
> <rahul.lakkireddy@chelsio.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> Zhang, Qi Z <qi.z.zhang@intel.com>; Wang, Xiao W <xiao.w.wang@intel.com>;
> Xing, Beilei <beilei.xing@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Shahed Shaikh
> <shahed.shaikh@cavium.com>; Andrew Rybchenko
> <arybchenko@solarflare.com>; Shrikrishna Khare <skhare@vmware.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH 2/2] drivers/net: remove redundant icc flag
>
> ICC warning #188 already disabled globally via commit [1], no need individual
> arguments in PMDs.
>
> [1]
> Fixes: 1b80b9c854c3 ("mk: disable icc warning 188")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Tested-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] drivers/net: update icc deprecated parameter
2018-04-11 10:11 ` [dpdk-dev] [PATCH 1/2] drivers/net: update icc deprecated parameter De Lara Guarch, Pablo
@ 2018-04-11 10:46 ` Ferruh Yigit
0 siblings, 0 replies; 8+ messages in thread
From: Ferruh Yigit @ 2018-04-11 10:46 UTC (permalink / raw)
To: De Lara Guarch, Pablo, Harish Patil, Rasesh Mody,
Rahul Lakkireddy, Lu, Wenzhuo, Zhang, Qi Z, Wang, Xiao W, Xing,
Beilei, Ananyev, Konstantin, Shahed Shaikh, Andrew Rybchenko,
Shrikrishna Khare
Cc: dev
On 4/11/2018 11:11 AM, De Lara Guarch, Pablo wrote:
>
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit
>> Sent: Monday, March 12, 2018 12:39 PM
>> To: Harish Patil <harish.patil@cavium.com>; Rasesh Mody
>> <rasesh.mody@cavium.com>; Rahul Lakkireddy
>> <rahul.lakkireddy@chelsio.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
>> Zhang, Qi Z <qi.z.zhang@intel.com>; Wang, Xiao W <xiao.w.wang@intel.com>;
>> Xing, Beilei <beilei.xing@intel.com>; Ananyev, Konstantin
>> <konstantin.ananyev@intel.com>; Shahed Shaikh
>> <shahed.shaikh@cavium.com>; Andrew Rybchenko
>> <arybchenko@solarflare.com>; Shrikrishna Khare <skhare@vmware.com>
>> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
>> Subject: [dpdk-dev] [PATCH 1/2] drivers/net: update icc deprecated parameter
>>
>> With icc (ICC) 18.0.1 20171018, -wd usage generates following warning:
>>
>> icc: command line remark #10010: option '-wd3656' is deprecated and will be
>> removed in a future release. See '-help deprecated'
>>
>> "icc -help deprecated" output is:
>> -wd use -diag-disable
>>
>> Based on above information "-wd" converted to "-diag-disable"
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Should this go into the stable branch? These warnings will be present there too.
Makes sense, I will update as "fix" patch and will send a new version.
> Apart from this comment:
>
> Tested-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-dev] [PATCH v2 1/2] drivers/net: fix icc deprecated parameter warning
2018-03-12 12:38 [dpdk-dev] [PATCH 1/2] drivers/net: update icc deprecated parameter Ferruh Yigit
2018-03-12 12:39 ` [dpdk-dev] [PATCH 2/2] drivers/net: remove redundant icc flag Ferruh Yigit
2018-04-11 10:11 ` [dpdk-dev] [PATCH 1/2] drivers/net: update icc deprecated parameter De Lara Guarch, Pablo
@ 2018-04-13 22:21 ` Ferruh Yigit
2018-04-13 22:21 ` [dpdk-dev] [PATCH v2 2/2] drivers/net: remove redundant icc flag Ferruh Yigit
2018-04-13 22:30 ` [dpdk-dev] [PATCH v2 1/2] drivers/net: fix icc deprecated parameter warning Ferruh Yigit
2 siblings, 2 replies; 8+ messages in thread
From: Ferruh Yigit @ 2018-04-13 22:21 UTC (permalink / raw)
To: Harish Patil, Rasesh Mody, Rahul Lakkireddy, Wenzhuo Lu,
Qi Zhang, Xiao Wang, Beilei Xing, Konstantin Ananyev,
Shahed Shaikh, Andrew Rybchenko, Yong Wang
Cc: dev, Ferruh Yigit, stable
With icc (ICC) 18.0.1 20171018, -wd usage generates following warning:
icc: command line remark #10010: option '-wd3656' is deprecated and will
be removed in a future release. See '-help deprecated'
"icc -help deprecated" output is:
-wd use -diag-disable
Based on above information "-wd" converted to "-diag-disable"
Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Tested-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
v2:
* commit log updated, cc stable mail list
---
drivers/net/bnx2x/Makefile | 2 +-
drivers/net/cxgbe/Makefile | 2 +-
drivers/net/e1000/Makefile | 3 ++-
drivers/net/fm10k/Makefile | 3 ++-
drivers/net/i40e/Makefile | 2 +-
drivers/net/ixgbe/Makefile | 5 +++--
drivers/net/qede/Makefile | 4 ++--
drivers/net/sfc/Makefile | 2 +-
drivers/net/sfc/meson.build | 2 +-
drivers/net/vmxnet3/Makefile | 3 ++-
10 files changed, 16 insertions(+), 12 deletions(-)
diff --git a/drivers/net/bnx2x/Makefile b/drivers/net/bnx2x/Makefile
index 90ff8b1ee..e3a39a9e0 100644
--- a/drivers/net/bnx2x/Makefile
+++ b/drivers/net/bnx2x/Makefile
@@ -18,7 +18,7 @@ EXPORT_MAP := rte_pmd_bnx2x_version.map
LIBABIVER := 1
ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
-CFLAGS += -wd188 #188: enumerated type mixed with another type
+CFLAGS += -diag-disable 188 #188: enumerated type mixed with another type
endif
#
diff --git a/drivers/net/cxgbe/Makefile b/drivers/net/cxgbe/Makefile
index 8fba1a540..1015fec12 100644
--- a/drivers/net/cxgbe/Makefile
+++ b/drivers/net/cxgbe/Makefile
@@ -22,7 +22,7 @@ ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
#
# CFLAGS for icc
#
-CFLAGS_BASE_DRIVER = -wd188
+CFLAGS_BASE_DRIVER = -diag-disable 188
else
#
# CFLAGS for gcc/clang
diff --git a/drivers/net/e1000/Makefile b/drivers/net/e1000/Makefile
index ba81a1f45..01941ac69 100644
--- a/drivers/net/e1000/Makefile
+++ b/drivers/net/e1000/Makefile
@@ -22,7 +22,8 @@ ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
#
# CFLAGS for icc
#
-CFLAGS_BASE_DRIVER = -wd177 -wd181 -wd188 -wd869 -wd2259
+CFLAGS_BASE_DRIVER = -diag-disable 177 -diag-disable 181 -diag-disable 188
+CFLAGS_BASE_DRIVER += -diag-disable 869 -diag-disable 2259
else
#
# CFLAGS for gcc/clang
diff --git a/drivers/net/fm10k/Makefile b/drivers/net/fm10k/Makefile
index b059a700a..d657dff8a 100644
--- a/drivers/net/fm10k/Makefile
+++ b/drivers/net/fm10k/Makefile
@@ -19,7 +19,8 @@ ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
#
# CFLAGS for icc
#
-CFLAGS_BASE_DRIVER = -wd174 -wd593 -wd869 -wd981 -wd2259
+CFLAGS_BASE_DRIVER = -diag-disable 174 -diag-disable 593 -diag-disable 869
+CFLAGS_BASE_DRIVER += -diag-disable 981 -diag-disable 2259
else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
diff --git a/drivers/net/i40e/Makefile b/drivers/net/i40e/Makefile
index 5663f5b1c..c91545741 100644
--- a/drivers/net/i40e/Makefile
+++ b/drivers/net/i40e/Makefile
@@ -24,7 +24,7 @@ LIBABIVER := 2
# to disable warnings
#
ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
-CFLAGS_BASE_DRIVER = -wd593 -wd188
+CFLAGS_BASE_DRIVER = -diag-disable 593 -diag-disable 188
else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
CFLAGS_BASE_DRIVER += -Wno-sign-compare
CFLAGS_BASE_DRIVER += -Wno-unused-value
diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile
index d0804fc5b..f8cad125b 100644
--- a/drivers/net/ixgbe/Makefile
+++ b/drivers/net/ixgbe/Makefile
@@ -20,9 +20,10 @@ ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
#
# CFLAGS for icc
#
-CFLAGS_BASE_DRIVER = -wd174 -wd593 -wd869 -wd981 -wd2259
+CFLAGS_BASE_DRIVER = -diag-disable 174 -diag-disable 593 -diag-disable 869
+CFLAGS_BASE_DRIVER += -diag-disable 981 -diag-disable 2259
-CFLAGS_ixgbe_rxtx.o += -wd3656
+CFLAGS_ixgbe_rxtx.o += -diag-disable 3656
else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
#
diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile
index ccbffa45d..db5ba966e 100644
--- a/drivers/net/qede/Makefile
+++ b/drivers/net/qede/Makefile
@@ -73,8 +73,8 @@ ifeq ($(shell clang -Wno-pointer-bool-conversion -Werror -E - < /dev/null > /dev
CFLAGS_BASE_DRIVER += -Wno-pointer-bool-conversion
endif
else #ICC
-CFLAGS_BASE_DRIVER += -wd188 #188: enumerated type mixed with another type
-CFLAGS_qede_ethdev.o += -wd279 #279: controlling expression is constant
+CFLAGS_BASE_DRIVER += -diag-disable 188 #188: enumerated type mixed with another type
+CFLAGS_qede_ethdev.o += -diag-disable 279 #279: controlling expression is constant
endif
#
diff --git a/drivers/net/sfc/Makefile b/drivers/net/sfc/Makefile
index d3361d139..f3e0b4b4e 100644
--- a/drivers/net/sfc/Makefile
+++ b/drivers/net/sfc/Makefile
@@ -46,7 +46,7 @@ else ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
# Suppress ICC false positive warning on 'bulk' may be used before its
# value is set
-CFLAGS_sfc_ef10_tx.o += -wd3656
+CFLAGS_sfc_ef10_tx.o += -diag-disable 3656
endif
LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs
diff --git a/drivers/net/sfc/meson.build b/drivers/net/sfc/meson.build
index b60a8f58d..a37fc44a7 100644
--- a/drivers/net/sfc/meson.build
+++ b/drivers/net/sfc/meson.build
@@ -32,7 +32,7 @@ extra_flags += [
# Suppress ICC false positive warning on 'bulk' may be used before its
# value is set
-extra_flags += '-wd3656'
+extra_flags += '-diag-disable 3656'
foreach flag: extra_flags
if cc.has_argument(flag)
diff --git a/drivers/net/vmxnet3/Makefile b/drivers/net/vmxnet3/Makefile
index 6bfbf0195..911850140 100644
--- a/drivers/net/vmxnet3/Makefile
+++ b/drivers/net/vmxnet3/Makefile
@@ -15,7 +15,8 @@ ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
#
# CFLAGS for icc
#
-CFLAGS_BASE_DRIVER = -wd174 -wd593 -wd869 -wd981 -wd2259
+CFLAGS_BASE_DRIVER = -diag-disable 174 -diag-disable 593 -diag-disable 869
+CFLAGS_BASE_DRIVER += -diag-disable 981 -diag-disable 2259
else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
#
--
2.14.3
^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-dev] [PATCH v2 2/2] drivers/net: remove redundant icc flag
2018-04-13 22:21 ` [dpdk-dev] [PATCH v2 1/2] drivers/net: fix icc deprecated parameter warning Ferruh Yigit
@ 2018-04-13 22:21 ` Ferruh Yigit
2018-04-13 22:30 ` [dpdk-dev] [PATCH v2 1/2] drivers/net: fix icc deprecated parameter warning Ferruh Yigit
1 sibling, 0 replies; 8+ messages in thread
From: Ferruh Yigit @ 2018-04-13 22:21 UTC (permalink / raw)
To: Harish Patil, Rasesh Mody, Rahul Lakkireddy, Wenzhuo Lu,
Qi Zhang, Xiao Wang, Beilei Xing, Konstantin Ananyev,
Shahed Shaikh, Andrew Rybchenko, Yong Wang
Cc: dev, Ferruh Yigit, stable
ICC warning #188 already disabled globally via commit [1], no
need individual arguments in PMDs.
[1]
Fixes: 1b80b9c854c3 ("mk: disable icc warning 188")
Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Tested-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
drivers/net/bnx2x/Makefile | 4 ----
drivers/net/cxgbe/Makefile | 8 --------
drivers/net/e1000/Makefile | 2 +-
drivers/net/i40e/Makefile | 2 +-
drivers/net/qede/Makefile | 1 -
5 files changed, 2 insertions(+), 15 deletions(-)
diff --git a/drivers/net/bnx2x/Makefile b/drivers/net/bnx2x/Makefile
index e3a39a9e0..0c0f51aaa 100644
--- a/drivers/net/bnx2x/Makefile
+++ b/drivers/net/bnx2x/Makefile
@@ -17,10 +17,6 @@ EXPORT_MAP := rte_pmd_bnx2x_version.map
LIBABIVER := 1
-ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
-CFLAGS += -diag-disable 188 #188: enumerated type mixed with another type
-endif
-
#
# all source are stored in SRCS-y
#
diff --git a/drivers/net/cxgbe/Makefile b/drivers/net/cxgbe/Makefile
index 1015fec12..79fdb6f06 100644
--- a/drivers/net/cxgbe/Makefile
+++ b/drivers/net/cxgbe/Makefile
@@ -18,12 +18,6 @@ EXPORT_MAP := rte_pmd_cxgbe_version.map
LIBABIVER := 1
-ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
-#
-# CFLAGS for icc
-#
-CFLAGS_BASE_DRIVER = -diag-disable 188
-else
#
# CFLAGS for gcc/clang
#
@@ -32,9 +26,7 @@ ifeq ($(shell test $(GCC_VERSION) -ge 44 && echo 1), 1)
CFLAGS += -Wno-deprecated
endif
endif
-CFLAGS_BASE_DRIVER =
-endif
LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs
LDLIBS += -lrte_bus_pci
diff --git a/drivers/net/e1000/Makefile b/drivers/net/e1000/Makefile
index 01941ac69..87cfb265d 100644
--- a/drivers/net/e1000/Makefile
+++ b/drivers/net/e1000/Makefile
@@ -22,7 +22,7 @@ ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
#
# CFLAGS for icc
#
-CFLAGS_BASE_DRIVER = -diag-disable 177 -diag-disable 181 -diag-disable 188
+CFLAGS_BASE_DRIVER = -diag-disable 177 -diag-disable 181
CFLAGS_BASE_DRIVER += -diag-disable 869 -diag-disable 2259
else
#
diff --git a/drivers/net/i40e/Makefile b/drivers/net/i40e/Makefile
index c91545741..7e34b50a7 100644
--- a/drivers/net/i40e/Makefile
+++ b/drivers/net/i40e/Makefile
@@ -24,7 +24,7 @@ LIBABIVER := 2
# to disable warnings
#
ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
-CFLAGS_BASE_DRIVER = -diag-disable 593 -diag-disable 188
+CFLAGS_BASE_DRIVER = -diag-disable 593
else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
CFLAGS_BASE_DRIVER += -Wno-sign-compare
CFLAGS_BASE_DRIVER += -Wno-unused-value
diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile
index db5ba966e..831ee15df 100644
--- a/drivers/net/qede/Makefile
+++ b/drivers/net/qede/Makefile
@@ -73,7 +73,6 @@ ifeq ($(shell clang -Wno-pointer-bool-conversion -Werror -E - < /dev/null > /dev
CFLAGS_BASE_DRIVER += -Wno-pointer-bool-conversion
endif
else #ICC
-CFLAGS_BASE_DRIVER += -diag-disable 188 #188: enumerated type mixed with another type
CFLAGS_qede_ethdev.o += -diag-disable 279 #279: controlling expression is constant
endif
--
2.14.3
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH v2 1/2] drivers/net: fix icc deprecated parameter warning
2018-04-13 22:21 ` [dpdk-dev] [PATCH v2 1/2] drivers/net: fix icc deprecated parameter warning Ferruh Yigit
2018-04-13 22:21 ` [dpdk-dev] [PATCH v2 2/2] drivers/net: remove redundant icc flag Ferruh Yigit
@ 2018-04-13 22:30 ` Ferruh Yigit
1 sibling, 0 replies; 8+ messages in thread
From: Ferruh Yigit @ 2018-04-13 22:30 UTC (permalink / raw)
To: Harish Patil, Rasesh Mody, Rahul Lakkireddy, Wenzhuo Lu,
Qi Zhang, Xiao Wang, Beilei Xing, Konstantin Ananyev,
Shahed Shaikh, Andrew Rybchenko, Yong Wang
Cc: dev, stable
On 4/13/2018 11:21 PM, Ferruh Yigit wrote:
> With icc (ICC) 18.0.1 20171018, -wd usage generates following warning:
>
> icc: command line remark #10010: option '-wd3656' is deprecated and will
> be removed in a future release. See '-help deprecated'
>
> "icc -help deprecated" output is:
> -wd use -diag-disable
>
> Based on above information "-wd" converted to "-diag-disable"
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Tested-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Series applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-04-13 22:30 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-12 12:38 [dpdk-dev] [PATCH 1/2] drivers/net: update icc deprecated parameter Ferruh Yigit
2018-03-12 12:39 ` [dpdk-dev] [PATCH 2/2] drivers/net: remove redundant icc flag Ferruh Yigit
2018-04-11 10:12 ` De Lara Guarch, Pablo
2018-04-11 10:11 ` [dpdk-dev] [PATCH 1/2] drivers/net: update icc deprecated parameter De Lara Guarch, Pablo
2018-04-11 10:46 ` Ferruh Yigit
2018-04-13 22:21 ` [dpdk-dev] [PATCH v2 1/2] drivers/net: fix icc deprecated parameter warning Ferruh Yigit
2018-04-13 22:21 ` [dpdk-dev] [PATCH v2 2/2] drivers/net: remove redundant icc flag Ferruh Yigit
2018-04-13 22:30 ` [dpdk-dev] [PATCH v2 1/2] drivers/net: fix icc deprecated parameter warning Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).