From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Sunil Kumar Kori <skori@marvell.com>,
Rakesh Kudurumalla <rkudurumalla@marvell.com>,
fengchengwen <fengchengwen@huawei.com>,
Jie Hai <haijie1@huawei.com>
Subject: Re: [PATCH] graph: replace strtok with strtok_r
Date: Tue, 19 Nov 2024 12:26:17 +0100 [thread overview]
Message-ID: <7877813.lvqk35OSZv@thomas> (raw)
In-Reply-To: <a4984e6c-4f7e-4c39-8a23-58f865ce6d99@huawei.com>
12/09/2024 03:29, fengchengwen:
> On 2024/9/12 8:55, Stephen Hemminger wrote:
> > The function strtok is not thread safe, better to use strtok_r.
> > This patch was found by running semgrep on the DPDK repository.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Chengwen Feng <fengchengwen@huawei.com>
Applied, thanks.
> There are many strtok invoking in DPDK current, and Hai Jie already submitted a patchset [1], and it seemed interrupted.
> Perhaps it's time to re-submit.
>
> [1] https://inbox.dpdk.org/dev/20231114110006.91148-1-haijie1@huawei.com/
Waiting for a v6
prev parent reply other threads:[~2024-11-19 11:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 0:55 Stephen Hemminger
2024-09-12 1:29 ` fengchengwen
2024-11-19 11:26 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7877813.lvqk35OSZv@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=haijie1@huawei.com \
--cc=rkudurumalla@marvell.com \
--cc=skori@marvell.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).