From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A018545D42; Tue, 19 Nov 2024 12:26:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A12B40268; Tue, 19 Nov 2024 12:26:23 +0100 (CET) Received: from fhigh-b6-smtp.messagingengine.com (fhigh-b6-smtp.messagingengine.com [202.12.124.157]) by mails.dpdk.org (Postfix) with ESMTP id A469F40041 for ; Tue, 19 Nov 2024 12:26:21 +0100 (CET) Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfhigh.stl.internal (Postfix) with ESMTP id CE8D52540066; Tue, 19 Nov 2024 06:26:20 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Tue, 19 Nov 2024 06:26:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1732015580; x=1732101980; bh=MOZVeKPCJmR/7DUkkJZ0jh5Qx/XwFONe1EA2tJYPTkA=; b= ETSjstrJV9Gd7HvycTMofJSGQX6A7LRycyU5LzIUkwbM1F0qN72h2xlkLVCegqxG 1fJXl2hPRXkIYMj8igNvtBYTd+rS//qp8K36k8rEAx0K2Zp6evSfRYyBteSjRmz1 Rud8RryiOeNbg3XvnnYUXPSrWqXTGrmfUZOEkx/1+PPcWMmW4aAgA5Np0I+HYqFC rnrb7LOPlfeuu3v1FbDqfn2JLSAQUmFKffIUFdmYNn5EFoGrrLMBTmQwyS2h8cWU rFmM07u6PrZ9TRWe+7m6eZUmnOcwnwMGYDrbjcvvQxWScKw5D4tKDAuNPOYYZNME VNWhlLAP1yg08ObuP7QWRA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1732015580; x= 1732101980; bh=MOZVeKPCJmR/7DUkkJZ0jh5Qx/XwFONe1EA2tJYPTkA=; b=M JKV3xG08cyRob/jFvvCB7qEswfw/SPN9haJsPe/LWHK3eP5rd4Unz4nt6+2lm6CK bUezMLMzEc4nHWELWFwsHHiZIOwdUcpbrkPU8NMumyMkr0V8Hyhx9VqGVqXmyrsS K9E6lZNU3SQXKT7bjrsEjOJNQjUy42J+Nc1AL5+GN7fnQaVbkuTrb0Sp4175K1Xf gaeOGy29t8yTbzBkmyeQfw/CqXaoS+V3pgp0pkVRYT1nMwcm3MrE2CFzMNtNnm9W gVdWxB2+d7/FMqgoGa/dxh9qmnrx+TeFw3XlnEhguJgcTQ7ZnV7BRFEtR0VvOG/i sDYFbTjYH9AV0fh9CHKEg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrfedvgddvjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecu hfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlh honhdrnhgvtheqnecuggftrfgrthhtvghrnhepkeefheeftdegtdejheeuuedtgfelfeei veekieekleekffelgfdtveeiheehffdunecuffhomhgrihhnpeguphgukhdrohhrghenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgr shesmhhonhhjrghlohhnrdhnvghtpdhnsggprhgtphhtthhopeeipdhmohguvgepshhmth hpohhuthdprhgtphhtthhopehsthgvphhhvghnsehnvghtfihorhhkphhluhhmsggvrhdr ohhrghdprhgtphhtthhopeguvghvseguphgukhdrohhrghdprhgtphhtthhopehskhhorh hisehmrghrvhgvlhhlrdgtohhmpdhrtghpthhtoheprhhkuhguuhhruhhmrghllhgrsehm rghrvhgvlhhlrdgtohhmpdhrtghpthhtohepfhgvnhhgtghhvghnghifvghnsehhuhgrfi gvihdrtghomhdprhgtphhtthhopehhrghijhhivgdusehhuhgrfigvihdrtghomh X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 19 Nov 2024 06:26:19 -0500 (EST) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, Sunil Kumar Kori , Rakesh Kudurumalla , fengchengwen , Jie Hai Subject: Re: [PATCH] graph: replace strtok with strtok_r Date: Tue, 19 Nov 2024 12:26:17 +0100 Message-ID: <7877813.lvqk35OSZv@thomas> In-Reply-To: References: <20240912005602.71815-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 12/09/2024 03:29, fengchengwen: > On 2024/9/12 8:55, Stephen Hemminger wrote: > > The function strtok is not thread safe, better to use strtok_r. > > This patch was found by running semgrep on the DPDK repository. > > > > Signed-off-by: Stephen Hemminger > Acked-by: Chengwen Feng Applied, thanks. > There are many strtok invoking in DPDK current, and Hai Jie already submitted a patchset [1], and it seemed interrupted. > Perhaps it's time to re-submit. > > [1] https://inbox.dpdk.org/dev/20231114110006.91148-1-haijie1@huawei.com/ Waiting for a v6