From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B25AAA0C5A; Wed, 8 Sep 2021 18:00:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4C80F41102; Wed, 8 Sep 2021 18:00:37 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id F0EBD4003E for ; Wed, 8 Sep 2021 18:00:35 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10101"; a="207753703" X-IronPort-AV: E=Sophos;i="5.85,278,1624345200"; d="scan'208";a="207753703" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2021 09:00:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,278,1624345200"; d="scan'208";a="449480492" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP; 08 Sep 2021 09:00:34 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 8 Sep 2021 09:00:34 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 8 Sep 2021 09:00:33 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 8 Sep 2021 09:00:33 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 8 Sep 2021 09:00:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HPkHy97XT6IK+2lrfkUnSypouUP1btox+VKemYUD8HHfsB8O9BFHGYaOvraj6IWeP9CtUXtUJvzikHxXWfeeRRyfhjaog5OxMaBPaTDwteV/HWGIYp8yJUyKy+LlF60ppQk77Y/K80XUC6oDuHo7gmpL+aqruFeGE6jKWu42zg7pXrYgwByFyElR8PB2QUsbRQdCLzHl9BI9Zy2I5Q2003ZYWZ6VuUm0we9mHOz0958NR9WBtm0DpYaYCSn8nmDoJeMLYfLSBBZW7Qu5pSFiBWS6Y62z2YluvEvm5IcoJq2lQfiVMXpW43hpx6iHSsD4bcIAzfJ0FvADhSFng7ZDuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=zZmEGGnA99pd2a8uIC8yM8MffEPf6jgqqcm0jFh2WuY=; b=TCl84E8EZ6xdEX+AiE0Ybh3h2+YEfYU42Zyj4FSlmA7Hi40RW/rC9ieztSClcz29qMe6IoZmOtap/X2dN8rBX+x0Gm5BKc8sXUCsGbUZ7mHn2F5qFeOPvmSrhxoDXsU1GjzkLCnjE5ploaFVD4CvXOAahDiF6pp1t8DuO59FWkqspHY4FupjRVAKoo7qtsAid5/fwMRZiLgqw6T8dof2m1jfrKE77QODuX0BvaF0PRMvJBuZmMo0LUJW8Z7ct/MqCG+wZyTdZnwg9pZbnA3yfFcE4XKy+FwudDfh9saPrkKnuSNjDyvuBuq9OfpNtWfssukv6tXAFrbrBcy5Wrh07A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zZmEGGnA99pd2a8uIC8yM8MffEPf6jgqqcm0jFh2WuY=; b=Qhd3FCKs5Fytv2y0L5/89GytFBf8AkEJ5tAG8RPsv4dU+9NHEIQLMrGCjF6eM5Gh8gIeL0v1uBufAq8TdYZryus7GF2mfYGMzaF8zpPctRqJOaKRO/g1Y1q6VLVBYwEK3fUi5wPWlHa6hznuEoaZxH60LQZ7J+FgDjTivxRr0kM= Authentication-Results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5207.namprd11.prod.outlook.com (2603:10b6:510:32::15) by PH0PR11MB5063.namprd11.prod.outlook.com (2603:10b6:510:3d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Wed, 8 Sep 2021 16:00:31 +0000 Received: from PH0PR11MB5207.namprd11.prod.outlook.com ([fe80::c42e:f6ab:d4d6:dc8a]) by PH0PR11MB5207.namprd11.prod.outlook.com ([fe80::c42e:f6ab:d4d6:dc8a%6]) with mapi id 15.20.4478.025; Wed, 8 Sep 2021 16:00:31 +0000 To: Kevin Laatz , CC: , , References: <20210903105001.1179328-1-kevin.laatz@intel.com> <20210908103016.1661914-1-kevin.laatz@intel.com> <20210908103016.1661914-2-kevin.laatz@intel.com> From: Conor Walsh Message-ID: <787c62f4-1d60-0c32-c3ca-15209cbf52b0@intel.com> Date: Wed, 8 Sep 2021 17:00:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20210908103016.1661914-2-kevin.laatz@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-ClientProxiedBy: DB6PR07CA0014.eurprd07.prod.outlook.com (2603:10a6:6:2d::24) To PH0PR11MB5207.namprd11.prod.outlook.com (2603:10b6:510:32::15) MIME-Version: 1.0 Received: from [192.168.1.181] (86.40.71.8) by DB6PR07CA0014.eurprd07.prod.outlook.com (2603:10a6:6:2d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.6 via Frontend Transport; Wed, 8 Sep 2021 16:00:29 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b2fcdae4-14e9-4176-715e-08d972e1c8ab X-MS-TrafficTypeDiagnostic: PH0PR11MB5063: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G4QfAqr89OGxm3bMNGm8bU/QZ/0GSMSB3jGr2KmZ+pTnbU9wvjjxdWFnNbjV3aBFYuMYEIJR91tiiDj0XlRnAEOZ2QRBLizOVZmGgNmsuv7fEfBpOhYPAnXevhabtX/cbHSnmOEZbuCPOLAEXasP4U9jQZSMN2GdhLDTb3pPN4RlszCVsd8ZEcbB5enlyWUISKJx//vUq8LMB3JsSbnyA1ONq750WvWKLgNXdMbxNd0j+hvU2W6CwSp8p9MF0j98EfW+DJDxMKjX5QPsyuNtWIm1v5hqjYCjeNhfTcQE73FmpbNz4MBURWp8K35EhVns4SyaI+8Ucb0CmKd5w4pf0yHY4UtgXzgkiABmpv6tkDpKhISjjUIKpzvkE38dglcihgO1SkltJb26uD7j9pCnVQh5pmh6tEbtQz3FUjjwjzVU34cOll+2lDpOvG+SDrY+jtCpAu+JSDFAq1G5q1CJkNfH4JozvuukhPNbBxQJ2WQ4b2Uzb6gr3NmD7gFgjbfDZoqCIPlM0dhIDoOd0Y0DbZOmDluon86la01vkFROL9avCRSfJ0s3RCcmROMG4lrM0ro5TB6Z+djYvgNMa+34flF9i0eZdm7EMlGhDnPmbBnSZ+rd05ih1CO0dKUpgpfsQr7H+vV1VKv+fozreCDpUp+LTskWVDUQ7ZnQOgeRgmeVJQYhxmmhSgTYC7Uend30PCFMlLRCtnseaRyNjscfUOtGB6gwnt+GT8qXRn3fAfs= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5207.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(376002)(346002)(396003)(136003)(66556008)(66476007)(186003)(316002)(31686004)(44832011)(8676002)(8936002)(478600001)(26005)(38100700002)(5660300002)(31696002)(86362001)(956004)(4326008)(2616005)(83380400001)(66946007)(6486002)(6666004)(2906002)(16576012)(36756003)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aDBZOHpoZjI0alhDTkVoR3p1WHhlNkd5Wkl2azRudnJJQ0o4VkZ4U3EwWElU?= =?utf-8?B?YXB4S0xYNFpaTy92SG1JSEJmQWFBNENJdGNTK0NydnBGb29PUllpdk5YcnVp?= =?utf-8?B?c210V1ZaRzZTRWtmUThmdlZISFdIRTVNdzBFcm1La1IzWjkxeVhrYXVVcytr?= =?utf-8?B?RjlBTUg0TFZCc2R6YXptM21vTzRqVnYrNXV5UG14bE9Qc2FZRnRTOThFMTla?= =?utf-8?B?RG1hTHRBVDR1RzZlRXpGeVB3TXVuUUdxVGVMUktRbVAyNW1FSVFPWm0wbFFJ?= =?utf-8?B?TU9tbDA3cDQwMmY1L1pDd0tiRUFiWWFKSXpIUUNGOFVVMUZRNkFvbEFLdlRW?= =?utf-8?B?MmUxVk1YLzZnYTRFa0NFZWJqVnNmaVVxbTRHMTErd2xnQ1V1cEVBV3JZQVl3?= =?utf-8?B?aU9RTmduNEpnK3ppN0l5L0VIeTg4aW1Va0F6WGtoWDZWbktiYVBITlpPUXhx?= =?utf-8?B?YjZoZFdZUGRPdW13dUsvbHdXcUxqVGp4Ly9aVThIK01QVzRnNmhqN25vbVF1?= =?utf-8?B?V3dyeFpNUzVVd2dka1ltU2JrZjBKNDZNT01vVXZLdHNkWnFsMFdUNFNKZDJW?= =?utf-8?B?NEwzaWNVQ2F3MjFQNFhRbjdEdDYzcEM4bzFiaHJZUlgwTDdyaVpSTU5XUWQy?= =?utf-8?B?K2NQclM3cjRPYVEyU0NJV3Z0cjF0QVA5MVIybGVuQ2U2N0FnRSt5VVdCMStm?= =?utf-8?B?T3psT2FoR1JwdUZGbFBtSkxjSGF0Ykk0V3FQbndTS3NLK2R5bTA3SzIrMi9x?= =?utf-8?B?YlQxOWJIekIzK2U2amQ5aVZGWWF6ZlFuRzBDK0tKSDVXalA3ZFlRNGREK2JI?= =?utf-8?B?Tkc2UGZ5RkZwa2YwZXNGQTlWNEIvVDg1VkpYK3hvYzJsV21pWnkrbUFwV2JD?= =?utf-8?B?dm9TNDlYU2xFY1E0RkZGN3NibDVMUUpMaUNlOXF3b0EvU08vTU9RQ09Md3c0?= =?utf-8?B?blRSazZjUklJQ0wyekE4QWZpYWhOejRKMW1YdFNrdlBzOHZ1SkRXV01hR3ll?= =?utf-8?B?YkJoQkJBcjBCWEFIRzlCcmRrcHQya3QrblNpYzFwdTI1Wmk1UVkxcWdzTnN0?= =?utf-8?B?OEJZTkkrbTF5RHJFdkJyOEJmdEtaV3Q1S3UzWUlDaW5FREhSeFhKSC9DNlJ6?= =?utf-8?B?dSs4Y3lycW51bkQ4VlIwc0k4RGtJWjVNbWtNWThHNWNraTN1RWRuamRzQVB4?= =?utf-8?B?RkV0QUZMRExPUStxeVAwTzRRemI5TDkrZjZZeGhyWUpjMVlSTktmT2cxYXEx?= =?utf-8?B?QmZCV3U1ZkhJRjhucm9kaENrWi9EQ1I0OFV2Yk82ZmllSU5INHQrSTJpeFcw?= =?utf-8?B?YytXMHZMcnZGaVgvb1ZudmtXZUt5cFJLZ29QQ2p6NFIxbHdTNmJ6OGZWK3o3?= =?utf-8?B?L08vYW5LdXRqeVplYW9MKzhIWTV6WHVtVVJ6akRHc2ZTbWVBS1lMZ3lPNExM?= =?utf-8?B?RHV3YWE2Vzd1RVlxdU44cnJ1T3BUMy9iMVhPQUNzczVoMVh0WTNEWTE3Zi84?= =?utf-8?B?NXZacCtGL0FBdmdTMmM3M2dxQnBqV1VnV2U5R3pkK2NrSGhxSDdFNGY3N0pX?= =?utf-8?B?V2lzb2tlY3orTHpzdEYzZzdib0F2VDBQcWpUVmk2cFVXMVFWWHM4Q3Q4Rm1p?= =?utf-8?B?RVM1VlN6dDNJaUZJanFBUE5iOUxaU3RzSm1kQ1ZaVE1sNmc3dGs3NTB1SGc5?= =?utf-8?B?MDNkSElYM1NNc3RiMmpvajcxS25UcDNhbjgvbkE1ZnZpcG1GajNRVTVHL1pZ?= =?utf-8?Q?intPlWUC76A/TY44mDMUDbx2q69l6dE04+TRfcp?= X-MS-Exchange-CrossTenant-Network-Message-Id: b2fcdae4-14e9-4176-715e-08d972e1c8ab X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5207.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 16:00:31.1255 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8hOwAPeIhYKvRWwZkIOtTaGsnj0fEDFwPpQpg/mK29VjXYXUuBWpHDKtDYHnXgAunmiIi7Kub/1Ey+MO33m8hg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5063 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 01/17] raw/ioat: only build if dmadev not present X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Bruce Richardson > > Only build the rawdev IDXD/IOAT drivers if the dmadev drivers are not > present. > > Signed-off-by: Bruce Richardson > --- > drivers/raw/ioat/meson.build | 23 ++++++++++++++++++++--- > 1 file changed, 20 insertions(+), 3 deletions(-) > > diff --git a/drivers/raw/ioat/meson.build b/drivers/raw/ioat/meson.build > index 0e81cb5951..7bd9ac912b 100644 > --- a/drivers/raw/ioat/meson.build > +++ b/drivers/raw/ioat/meson.build > @@ -2,14 +2,31 @@ > # Copyright 2019 Intel Corporation Minor nit the copyright should be updated to 2019-2021 > build = dpdk_conf.has('RTE_ARCH_X86') > +# only use ioat rawdev driver if we don't have the equivalent dmadev ones > +if not dpdk_conf.has('RTE_DMA_IDXD') and not dpdk_conf.has('RTE_DMA_IOAT') When disabling the dmadev drivers using -Ddisable_drivers=dma/* the rawdev driver isnt available to use for dma devices. The way this is ATM if dmadev is disabled it doesnt build rawdev. The logic should be - if dpdk_conf.has('RTE_DMA_IDXD') and dpdk_conf.has('RTE_DMA_IOAT') Reviewed-by: Conor Walsh