From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 67C1F1B467; Wed, 3 Apr 2019 16:48:33 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP; 03 Apr 2019 07:48:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,304,1549958400"; d="scan'208";a="132649623" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.103]) ([10.237.220.103]) by orsmga006.jf.intel.com with ESMTP; 03 Apr 2019 07:48:29 -0700 To: Bruce Richardson Cc: Andrius Sirvys , dev@dpdk.org, Kevin Laatz , stable@dpdk.org, ciara.power@intel.com References: <1553100181-32934-1-git-send-email-andrius.sirvys@intel.com> <7e3a6736-24bb-b235-0ce9-aae17ab5d4a0@intel.com> <20190403133010.GB1309@bricha3-MOBL.ger.corp.intel.com> From: "Burakov, Anatoly" Message-ID: <788abf93-a33f-3a72-9bc1-cc6725336859@intel.com> Date: Wed, 3 Apr 2019 15:48:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] usertools: replace unsafe input function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Apr 2019 14:48:34 -0000 On 03-Apr-19 3:29 PM, Burakov, Anatoly wrote: > On 03-Apr-19 2:30 PM, Bruce Richardson wrote: >> On Wed, Apr 03, 2019 at 11:44:40AM +0100, Burakov, Anatoly wrote: >>> On 20-Mar-19 4:43 PM, Andrius Sirvys wrote: >>>> LGTM static code analysis tool reports that the function 'input' is >>>> unsafe. Changed to use raw_input which then converts it using >>>> ast.literal_eval() which is safe. >>>> >>>> Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") >>>> Cc: ciara.power@intel.com >>>> >>>> Signed-off-by: Andrius Sirvys >>>> --- >>>>    usertools/dpdk-telemetry-client.py | 4 ++-- >>>>    1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/usertools/dpdk-telemetry-client.py >>>> b/usertools/dpdk-telemetry-client.py >>>> index ce0c7a9..c3ba77d 100755 >>>> --- a/usertools/dpdk-telemetry-client.py >>>> +++ b/usertools/dpdk-telemetry-client.py >>>> @@ -72,7 +72,7 @@ def requestMetrics(self): # Requests metrics for >>>> given client >>>>        def repeatedlyRequestMetrics(self, sleep_time): # Recursively >>>> requests metrics for given client >>>>            print("\nPlease enter the number of times you'd like to >>>> continuously request Metrics:") >>>> -        n_requests = int(input("\n:")) >>>> +        n_requests = int(ast.literal_eval(raw_input("\n:"))) >>>>            print("\033[F") #Removes the user input from screen, >>>> cleans it up >>>>            print("\033[K") >>>>            for i in range(n_requests): >>>> @@ -87,7 +87,7 @@ def interactiveMenu(self, sleep_time): # Creates >>>> Interactive menu within the scr >>>>                print("[3] Unregister client") >>>>                try: >>>> -                self.choice = int(input("\n:")) >>>> +                self.choice = int(ast.literal_eval(raw_input("\n:"))) >>>>                    print("\033[F") #Removes the user input for >>>> screen, cleans it up >>>>                    print("\033[K") >>>>                    if self.choice == 1: >>>> >>> >>> raw_input doesn't exist in Python 3. >>> >>> Perhaps you should do this at the top of the script: >>> >>> try: >>>      raw_input  # Python 2 >>> except NameError: >>>      raw_input = input  # Python 3 >>> >>> That way, all calls to raw_input will call the intended function. >>> >> >> The suggested way in the python docs is a little different: >> >> https://python-future.org/compatible_idioms.html#raw_input() >> > > Or that :) > Actually, this requires a dependency. "future" appears to be preinstalled on most distributions, but "builtins" isn't. In fact, i can't even find it in pip. -- Thanks, Anatoly From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 3782DA0679 for ; Wed, 3 Apr 2019 16:48:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F3A5D1B478; Wed, 3 Apr 2019 16:48:34 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 67C1F1B467; Wed, 3 Apr 2019 16:48:33 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP; 03 Apr 2019 07:48:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,304,1549958400"; d="scan'208";a="132649623" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.103]) ([10.237.220.103]) by orsmga006.jf.intel.com with ESMTP; 03 Apr 2019 07:48:29 -0700 To: Bruce Richardson Cc: Andrius Sirvys , dev@dpdk.org, Kevin Laatz , stable@dpdk.org, ciara.power@intel.com References: <1553100181-32934-1-git-send-email-andrius.sirvys@intel.com> <7e3a6736-24bb-b235-0ce9-aae17ab5d4a0@intel.com> <20190403133010.GB1309@bricha3-MOBL.ger.corp.intel.com> From: "Burakov, Anatoly" Message-ID: <788abf93-a33f-3a72-9bc1-cc6725336859@intel.com> Date: Wed, 3 Apr 2019 15:48:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] usertools: replace unsafe input function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190403144828.fjshs287NWMd8dSMqztDNxC-MqZYUCnappoHRvDj790@z> On 03-Apr-19 3:29 PM, Burakov, Anatoly wrote: > On 03-Apr-19 2:30 PM, Bruce Richardson wrote: >> On Wed, Apr 03, 2019 at 11:44:40AM +0100, Burakov, Anatoly wrote: >>> On 20-Mar-19 4:43 PM, Andrius Sirvys wrote: >>>> LGTM static code analysis tool reports that the function 'input' is >>>> unsafe. Changed to use raw_input which then converts it using >>>> ast.literal_eval() which is safe. >>>> >>>> Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") >>>> Cc: ciara.power@intel.com >>>> >>>> Signed-off-by: Andrius Sirvys >>>> --- >>>>    usertools/dpdk-telemetry-client.py | 4 ++-- >>>>    1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/usertools/dpdk-telemetry-client.py >>>> b/usertools/dpdk-telemetry-client.py >>>> index ce0c7a9..c3ba77d 100755 >>>> --- a/usertools/dpdk-telemetry-client.py >>>> +++ b/usertools/dpdk-telemetry-client.py >>>> @@ -72,7 +72,7 @@ def requestMetrics(self): # Requests metrics for >>>> given client >>>>        def repeatedlyRequestMetrics(self, sleep_time): # Recursively >>>> requests metrics for given client >>>>            print("\nPlease enter the number of times you'd like to >>>> continuously request Metrics:") >>>> -        n_requests = int(input("\n:")) >>>> +        n_requests = int(ast.literal_eval(raw_input("\n:"))) >>>>            print("\033[F") #Removes the user input from screen, >>>> cleans it up >>>>            print("\033[K") >>>>            for i in range(n_requests): >>>> @@ -87,7 +87,7 @@ def interactiveMenu(self, sleep_time): # Creates >>>> Interactive menu within the scr >>>>                print("[3] Unregister client") >>>>                try: >>>> -                self.choice = int(input("\n:")) >>>> +                self.choice = int(ast.literal_eval(raw_input("\n:"))) >>>>                    print("\033[F") #Removes the user input for >>>> screen, cleans it up >>>>                    print("\033[K") >>>>                    if self.choice == 1: >>>> >>> >>> raw_input doesn't exist in Python 3. >>> >>> Perhaps you should do this at the top of the script: >>> >>> try: >>>      raw_input  # Python 2 >>> except NameError: >>>      raw_input = input  # Python 3 >>> >>> That way, all calls to raw_input will call the intended function. >>> >> >> The suggested way in the python docs is a little different: >> >> https://python-future.org/compatible_idioms.html#raw_input() >> > > Or that :) > Actually, this requires a dependency. "future" appears to be preinstalled on most distributions, but "builtins" isn't. In fact, i can't even find it in pip. -- Thanks, Anatoly