From: Ray Kinsella <mdr@ashroe.eu>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Neil Horman <nhorman@tuxdriver.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Remove abi_versioning.sh from tree
Date: Thu, 9 Apr 2020 11:04:51 +0100 [thread overview]
Message-ID: <7893cc01-a750-e535-3786-9b3c91a90911@ashroe.eu> (raw)
In-Reply-To: <20200409092647.GE605@bricha3-MOBL.ger.corp.intel.com>
On 09/04/2020 10:26, Bruce Richardson wrote:
> On Wed, Apr 08, 2020 at 03:49:49PM +0100, Ray Kinsella wrote:
>>
>>
>> On 06/04/2020 20:34, Neil Horman wrote:
>>> Since we've moved away from our initial abi_versioning.sh script, in
>>> favor of check_abi.sh, which uses libabigail, remove the old script from
>>> the tree, and update the docs accordingly
>>>
>>> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
>>> CC: thomas@monjalon.net
>>> ---
>>> MAINTAINERS | 1 -
>>> devtools/validate-abi.sh | 251 ---------------------
>>> doc/guides/contributing/abi_versioning.rst | 18 +-
>>> 3 files changed, 9 insertions(+), 261 deletions(-)
>>> delete mode 100755 devtools/validate-abi.sh
>>>
> <snip>
>> diff --git a/doc/guides/contributing/abi_versioning.rst b/doc/guides/contributing/abi_versioning.rst
>>> index a21f4e7a4..1c4a3f927 100644
>>> --- a/doc/guides/contributing/abi_versioning.rst
>>> +++ b/doc/guides/contributing/abi_versioning.rst
>>> @@ -482,9 +482,9 @@ Running the ABI Validator
>>> -------------------------
>>>
>>
>> Could we simplify this all greatly, by telling people to use the meson/ninja build,
>> so they get this checking out of the box, without all the headache below?
>>
> The abi checks are not merged into the meson build - the idea was proposed
> and prototyped but never merged.
ah my mistake ... that is a shame
we need these kind of self check tooling.
>
> Regards,
> /Bruce
>
prev parent reply other threads:[~2020-04-09 10:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 19:34 Neil Horman
2020-04-07 7:36 ` David Marchand
2020-04-07 11:33 ` Neil Horman
2020-04-07 11:40 ` David Marchand
2020-04-07 11:58 ` Thomas Monjalon
2020-04-07 19:52 ` Neil Horman
2020-04-08 14:34 ` Ray Kinsella
2020-04-08 17:41 ` Thomas Monjalon
2020-04-08 14:50 ` Ray Kinsella
2020-04-08 14:49 ` Ray Kinsella
2020-04-09 9:26 ` Bruce Richardson
2020-04-09 10:04 ` Ray Kinsella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7893cc01-a750-e535-3786-9b3c91a90911@ashroe.eu \
--to=mdr@ashroe.eu \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).