From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA386A04DC; Tue, 20 Oct 2020 09:35:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 128C0BADE; Tue, 20 Oct 2020 09:35:32 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id A2148AD3E for ; Tue, 20 Oct 2020 09:35:30 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id D4662580458; Tue, 20 Oct 2020 03:35:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 20 Oct 2020 03:35:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= HoQDcbbyXaYxZGPMKl3KgRD2Bi62YicAA7xHRRIupvI=; b=XihWmCOsV8couGBe PZKx6bHhH85CiqRrw95DV7YetPC5N8xcqW2ZrKSC443TkYbms+VCsmYtFbzpnYRS 3jK68tvYAZv9lxH+oxFojtpnUnw6Gk/b8lkGX2u10trAwCoG9SlulA9mnvQlZVcf w3bg84HbtqVADp1hT+dJyZJOEeg1h5dqT1pNQnQBjCLseaUyHC9IOWZjlW9HPNdc GA1cgoG48uX/WhtwizGs7am2PjMb71bVWCZYnoVS3PNOqojgvRuY0ZV5QV8qeHrn xdBb5TvulzdpNLH2PgJVJGVyw0PtIeOY7UIkKJ+I16QhsRa/YnTovQraUZz37qS1 ObTY/w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=HoQDcbbyXaYxZGPMKl3KgRD2Bi62YicAA7xHRRIup vI=; b=a7TNT7tMuZp0PNgXUkv5oRNadJXi2XQNI09eh1nJx49+/l0I1bZVhBZeV N+VozWlxB901WCedpTr/PJQXuNYnl0lp+svuz5eJlh/EIYZZ77xyB59BJeiQ05Hy TS68oS3Bv1MTY/5fpODlUkUaJ3Cxj4p3Xqhi/qrOtn0rclHXOKeZyl/xRyZjm2i6 b90ho7Y1LIp0TEHcRlbSICUdRKOrEQLKidTJ9vWaX8yvR1/iDYu62JacFnicL5Ar RNULTWszx1RuJXybyUfyOgE6ExAPT+SXDjEzlAq1sljrwIMFwPvggsqdKOejxcvQ peHZ/WBAEmWxD0/f3/ew7U/GOS8OQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrjedvgddugeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2BF12306467E; Tue, 20 Oct 2020 03:35:26 -0400 (EDT) From: Thomas Monjalon To: Honnappa Nagarahalli , Ruifeng Wang Cc: "dev@dpdk.org" , Liang Ma , Jan Viktorin , David Christensen , Bruce Richardson , Konstantin Ananyev , "david.hunt@intel.com" , "jerinjacobk@gmail.com" , "timothy.mcdaniel@intel.com" , "gage.eads@intel.com" , "chris.macnamara@intel.com" , Anatoly Burakov , "david.marchand@redhat.com" , nd , David Christensen Date: Tue, 20 Oct 2020 09:35:24 +0200 Message-ID: <7898621.PryZgIvODB@thomas> In-Reply-To: References: <2164670.uy6Bi0JdNo@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 02/10] eal: add power management intrinsics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/10/2020 04:49, Ruifeng Wang: > From: Thomas Monjalon > > 15/10/2020 14:04, Anatoly Burakov: > > > +/** > > > + * This function is not supported on ARM. > > > + */ > > > +static inline void > > > +rte_power_monitor(const volatile void *p, const uint64_t > > expected_value, > > > + const uint64_t value_mask, const uint64_t tsc_timestamp, > > > + const uint8_t data_sz) { > > > + RTE_SET_USED(p); > > > + RTE_SET_USED(expected_value); > > > + RTE_SET_USED(value_mask); > > > + RTE_SET_USED(tsc_timestamp); > > > + RTE_SET_USED(data_sz); > > > +} > > > > Are you sure it cannot be partially supported with WFE instruction? > > > Armv8 WFE instruction can support monitoring of specific address for changes, > but not monitoring of TSC timestamp. So it is a partial support. We must try hard to unify architectures support to avoid #ifdef everywhere. I don't agree with how are managed new instructions recently. Please look further.