From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7898A052A; Mon, 25 Jan 2021 16:02:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3D239140F6D; Mon, 25 Jan 2021 16:02:43 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id C4A0D140F64 for ; Mon, 25 Jan 2021 16:02:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611586961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pefjR0vbu+gJYb3ZheKCm7+0Vm6Ptd7ZE5SKsRurRbg=; b=LmEdF7ZUVPnKXK7BTRcMvSiUIXt2/AGfqnb8IChbX7csBq6Ad6GHs/iUhxHm6AYu9W/xUG cEmJLc0K6Ao6HrAVriOeoitPpw865XDwp21SB+q9Nr8I7Nv/Q9WvhORXtNeAyMnufHZP9m hvGVm0PJ4fUIlIYv19UX0jsAQMJWNuk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-554-1jdCZcpFP26JBNlFvoM-kg-1; Mon, 25 Jan 2021 10:02:38 -0500 X-MC-Unique: 1jdCZcpFP26JBNlFvoM-kg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2E79F8145E3; Mon, 25 Jan 2021 15:02:37 +0000 (UTC) Received: from [10.36.110.31] (unknown [10.36.110.31]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D0A5C6F985; Mon, 25 Jan 2021 15:02:32 +0000 (UTC) To: "Xia, Chenbo" , "dev@dpdk.org" , "olivier.matz@6wind.com" , "amorenoz@redhat.com" , "david.marchand@redhat.com" References: <20210119212507.1043636-1-maxime.coquelin@redhat.com> <20210119212507.1043636-43-maxime.coquelin@redhat.com> From: Maxime Coquelin Message-ID: <78a93ecf-3e51-912c-2eae-38458bdeae1e@redhat.com> Date: Mon, 25 Jan 2021 16:02:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 42/44] net/virtio: move Vhost-vDPA data to its backend X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/22/21 10:06 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -----Original Message----- >> From: Maxime Coquelin >> Sent: Wednesday, January 20, 2021 5:25 AM >> To: dev@dpdk.org; Xia, Chenbo ; olivier.matz@6wind.com; >> amorenoz@redhat.com; david.marchand@redhat.com >> Cc: Maxime Coquelin >> Subject: [PATCH v2 42/44] net/virtio: move Vhost-vDPA data to its backend >> >> As done earlier for Vhost-user and Vhost-kernel, this >> patch moves the Vhost-vDPA specific data to its backend >> file. >> >> Signed-off-by: Maxime Coquelin >> --- >> drivers/net/virtio/virtio_user/vhost_vdpa.c | 120 +++++++++++++----- >> .../net/virtio/virtio_user/virtio_user_dev.h | 4 - >> 2 files changed, 89 insertions(+), 35 deletions(-) >> ... >> >> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.h >> b/drivers/net/virtio/virtio_user/virtio_user_dev.h >> index 36a9cadcad..9a6723da24 100644 >> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.h >> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.h >> @@ -29,9 +29,6 @@ struct virtio_user_dev { >> enum virtio_user_backend_type backend_type; >> bool is_server; /* server or client mode */ >> >> - /* for vhost_vdpa backend */ >> - int vhostfd; >> - >> /* for both vhost_user and vhost_kernel */ > > I remember you agreed that this comment is no longer needed? Indeed, I missed to remove it. Done now. > I also noticed that there're multiple calls of PMD_DRV_LOG that add > '\n' in the end, which is necessary. But, let's clean it up later.. Yes, there may still be redundant new lines at some places, I agree we fix that later. > With above fixed: > > Reviewed-by: Chenbo Xia > Thanks, Maxime