From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 54088A0096 for ; Thu, 6 Jun 2019 21:58:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 46E995424; Thu, 6 Jun 2019 21:58:19 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 1527F1E2F for ; Thu, 6 Jun 2019 21:58:18 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7646630C319D; Thu, 6 Jun 2019 19:58:17 +0000 (UTC) Received: from [10.36.117.226] (ovpn-117-226.ams2.redhat.com [10.36.117.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id 50671619E6; Thu, 6 Jun 2019 19:58:12 +0000 (UTC) To: Mesut Ali Ergin , beilei.xing@intel.com, qi.z.zhang@intel.com Cc: dev@dpdk.org References: <1559838642-125443-1-git-send-email-mesut.a.ergin@intel.com> From: Kevin Traynor Message-ID: <78d4b3a8-fc34-5dc1-85aa-2f31a8af2acf@redhat.com> Date: Thu, 6 Jun 2019 20:58:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1559838642-125443-1-git-send-email-mesut.a.ergin@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Thu, 06 Jun 2019 19:58:17 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] net/i40e: uninitialized value fixed in i40e_flow_parse_fdir_action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 06/06/2019 17:30, Mesut Ali Ergin wrote: > Initializes mark_spec pointer to NULL. > > Fixes: 0bbcfc706a2b ("net/i40e: support MARK and RSS flow action") > Coverity issue: 341075 > > Signed-off-by: Mesut Ali Ergin Acked-by: Kevin Traynor > --- > drivers/net/i40e/i40e_flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c > index 9bfbea2..d62b32f 100644 > --- a/drivers/net/i40e/i40e_flow.c > +++ b/drivers/net/i40e/i40e_flow.c > @@ -3052,7 +3052,7 @@ i40e_flow_parse_fdir_action(struct rte_eth_dev *dev, > struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private); > const struct rte_flow_action *act; > const struct rte_flow_action_queue *act_q; > - const struct rte_flow_action_mark *mark_spec; > + const struct rte_flow_action_mark *mark_spec = NULL; > uint32_t index = 0; > > /* Check if the first non-void action is QUEUE or DROP or PASSTHRU. */ >