From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42B5945B17; Sat, 12 Oct 2024 04:27:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0916940272; Sat, 12 Oct 2024 04:27:43 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2089.outbound.protection.outlook.com [40.107.94.89]) by mails.dpdk.org (Postfix) with ESMTP id 4762740268 for ; Sat, 12 Oct 2024 04:27:41 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=c1a0HTHxTdK8wVpP1ynHcx6Ve9wW54Nz0JwgNdUFIFxmM6yOyFN5Olo2Hk4/HpBigMR08xUVj5CAh6Qvh2EKastnXrkBlEpad7dz24fZoQVRvUR/9BfrWNUfkIskqtIjZOZU6JMQZ8CvjUuTsPgUjzMBhepvLR+BIlb9dUelgGpB2pm35cNnTKC6TGQY4kdkISq7g2frBKzVFvkqtOH9M6doQOgorDQn0LuOq045A2nO1ZQrPKpvFMtdOSzAVe+1nEr1V2bYa+0yNuJQ3mnQE2/xZHickSPbnP9q7HnThXct+FeQdg/ro2dkG33fVfumABRrvgo1v+bP+qT4YV4UPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cqGhWqT3A429+V5ru9kcGWKXhy5GoBwrmY/lXZwXsrw=; b=YhJXLHOS37br88fSx+2eZFQK2XoLBwSug6K5ervAMOP5EeX3fHNlIBJNbPC+WjeQ0s3TK2u/msPqzMS8PLYL4TJ8POo4mVtLG38rsdXpGJjwjFnoQhvn+E1Jhd1MWz/CXczmnzZKYNDphFQV03/B/nSQBS2AIkLjhWhqCg6EWMOyCKP6DMXRv5Da+hG84rKOG8IG0bPCL7Q4Y3ZjmWY5s+Z8BDoPjEmcFd5yLpS/Jnc0oG1zKmSrsN3dPd/5nVgLIcWrFfptS0G/XHfrkc+JjOkhtFBL8DA1CAnkDLi/LyOCmTVm2mSbbbmH9vrYh6Z+Y/8a0VKglfMSih8ilZJg+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cqGhWqT3A429+V5ru9kcGWKXhy5GoBwrmY/lXZwXsrw=; b=JzbdCVC/ViFooqRCCWBxfRTpqzEYLy87EnbihO1Vo1vLUWSW8ER2ryFZC4DdsSO4IZvNxBtx1FVadupJyBYz8zKf50CScqhP/upLkHBG74ptjsly9PwPTaEtlndT42Wphqv6dzlMQ2caSQaIAiLlmfcBCBkblpSNxkl2OmO0laM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by DM4PR12MB6232.namprd12.prod.outlook.com (2603:10b6:8:a5::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.16; Sat, 12 Oct 2024 02:27:36 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.8048.017; Sat, 12 Oct 2024 02:27:35 +0000 Message-ID: <78d72ce0-88b7-4e0b-8acc-4da7b7a527d8@amd.com> Date: Sat, 12 Oct 2024 03:27:25 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] ethdev: verify queue ID when Tx done cleanup To: Andrew Rybchenko , Jie Hai , lihuisong@huawei.com, fengchengwen@huawei.com Cc: dev@dpdk.org, thomas@monjalon.net, Keith Wiles , Billy McFall References: <20240905064638.17980-1-haijie1@huawei.com> <20240905064638.17980-2-haijie1@huawei.com> <20681877-7c2a-4b54-bf32-0de7779df55c@oktetlabs.ru> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20681877-7c2a-4b54-bf32-0de7779df55c@oktetlabs.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0313.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:390::15) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|DM4PR12MB6232:EE_ X-MS-Office365-Filtering-Correlation-Id: dd63948f-4068-44dc-b90a-08dcea656f1f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TmZicEZ1WDg4cGpjR29iVnZCdTFvcms1ZXloOStHVEpZbzJqZ0RTT3hRWnB5?= =?utf-8?B?Uko0Vmw5Y05OWEJXOURhL3pUVFVzZVdJV05jdStzZXF3dHFOQkZTa29ESjly?= =?utf-8?B?Qm1lci93Y1pKRC9WVFFYMFJ2NHVGNkdXSS9oL3BhN2RqcnR3R2htMVY4MXpn?= =?utf-8?B?REVWclMvTnJsSjlqU1ZWNEZsc3V6enFTNC83dU55aTJUNHNmaDhGemZ2ZWlY?= =?utf-8?B?dzZBN2E1ZWw1emtXRjh3OXJmRGFUTlkwMVJNa2NtanRHMFBESFVHU2Z5MnFP?= =?utf-8?B?UEJKRTBtSHZXRVE4aTh1ekQrdXZPb3N6c2Y1N1o1Q3E3V2pPVXNaQlZYbzhr?= =?utf-8?B?eTFKNjh1aTZtNUl5bm9pN20yeURMUXJZeHpEOTM2SVI2R2c5UnlIK2dQTHcw?= =?utf-8?B?aWFVUFkrTmpOQzhQZVpUODg1c3ZjZSs3YWQ2cFA2T3FIUDdRcU9oUjE2UVQy?= =?utf-8?B?YTBnVVM1TmlRclN0ekRlVjlNUVRyZUlFYWczdjFibmFDOUk5VlIvdUE4R2Ni?= =?utf-8?B?OFgzcExMcHVCWVFhZHBTb1BVMnJXM2tkbWFIbHVCSGV6bmpWYjRrWmNZN1Ux?= =?utf-8?B?MEdyaVBGWjhTNHlUWml0M0JKTEFnS1pRNWsvZWpOUTFqYmZSclhnK0wvM3FO?= =?utf-8?B?aHNuY3JFd2hOaXFLM0hJcUU2Ky9MaTZnWnl2VFM3QTdrdG9zTGE5Y2RVR2Fi?= =?utf-8?B?WUVNUk9WZi9ic085SXc3ZXlBV2VGU3VpZFdObHNUNUdBMGh2OEpsV0RDM0Ri?= =?utf-8?B?WnFKQURNR1N1T09XYXJOeFVwZjRleU10KzZENVBHQ2FjVFBTamNRcnlNaDdX?= =?utf-8?B?Tkt0VmNZR2REVDZjbGJleDFhZkdDRXJTNW9CbUhoVFJydFhPK0dIL2wyblVB?= =?utf-8?B?QjVaK1Z0TU44d1VJU0VGS2ROVUtpcCtLQlNHZXZ3V1lodVArVXhaRllqZy9Z?= =?utf-8?B?OXR1SFhOVitVWWhwK0labTNYTzl3MHVrWVBJUHR5bTNCS2NiREdGckhTRVgv?= =?utf-8?B?U1VObUlDcElpcDZVUTlOMEpPTVI1Y3dHdTQwWE8weFVFOGVRM0IyMkUvRzE4?= =?utf-8?B?WFBuY0xvS3BWa3A1cWhnNE1ySEh1S0svZ21heHd1d2JJZzRLak4zeWpTZE1r?= =?utf-8?B?cG44Yk1zdnYrRlVlVHVDdW96aTU2VDJncG5HQ1FvVzdibUVTTEp1WGJCZDh4?= =?utf-8?B?eERXS1hyZmVFemRWbU45dG96c25xWkJudE1rWWpvWVVMN2s2WjNsVHd0L3NJ?= =?utf-8?B?UEpvS25rekFwUFBJUEsrMVdaTkxCcWxLRzBGbVZTT20wazB4SWROOVgxSVpW?= =?utf-8?B?Uld0NktISEgvMjF2WG9UTEtKUEdtZms4UGI1Yy9RMHY3TlRTaWpqUnRabDZK?= =?utf-8?B?SVBIdlUxZFZpdlN1Yjh6MjFzZHZFYk5LenJJODBwNWJ5d2xscktNOW5sNTFv?= =?utf-8?B?SnVrUlRUUGNKYmhNVDlvdDhMM1hiazd3Qmo2S1FCZXRYbHhkUCtOcW9aTlB0?= =?utf-8?B?Rmxsdk1ER0dXdjZva0NLc3VNSlRIM1I5SHp5TWRrdGRScnFvNmJrb1NkVkZF?= =?utf-8?B?UHlGdzE2dGorbmdGRW1OWjkyMGNCODJYcVZPVDBCZ0RkdDI2VjFvZkhsU1Y5?= =?utf-8?B?ZERCOXI3Q1JaNG5YeTdmNTNHMnF1WWhvNUd6VWFPd3c4QU5DcWhyQjBhNU9D?= =?utf-8?B?ek5Na1cvcUVQWVZ4ejB1MHhRNmI3MnhpZGY4cml2K1EwS1d4SnplL0NRPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZHRsMjhQUWdyb2Y1Y3JTSjE5ZmFKOTA1QjhQQXBFc3lNN3Z6Qi9YaFVpYjB0?= =?utf-8?B?Q2VrM29OeU9laVZ0L2ZzZFZHRzloSGxBUVpaODFURFdDVXdLY1U0ZmtiUzdx?= =?utf-8?B?eitKU2wwL3dnRnRSaVpvM2J0aGViaEJLQVh5NnV2SzVpTjBBSTJiV1lQWi9o?= =?utf-8?B?alI3ZDlKUU5uMzIrZk81eE9tbEFYazZ2cm9hN0JHc012c3JZWGN1enhLbUtT?= =?utf-8?B?bnhSUGFpWi9WdVJxamMxMFNSRnJJMDdPa1RscnZ0Uk5KTjdEa3A2WVdHYzJL?= =?utf-8?B?QUFnVkRCKy9LSnN1Zml1WVExSmk0c0lqcFE0YW8wRVNOV2ZXRzJsamx2aGdw?= =?utf-8?B?SmR4SzNYUTdjcXkzZ1poUkNIL096RTBCU2UzdUxub0xxdWZEQmFQeGhWa0U4?= =?utf-8?B?a0x2dEJWY2JlSDZzdlJmcGNhYjNCWWdMZThhZWFoR2NTNHF4VEluL29ocDAx?= =?utf-8?B?UGQvL0ZHTC9DanQvZDNOaDFjVFBRSlNwK0tJdHBIRXdHZ0tkMEJleG9rcGZy?= =?utf-8?B?WVd3M3JGK09kZkZsb3RWUHluMmMxV000ZmtsV3MvMktmNkM3czJoc3FtaUs1?= =?utf-8?B?SDVIWnNXaUxjR2VWYW9RWWkwMHlhL1VsdUJXc0VzT0JMRlJBdjRLNHh5U3BP?= =?utf-8?B?TjFycjlVdE1hMHRCMnNnQlllRDlmYkxONlF2a1NGMytiazJ5d29INXhYWkZo?= =?utf-8?B?S0FQb1oyVTNVVnVxY09VWC9WZjkyZXowVU1iazdqQkZSaHpEK09WMktNRWlt?= =?utf-8?B?R2M4V0x3dERuMDFiV2NNZFl5YXpTUGVld2EvYzgydGM1VFN6TzBmbGtBUjhs?= =?utf-8?B?NGRoSWhub0VvQ1FQZ1pxNElRNUFCT3hDRDRYSmo5cktKd041M0h0eFdUeDVz?= =?utf-8?B?Y040b25qTWxpNm5OTEZJM1QyVTlqS0JDcUV5a0Zwa1ZoOWlnNnQvQ2ZuUTht?= =?utf-8?B?NllRbjludFZKRXZXSjRGOUxSODBpUDFRQkQ1K285QVVYZ3d0RHdweTBkSlpx?= =?utf-8?B?azkrNWNKcW16c1dqWE5TcjM5UGlxdVFPRUZraENGU1JNTDlvT2lFQlNIbTVY?= =?utf-8?B?L2JBdFlRWVdqNkM3aGJ4UDJ4MW9VTnVIZDBzaEJ5b0JjUlNpU2lVRGV1R0Fh?= =?utf-8?B?bnJOblJraENQVncvemxQMGJGZUVQRk5Wa1lWd3k2THFZTmgrcXk1TWVjTVNj?= =?utf-8?B?NjBMbkJCTEJvZCsvUVVhWFUya3FMNWhSa25kWERObytUKy9weTZDYktnNEl4?= =?utf-8?B?aXA4c3puVmdZK2doK2dpcWpWM3pNam5RTkp5UzhZK2UzbTdHY0FmSEZZZkFN?= =?utf-8?B?S2gyT3FPVXJnL1FKL0g5Y0g3bG1vRzFINVA3eS8zYnNNdlBST29aOGU5UnFU?= =?utf-8?B?LzhGY09idjlZUGlRME9yWXNIbHAwa1pITE9IdVMxVy9KYmYraFdwSTlraW1j?= =?utf-8?B?MDBoMXlCbEUrcjNnRURBTVpwczJYYWFlRUJNcmlWNTYyMjN1TWtwdWVJVFR1?= =?utf-8?B?RjdHM0hwUDJWdGxMOUhoN0FvMHVhZnBPRTRHNXlLY2VlTWZtNkZRTGltdWV5?= =?utf-8?B?ZVlLNnJuRXNkRjdmVVp2QWgzNmgwY3g5SmxnL2YrTkNibVB4VnlvZjh2bWNZ?= =?utf-8?B?ak9VV01JOEs2Tm9TejAvQkN3cXhOT2U2REcwam5zZTJoUVg4ZHFDUnFmN2kx?= =?utf-8?B?QytlNXdSMnljSk0wSXhtT3pzOTRSSlB1V1hwRFh5RFR3NnhDNUhqSm8wamxH?= =?utf-8?B?bXJuM3IyOFUrRGJLajdaMHFTc0NhVlNKRDd5Qnd0STNRVG10SFd4cTRuVDV5?= =?utf-8?B?OGczUFlLVVpSNWFWSXZZODRBVVJjaktFWGYydDkwQksvL0RVWTh5aFJYaWhn?= =?utf-8?B?anl3ZkpxVUdRd3p0SGdza2tyekZ2T3IxbTBZeGhKZTJxS2c0TFcvMDRvS3hR?= =?utf-8?B?TENKQlZSWXdKMzhnWDJNNm4xZEdJZWRCLzU1alYrelNHWnpkY3dKV3RsN1Q5?= =?utf-8?B?M2NRbEV6QXoxRkVRTXBNNnMveWFiWGxGbkRpWXFQVlM5TEJ6bjdhZ05UU3M0?= =?utf-8?B?ZG1QN2g1RTBMN2RtdVdXTCsxRkFpemRNTlBtTEJpb0VuM2dHV1c0WlovMHZt?= =?utf-8?Q?rtHVFLP67bJGwP4BPDsU/B3Q5?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd63948f-4068-44dc-b90a-08dcea656f1f X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2024 02:27:35.8953 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gmVneBkWT1eCtH2OUh1CovR6omHI+wzri5nK3IAGiJnARqNt0KxKBiH9KYI+whDe X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6232 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/5/2024 8:33 AM, Andrew Rybchenko wrote: > On 9/5/24 09:46, Jie Hai wrote: >> From: Chengwen Feng >> >> Verify queue_id for rte_eth_tx_done_cleanup API. > > If I'm not mistaken the function is considered data path API (fast). > If so, it should not validate it's parameters as in rte_eth_tx_burst(). > It may be done under RTE_ETHDEV_DEBUG_TX only. > > May be documentation should be fixed to highlight it. > > And yes, current implementation looks inconsistent from this point of > view since port_id and presence of callback are checked. > > Anyway motivation in the patch description is insufficient. > Hi Chengwen, I agree with Andrew, to not add checks to the datapath function. Can you please explain more why this check is needed at first place? Is it for a specific usecase? >> >> Fixes: 44a718c457b5 ("ethdev: add API to free consumed buffers in Tx >> ring") >> Cc: stable@dpdk.org >> >> Signed-off-by: Chengwen Feng >> --- >>   lib/ethdev/rte_ethdev.c | 4 ++++ >>   1 file changed, 4 insertions(+) >> >> diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c >> index f1c658f49e80..998deb5ab101 100644 >> --- a/lib/ethdev/rte_ethdev.c >> +++ b/lib/ethdev/rte_ethdev.c >> @@ -2823,6 +2823,10 @@ rte_eth_tx_done_cleanup(uint16_t port_id, >> uint16_t queue_id, uint32_t free_cnt) >>       RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); >>       dev = &rte_eth_devices[port_id]; >>   +    ret = eth_dev_validate_tx_queue(dev, queue_id); >> +    if (ret != 0) >> +        return ret; >> + >>       if (*dev->dev_ops->tx_done_cleanup == NULL) >>           return -ENOTSUP; >>   >