From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <andy@warmcat.com>
Received: from mail.warmcat.com (mail.warmcat.com [163.172.24.82])
 by dpdk.org (Postfix) with ESMTP id 605563572
 for <dev@dpdk.org>; Wed, 30 May 2018 02:32:53 +0200 (CEST)
From: Andy Green <andy@warmcat.com>
To: dev@dpdk.org
References: <43ec6b34-b68c-618e-ab14-1f1b85f3315c@warmcat.com>
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
 Jasvinder Singh <jasvinder.singh@intel.com>
Message-ID: <78d8dbdb-1508-d8ba-1934-5cae91b6800d@warmcat.com>
Date: Wed, 30 May 2018 08:32:19 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
In-Reply-To: <43ec6b34-b68c-618e-ab14-1f1b85f3315c@warmcat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] Stable ABI status of
 rte_meter_[t|s]rtcm_profile_config
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 30 May 2018 00:32:53 -0000



On 05/28/2018 11:31 AM, Andy Green wrote:
> Hi -
> 
> Between 18.02 and the putative 18.05 there were changes in the way the 
> meter stuff deals with its config.
> 
> I updated the related code in lagopus, but I get warnings about using 
> the new APIs (it's the same for rte_meter_trtcm_profile_config())
> 
> ./dpdk/meter.c: In function 'dpdk_register_meter':
> ./dpdk/meter.c:119:7: warning: 'rte_meter_srtcm_profile_config' is 
> deprecated: Symbol is not yet part of stable ABI 
> [-Wdeprecated-declarations]
>         rte_meter_srtcm_profile_config(&lband->sp, &param);
>         ^
> In file included from ./dpdk/meter.c:27:0:
> /home/agreen/lagopus/src/dpdk/build/include/rte_meter.h:86:1: note: 
> declared here
>   rte_meter_srtcm_profile_config(struct rte_meter_srtcm_profile *p,
>   ^
> ./dpdk/meter.c:132:7: warning: 'rte_meter_srtcm_profile_config' is 
> deprecated: Symbol is not yet part of stable ABI 
> [-Wdeprecated-declarations]
>         rte_meter_srtcm_profile_config(&lband->sp, &param);
>         ^
> In file included from ./dpdk/meter.c:27:0:
> /home/agreen/lagopus/src/dpdk/build/include/rte_meter.h:86:1: note: 
> declared here
>   rte_meter_srtcm_profile_config(struct rte_meter_srtcm_profile *p,
> 
> 
> As far as I can see this api change is not optional, it changes the 
> parameters for related apis to require a struct prepared with these new 
> apis.

IOW should these exports still be "experimental"

EXPERIMENTAL {
         global:

         rte_meter_srtcm_profile_config;
         rte_meter_trtcm_profile_config;
};

...when the changes also introduced in 
c06ddf9698e0c2a9653cfa971f9ddc205065662c unconditionally modify the 
existing APIs to require the new stuff?

@@ -138,6 +187,7 @@ rte_meter_srtcm_color_aware_check(struct 
rte_meter_srtcm *m,
   */
  static inline enum rte_meter_color
  rte_meter_trtcm_color_blind_check(struct rte_meter_trtcm *m,
+       struct rte_meter_trtcm_profile *p,
         uint64_t time,
         uint32_t pkt_len);

etc

-Andy

> -Andy